Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: ferruh.yigit@intel.com, spp@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH] spp_primary: revise comments
Date: Thu, 31 Jan 2019 12:05:48 +0900	[thread overview]
Message-ID: <1548903948-17500-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This update is to revise comments for global variables.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/primary/init.c | 4 +++-
 src/primary/main.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/primary/init.c b/src/primary/init.c
index 85b54a3..28ad0a7 100644
--- a/src/primary/init.c
+++ b/src/primary/init.c
@@ -23,6 +23,7 @@ static struct rte_mempool *pktmbuf_pool;
 /* the port details */
 struct port_info *ports;
 
+/* global var - extern in header */
 uint8_t lcore_id_used[RTE_MAX_LCORE] = {};
 
 /**
@@ -109,7 +110,7 @@ init(int argc, char *argv[])
 	int lcore_id;
 	const struct rte_memzone *mz;
 	uint16_t count, total_ports;
-	char log_msg[1024] = { '\0' };
+	char log_msg[1024] = { '\0' };  /* temporary log message */
 
 	/* init EAL, parsing EAL args */
 	retval = rte_eal_init(argc, argv);
@@ -163,6 +164,7 @@ init(int argc, char *argv[])
 	/* Initialise the ring_port. */
 	init_shm_rings();
 
+	/* Inspect lcores in use */
 	RTE_LCORE_FOREACH(lcore_id) {
 		lcore_id_used[lcore_id] = 1;
 	}
diff --git a/src/primary/main.c b/src/primary/main.c
index c86e9ef..8d12bf6 100644
--- a/src/primary/main.c
+++ b/src/primary/main.c
@@ -44,7 +44,7 @@ static enum cmd_type cmd = STOP;
 
 static struct pollfd pfd;
 
-/* global var for number of rings - extern in header */
+/* global var - extern in header */
 uint8_t lcore_id_used[RTE_MAX_LCORE];
 
 static void
-- 
2.7.4

                 reply	other threads:[~2019-01-31  3:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548903948-17500-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).