From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 4/6] shared/sec: rename func for parsing port UID
Date: Tue, 21 May 2019 11:31:20 +0900 [thread overview]
Message-ID: <1558405882-8201-5-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1558405882-8201-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
This update is to rename `decode_port_value()` to `parse_port_uid()`
because it is not for decoding but parsing resource UID of port such
as `phy:0`, and the term `port value` is ambiguous.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
.../secondary/spp_worker_th/cmd_parser.c | 19 ++++++++++++-------
src/shared/secondary/spp_worker_th/spp_proc.h | 4 ++--
2 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c
index 02528d6..5658893 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.c
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.c
@@ -258,18 +258,23 @@ get_vlan_uint_val(unsigned int *output, const char *arg_val, unsigned int min,
return SPP_RET_OK;
}
-/* decoding procedure of port */
+/* Parse given res UID of port and init object of struct sppwk_port_idx. */
+/* TODO(yasufum) Confirm why 1st arg is not sppwk_port_idx, but void. */
+/**
+ * TODO(yasufum) Confirm why this func is required. Is it not enough to use
+ * parse_resource_uid() ?
+ */
static int
-decode_port_value(void *output, const char *arg_val)
+parse_port_uid(void *output, const char *arg_val)
{
- int ret = SPP_RET_OK;
+ int ret;
struct sppwk_port_idx *port = output;
ret = parse_resource_uid(arg_val, &port->iface_type, &port->iface_no);
if (unlikely(ret != 0)) {
- RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad port. val=%s\n", arg_val);
+ RTE_LOG(ERR, SPP_COMMAND_PROC,
+ "Invalid resource UID '%s'.\n", arg_val);
return SPP_RET_NG;
}
-
return SPP_RET_OK;
}
@@ -412,7 +417,7 @@ decode_port_port_value(void *output, const char *arg_val, int allow_override)
struct sppwk_port_idx tmp_port;
struct sppwk_cmd_port *port = output;
- ret = decode_port_value(&tmp_port, arg_val);
+ ret = parse_port_uid(&tmp_port, arg_val);
if (ret < SPP_RET_OK)
return SPP_RET_NG;
@@ -665,7 +670,7 @@ parse_cls_port(void *cls_cmd_attr, const char *arg_val,
struct sppwk_port_idx tmp_port;
int64_t mac_addr = 0;
- ret = decode_port_value(&tmp_port, arg_val);
+ ret = parse_port_uid(&tmp_port, arg_val);
if (ret < SPP_RET_OK)
return SPP_RET_NG;
diff --git a/src/shared/secondary/spp_worker_th/spp_proc.h b/src/shared/secondary/spp_worker_th/spp_proc.h
index aeb8e92..8f9f11d 100644
--- a/src/shared/secondary/spp_worker_th/spp_proc.h
+++ b/src/shared/secondary/spp_worker_th/spp_proc.h
@@ -191,8 +191,8 @@ struct sppwk_cls_attrs {
* attributions, use `sppwk_port_info` which has additional port params.
*/
struct sppwk_port_idx {
- enum port_type iface_type; /**< phy, vhost or ring */
- int iface_no;
+ enum port_type iface_type; /**< phy, vhost or ring. */
+ int iface_no;
};
/* Define detailed port params in addition to `sppwk_port_idx`. */
--
2.17.1
next prev parent reply other threads:[~2019-05-21 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 2:31 [spp] [PATCH 0/6] Refactor parsing resource UID ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 1/6] shared/sec: refactor func for getting VLAN ID ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 2/6] shared/sec: rename misspelled get_arrary_index ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 3/6] shared/sec: remove misunderstandable validate func ogawa.yasufumi
2019-05-21 2:31 ` ogawa.yasufumi [this message]
2019-05-21 2:31 ` [spp] [PATCH 5/6] shared/sec: fix funcs for getting int and uint ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 6/6] shared/sec: rename func for parsing lcore ID ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558405882-8201-5-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).