From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 6/6] shared/sec: rename parsing comp action
Date: Tue, 21 May 2019 11:32:04 +0900 [thread overview]
Message-ID: <1558405924-8303-7-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1558405924-8303-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
This update is to redundant rename `decode_port_action_value()` to
`parse_port_action()`.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/shared/secondary/spp_worker_th/cmd_parser.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c
index 7d56146..88b4b4f 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.c
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.c
@@ -303,10 +303,11 @@ parse_comp_action(void *output, const char *arg_val,
int allow_override __attribute__ ((unused)))
{
int ret;
+ /* Get index of registered commands. */
ret = get_list_idx(arg_val, CMD_ACT_LIST);
if (unlikely(ret <= 0)) {
RTE_LOG(ERR, SPP_COMMAND_PROC,
- "Unknown component action. val=%s\n",
+ "Given invalid cmd `%s`.\n",
arg_val);
return SPP_RET_NG;
}
@@ -391,12 +392,13 @@ parse_comp_type(void *output, const char *arg_val,
return SPP_RET_OK;
}
-/* decoding procedure of action for port command */
+/* Parse given action for port of `arg_val`. */
static int
-decode_port_action_value(void *output, const char *arg_val,
- int allow_override __attribute__ ((unused)))
+parse_port_action(void *output, const char *arg_val,
+ int allow_override __attribute__ ((unused)))
{
- int ret = SPP_RET_OK;
+ int ret;
+ /* Get index of registered commands. */
ret = get_list_idx(arg_val, CMD_ACT_LIST);
if (unlikely(ret <= 0)) {
RTE_LOG(ERR, SPP_COMMAND_PROC,
@@ -405,6 +407,7 @@ decode_port_action_value(void *output, const char *arg_val,
return SPP_RET_NG;
}
+ /* TODO(yasufum) fix not explicit checking this condition. */
if (unlikely(ret != SPPWK_ACT_ADD) &&
unlikely(ret != SPPWK_ACT_DEL)) {
RTE_LOG(ERR, SPP_COMMAND_PROC,
@@ -413,7 +416,7 @@ decode_port_action_value(void *output, const char *arg_val,
return SPP_RET_NG;
}
- *(int *)output = ret;
+ *(int *)output = ret; /* TODO(yasufum) confirm the statement is OK. */
return SPP_RET_OK;
}
@@ -825,7 +828,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = {
.name = "action",
.offset = offsetof(struct spp_command,
spec.port.wk_action),
- .func = decode_port_action_value
+ .func = parse_port_action
},
{
.name = "port",
--
2.17.1
prev parent reply other threads:[~2019-05-21 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 2:31 [spp] [PATCH 0/6] Revise name of funcs for parsing actions ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 1/6] shared/sec: rename parse comp action val ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 2/6] shared/sec: rename func for parsing comp name ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 3/6] shared/sec: refacotr comments for parse " ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 4/6] shared/sec: rename func for parsing lcore ID ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 5/6] shared/sec: rename func of parsing comp type ogawa.yasufumi
2019-05-21 2:32 ` ogawa.yasufumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558405924-8303-7-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).