From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A39E7A045E for ; Fri, 31 May 2019 10:54:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAE751B948; Fri, 31 May 2019 10:54:15 +0200 (CEST) Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 2EAFA4F91 for ; Fri, 31 May 2019 10:54:13 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x4V8sCvx000690; Fri, 31 May 2019 17:54:12 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id C652EEA85FD; Fri, 31 May 2019 17:54:12 +0900 (JST) Received: from localhost.localdomain (lobster.nslab.ecl.ntt.co.jp [129.60.13.95]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id AE39EEA84F3; Fri, 31 May 2019 17:54:12 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Fri, 31 May 2019 17:51:35 +0900 Message-Id: <1559292699-26940-6-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559292699-26940-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> References: <1559292699-26940-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 5/9] spp_pcap: rename define of buffer size for cmds X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa For refactoring, rename SPP_CMD_NAME_BUFSZ and SPP_CMD_NAME_VALUE_BUFSZ to SPPWK_NAME_BUFSZ and SPPWK_VAL_BUFSZ to be more simple and specific. Signed-off-by: Yasufumi Ogawa --- src/pcap/cmd_parser.c | 2 +- src/pcap/cmd_parser.h | 8 ++++---- src/pcap/cmd_runner.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/pcap/cmd_parser.c b/src/pcap/cmd_parser.c index b91b39c..a5f3a4a 100644 --- a/src/pcap/cmd_parser.c +++ b/src/pcap/cmd_parser.c @@ -92,7 +92,7 @@ parse_command_in_list(struct spp_command_request *request, int i = 0; int argc = 0; char *argv[SPPWK_MAX_PARAMS]; - char tmp_str[SPPWK_MAX_PARAMS * SPP_CMD_VALUE_BUFSZ]; + char tmp_str[SPPWK_MAX_PARAMS * SPPWK_VAL_BUFSZ]; memset(argv, 0x00, sizeof(argv)); memset(tmp_str, 0x00, sizeof(tmp_str)); diff --git a/src/pcap/cmd_parser.h b/src/pcap/cmd_parser.h index 109b649..5945e62 100644 --- a/src/pcap/cmd_parser.h +++ b/src/pcap/cmd_parser.h @@ -21,10 +21,10 @@ #define SPPWK_MAX_PARAMS 8 /** command name string buffer size (include null char) */ -#define SPP_CMD_NAME_BUFSZ 32 +#define SPPWK_NAME_BUFSZ 32 /** command value string buffer size (include null char) */ -#define SPP_CMD_VALUE_BUFSZ 111 +#define SPPWK_VAL_BUFSZ 111 /** parse error code */ enum sppwk_parse_error_code { @@ -82,8 +82,8 @@ struct spp_command_request { /** parse error information */ struct spp_command_parse_error { int code; /**< Error code */ - char value_name[SPP_CMD_NAME_BUFSZ]; /**< Error value name */ - char value[SPP_CMD_VALUE_BUFSZ]; /**< Error value */ + char value_name[SPPWK_NAME_BUFSZ]; /**< Error value name */ + char value[SPPWK_VAL_BUFSZ]; /**< Error value */ }; /** diff --git a/src/pcap/cmd_runner.c b/src/pcap/cmd_runner.c index 0ce5d49..d5ae3a5 100644 --- a/src/pcap/cmd_runner.c +++ b/src/pcap/cmd_runner.c @@ -42,7 +42,7 @@ struct command_result { int code; /* Response message */ - char msg[SPP_CMD_NAME_BUFSZ]; + char msg[SPPWK_NAME_BUFSZ]; /* Detailed response message */ char error_message[CMD_RES_ERR_MSG_SIZE]; @@ -51,7 +51,7 @@ struct command_result { /* command response list control structure */ struct command_response_list { /* JSON Tag name */ - char tag_name[SPP_CMD_NAME_BUFSZ]; + char tag_name[SPPWK_NAME_BUFSZ]; /* Pointer to handling function */ int (*func)(const char *name, char **output, void *tmp); -- 2.17.1