From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C1D87A046B for ; Wed, 26 Jun 2019 07:36:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5931E4F98; Wed, 26 Jun 2019 07:36:07 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id BB8D74F98 for ; Wed, 26 Jun 2019 07:36:05 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id z19so617747pgl.12 for ; Tue, 25 Jun 2019 22:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=tLLKTsEWhohnpkhU+rkIdl6h5d7aAsmzqMR5BQ5T4gA=; b=ste2De7rl3OYib0hmg7qSB1tve23nXanJUr8TMHaSsDFaHRC3kCFDhi/h5cV3OJ2R+ b/D5rQ6XcZsvwvS35AN+r38Qbig8QJn82/sdhuPhjE6oAcv/quH42kK4tzXapctksD2w 0Pud5iZHM/J4HKUNacOntmsDmHuGGMCsTTOV0/jJnKpgolsbJ1GpqrY/6glhKRiTg/5T 8ANpyvjKqCNRjyY8uArqjKXXP2A+fYjUNvwS3+uKQwxCa4YIXs8xn7ugEPIqgpFnlyuR VvNNwb0onxUpVoTNiHOAtUqTq9MTBDIJP4qZBlf1piFhLb1/+mC9vIh0dHjAw+STKLq1 vszA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=tLLKTsEWhohnpkhU+rkIdl6h5d7aAsmzqMR5BQ5T4gA=; b=Juyaf/o+k11JyKd/4W/G53oe/MSZaeTdw/VM/hfmwphXx0VDR90TyukMzEMN00MOoF vpdPVmmdIQIh7tLEz0D7YM8i11Nm8QLkp8k8qxPEwLd1aakusthyutTPWpygkss4ORLf y3UXKrQXxBiVInxpnWlZIjqqdW81HXJDQh5WBdHBmw5FAM+9YAf0MNP8976UklgrBbEE UVOPQHiCaCfpSgImEK6/BUJeyvEw2hhVaT/Ta80C6zO0kEoOmR6tMg9nxcioTLRqrAXJ LbmwNq3txcc78tzS3uQsJ9PdHYDca6oKFZQPqt93ZRG3L71L6Hm8htj/3Lzn6yqG4dAi XuuQ== X-Gm-Message-State: APjAAAVc5sTpOi5o/g7lMgXwRP3TC0m4edibL+BgMLEpe2OVXXoXBqt3 89Fi4Qv9f1htIBPPnRReq0FvfJJM X-Google-Smtp-Source: APXvYqyIMDlcdT5hDOsowbp4plYKLSxzk+kD6p2zmjBtA/T1Ba9gsgUC5PE8Fpou7StLBRUrBAGJYA== X-Received: by 2002:a17:90a:2743:: with SMTP id o61mr2386066pje.59.1561527364955; Tue, 25 Jun 2019 22:36:04 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id u1sm15315180pgr.94.2019.06.25.22.36.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 22:36:04 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Wed, 26 Jun 2019 14:35:56 +0900 Message-Id: <20190626053558.39847-1-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [spp] [PATCH 0/2] Remove global g_startup_param X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa This series of patches is to remove global variable of command args `g_startup_param` because many of global variables are defined and strongly depended on each other. It makes hard to change codes. Instead of this global variable, each of args is retrieved with following functions. * get_client_id() * get_vhost_cli_mode() * get_spp_ctl_ip() * get_spp_ctl_port() Yasufumi Ogawa (2): shared/sec: remove global var g_startup_param spp_pcap: remove global var g_startup_param src/mirror/mir_cmd_runner.c | 12 ++++++------ src/mirror/spp_mirror.c | 14 ++++---------- src/pcap/cmd_runner.c | 8 +++----- src/pcap/cmd_utils.c | 13 +++---------- src/pcap/cmd_utils.h | 15 ++------------- src/pcap/spp_pcap.c | 15 +++------------ .../secondary/spp_worker_th/cmd_res_formatter.c | 3 +-- src/shared/secondary/spp_worker_th/cmd_runner.c | 4 ++-- src/shared/secondary/spp_worker_th/cmd_utils.c | 9 +-------- src/shared/secondary/spp_worker_th/cmd_utils.h | 14 ++------------ src/vf/spp_vf.c | 8 +------- src/vf/vf_cmd_runner.c | 12 ++++++------ 12 files changed, 34 insertions(+), 93 deletions(-) -- 2.17.1