From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44D5BA2EEB for ; Thu, 12 Sep 2019 12:48:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A5081E933; Thu, 12 Sep 2019 12:48:41 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by dpdk.org (Postfix) with ESMTP id 55A411E93A for ; Thu, 12 Sep 2019 12:48:40 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id j191so2739939pgd.3 for ; Thu, 12 Sep 2019 03:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=OXVMXpZJH8m3kQWrhOELv5ytw01GydTWBBokTg0LiVY=; b=pHewiEaZehIbn39o2SdUdUH6IYvDqRSpLXb3svG7dWIxQkjTNxOir9MGbzTpXzam4c JkoeGfyp6G3MIAl+0gSUpQt0awo19CqBJXVswzrLe2EWgo4vHvD5DjM88bPWQ00PgV+8 CMVpDCMxKk2vrlb7eEq5DYoeVjJekj42gd7tra7v1NOP9aj7UojJ6Wxz6vvSa6fgAX+H khkUPkT9RLgAWVl28BD+0cEmemwxaLIKxlhDKCqnHMTCs41CWVzKgV1CqUNXaaD7sZk5 JlxXWbM1I6uL1HN6XvC7Cj5VMCERwMfdNzpyFPVSEtUMxSD+NsgpvxyoRaFICcSY2Ye/ YN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=OXVMXpZJH8m3kQWrhOELv5ytw01GydTWBBokTg0LiVY=; b=aZdEHnzDcwSannABsrY3YfG+d2X8OhVmipMGFioCzLeK7wxOThPYsDr1l0CzbimDcT G74zliA5kXcWNc/IGjgNGyCfptcSU+EhNaychk+kgBt30PEZwsdzTwaPDZtEiKAWpfR2 NhTWk8VhNyWNKvpLTLFTRU3NIA+rNsb/qv/nAFF9dEce1xT7OFDHTArwLYWwjqFboKC7 hvICmKPb6qEGnLbCLN+8aIcRSza/vUM0HboQ/vWq4s7w5STeF7D8PcZOXi0LKqxVZS4b dhJe03T0gNG9KbsHQ2d4cI6mElkuFlaTnaImwJvi7t2MumP7rHTLI8jieE47i3LGn3m8 Lfrg== X-Gm-Message-State: APjAAAV2Dib+OuBJMmK7/XaMjn3jzfj2n1ODJrBCh/bn0I6gDaZ+/rBi gMUK41LGb39f+U5CRN5jXs5gXTvA X-Google-Smtp-Source: APXvYqwRUKCFxkS4w7iQISL8zKYwoaR/JDRUMPlSyRup4gAcx57R4SV4JQSiFK0fyIbT4QWdLYBvtQ== X-Received: by 2002:a17:90a:e013:: with SMTP id u19mr6632356pjy.104.1568285319542; Thu, 12 Sep 2019 03:48:39 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id t3sm26034930pfe.7.2019.09.12.03.48.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 03:48:39 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 12 Sep 2019 19:48:22 +0900 Message-Id: <20190912104824.21519-8-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190912104824.21519-1-yasufum.o@gmail.com> References: <20190912104824.21519-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 7/9] spp_mirror: revise util func for status command X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa As previous patch for spp_vf, this update is to rename it to iterate_lcore_info() and add comments as refactoring. Signed-off-by: Yasufumi Ogawa --- src/mirror/mir_cmd_runner.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/mirror/mir_cmd_runner.c b/src/mirror/mir_cmd_runner.c index 730d75f..fb1695f 100644 --- a/src/mirror/mir_cmd_runner.c +++ b/src/mirror/mir_cmd_runner.c @@ -294,9 +294,9 @@ exec_one_cmd(const struct sppwk_cmd_attrs *cmd) return ret; } -/* Iterate core information to create response to status command */ +/* Iterate core info to create response of spp_mirror status */ static int -spp_iterate_core_info(struct sppwk_lcore_params *params) +iterate_lcore_info(struct sppwk_lcore_params *params) { int ret; int lcore_id, cnt; @@ -310,16 +310,12 @@ spp_iterate_core_info(struct sppwk_lcore_params *params) core = get_core_info(lcore_id); if (core->num == 0) { - ret = (*params->lcore_proc)( - params, lcore_id, - "", SPPWK_TYPE_NONE_STR, - 0, NULL, 0, NULL); + ret = (*params->lcore_proc)(params, lcore_id, "", + SPPWK_TYPE_NONE_STR, 0, NULL, 0, NULL); if (unlikely(ret != 0)) { RTE_LOG(ERR, MIR_CMD_RUNNER, - "Cannot iterate core " - "information. " - "(core = %d, type = %d)\n", - lcore_id, SPPWK_TYPE_NONE); + "Failed to proc on lcore %d\n", + lcore_id); return SPPWK_RET_NG; } continue; @@ -334,9 +330,8 @@ spp_iterate_core_info(struct sppwk_lcore_params *params) if (unlikely(ret != 0)) { RTE_LOG(ERR, MIR_CMD_RUNNER, - "Cannot iterate core " - "information. " - "(core = %d, type = %d)\n", + "Failed to get on lcore %d ," + "type %d\n", lcore_id, comp_info->wk_type); return SPPWK_RET_NG; } @@ -365,7 +360,7 @@ add_core(const char *name, char **output, lcore_params.output = tmp_buff; lcore_params.lcore_proc = append_core_element_value; - ret = spp_iterate_core_info(&lcore_params); + ret = iterate_lcore_info(&lcore_params); if (unlikely(ret != SPPWK_RET_OK)) { spp_strbuf_free(lcore_params.output); return SPPWK_RET_NG; -- 2.17.1