From: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
To: Yasufumi Ogawa <yasufum.o@gmail.com>
Cc: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org
Subject: Re: [spp] [spp 04700] Re: [PATCH 0/2] support of RPM install on CentOS
Date: Thu, 19 Dec 2019 11:38:29 +0900 [thread overview]
Message-ID: <20191219113829.ACA2.17218CA3@ntt-tx.co.jp_1> (raw)
In-Reply-To: <040f1b8c-b143-9de2-ce04-c4886ac4fb1e@gmail.com>
Hi Yasufumi,
Please see inline.
> On 2019/12/18 11:00, Hideyuki Yamashita wrote:
> > Hi Yasufumi,
> >
> > You are correct.
> > Patch set is intened to update v18.08.4 branch not master.
> > I appologize to confuse.
> >
> > If I have to update patch set itself with reagrd to the targeting
> > version, please let me know.
> >
> > Thanks in advance.
> LGTM, but I have a question and a comment.
>
> What do you think to provide rpm for the latest SPP?
If I have a chance to test SPP on latest DPDK and if some updates needed
then I will request changes on master.
> > docs: add RPM installation for DPDK and SPP
> It is more appropriate to use another label instead of 'docs' because your spec file is not included in docs. I'd like to suggest you to use the name of directory 'rpmbuild' simply. If you agree, I'd change the label while applying the change.
No problem about your changing label on patchset (spec file).
Thanks!
BR,
HIdeyuki Yamashita
NTT TechnoCross
> Thanks,
> Yasufumi
> >
> > BR,
> > Hideyui Yamashita
> > NTT TechnoCross
> >
> >> Hi Hideyuki,
> >>
> >> I'm not sure the version of SPP because this update looks describing for v18.08.4 while the latest SPP is 19.08. Are you targeting not the master branch but v18.08.4 branch?
> >>
> >> Yasufumi
> >>
> >> On 2019/12/16 18:17, x-fn-spp@sl.ntt-tx.co.jp wrote:
> >>> From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> >>>
> >>> So far installation of SPP is done by making source code.
> >>> It is convenient for some users to install SPP using RPM.
> >>> This patch set provides spec file of SPP to generate RPM of SPP.
> >>> RST document is also updated to support this type of installation.
> >>>
> >>> Hideyuki Yamashita (2):
> >>> docs: add RPM installation for DPDK and SPP
> >>> docs: introduce RPM package support
> >>>
> >>> docs/guides/gsg/install.rst | 307 +++++++++++++++++++++++++++++++++++-
> >>> rpmbuild/SPECS/spp.spec | 222 ++++++++++++++++++++++++++
> >>> 2 files changed, 521 insertions(+), 8 deletions(-)
> >>> create mode 100644 rpmbuild/SPECS/spp.spec
> >>>
> >
> >
> >
next prev parent reply other threads:[~2019-12-19 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 9:17 [spp] " x-fn-spp
2019-12-17 6:44 ` Yasufumi Ogawa
2019-12-18 2:00 ` [spp] [spp 04694] " Hideyuki Yamashita
2019-12-18 8:12 ` Yasufumi Ogawa
2019-12-18 8:51 ` Yasufumi Ogawa
2019-12-19 2:38 ` Hideyuki Yamashita [this message]
2019-12-19 5:57 ` [spp] [spp 04700] " Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219113829.ACA2.17218CA3@ntt-tx.co.jp_1 \
--to=yamashita.hideyuki@ntt-tx.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
--cc=yasufum.o@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).