From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C54B6A04A5 for ; Tue, 16 Jun 2020 18:18:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 891A31BF8D; Tue, 16 Jun 2020 18:18:10 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3BC9C1BF8D for ; Tue, 16 Jun 2020 18:18:09 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id x207so9736256pfc.5 for ; Tue, 16 Jun 2020 09:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZR4PR2G5rTSCd70wTSegzY3iOJmzdKH+U6mPx2AID+c=; b=LkKnxBEg4YPwKh1Htsub5jk0jF+21Pn5gjkQdW9hEGF7Qfzttm/FdH0NjnZn7cG4pP fiu/1drWJtznsbh9zI7iSs0hoa9iw8C2Hh/nJyCyGmU7m82T+uWkznGj8FH/9usINJEp l0egt4Eo3AIz3q4zH5xzK601d/FEf3V1j0hAl2KDcjcuAWuFUH9NNoYpay0SztwObEvD Qex8B9VEJzOmpcF1pgsWcXPu552kEcFGE4ZQZSJ3aWQnbnxtLuVoLBcjCBWA6BuiWNEN yQE9vC+ucaNsIbfANfgHaTmPsh5i/x89NaK1OkDz/BMpBTYZBrGmckRQpWq1E/g0SsgN 23HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZR4PR2G5rTSCd70wTSegzY3iOJmzdKH+U6mPx2AID+c=; b=HZ3MiUuNL9Q+bVOydniZdch9wmNRj23nziMSvmrOQlY0u0DxFMj0oDKlahPNvR1HSG /RbkgvBeZq0gVAky6SCYAt6fGQbachwZkdle9AgOH5RmGz3o8DYJA+MFFB0E72n+8ZVU K/vcF0Sa/Y8+MJ4toUnpvweJvUV1HTLOccyom3VnAr86QaGJS24gnuZU6jWxy4zrxkJJ tNQ+haynnDJgBNvQRbWTnzci5wEU1u/3/uLcjeBdIYzUAlhU6N90pak9fnMjhaQIULPD AjNuh15gEVX2IDxuh3xHCAcaotgc8xffqCJnV2/EYl/AXE4ppDe8/ZtaXsfTkQLVK1R9 3qQA== X-Gm-Message-State: AOAM532sfSbwvp4n5qywjx2NA6JSA1YSByJeVUa/yZZY/kw2N0aQgxFc moNd45lYwhxbjQnFeSUUcUf/viOG51c= X-Google-Smtp-Source: ABdhPJytGY4e3OQFjw6gpTdYXIQlApJ1xOe5nkE/Ge8Z15E2FdxKOwsbwgUB7/0DUmFXAsYiPhNgVQ== X-Received: by 2002:a63:ea4a:: with SMTP id l10mr2782759pgk.222.1592324287950; Tue, 16 Jun 2020 09:18:07 -0700 (PDT) Received: from mugwort.local ([2400:4050:c8c2:de00:85da:78f9:3263:76fb]) by smtp.gmail.com with ESMTPSA id t206sm358648pgb.20.2020.06.16.09.18.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 09:18:07 -0700 (PDT) To: Hideyuki Yamashita Cc: x-fn-spp-ml@ntt-tx.co.jp, spp@dpdk.org References: <20200605002854.24054-6-x-fn-spp-ml@ntt-tx.co.jp> <20200616173006.B8F5.17218CA3@ntt-tx.co.jp_1> From: Yasufumi Ogawa Message-ID: <2de0e4ca-1452-8370-53c1-b9dbefc948b7@gmail.com> Date: Wed, 17 Jun 2020 01:18:05 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200616173006.B8F5.17218CA3@ntt-tx.co.jp_1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] (x-fn-spp-ml 783) Re: [PATCH 5/5] docs: add note regarding NUMA configuration X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" > Hi. > Sorry for delayed response. > Please see my comments inline. > >>> From: Hideyuki Yamashita >>> >>> This patch adds new notes for NUMA configuration when starting >>> spp_primary. >>> >>> This is pointed out by the following DPDK Bugzilla tickets. >>> https://bugs.dpdk.org/show_bug.cgi?id=457 >>> >>> Signed-off-by: Hideyuki Yamashita >>> Signed-off-by: Naoki Takada >>> --- >>> docs/guides/gsg/howto_use.rst | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/docs/guides/gsg/howto_use.rst b/docs/guides/gsg/howto_use.rst >>> index f182198..4f2e6cd 100644 >>> --- a/docs/guides/gsg/howto_use.rst >>> +++ b/docs/guides/gsg/howto_use.rst >>> @@ -422,6 +422,18 @@ if you run the process on single NUMA node. >>> If you use DPDK v18.11 or later, ``--base-virtaddr 0x100000000`` is enabled >>> in default. You need to use this option only for changing the default value. >>> > +.. note:: >>> + >>> + ``spp_primary`` tries to create memory pool in the same NUMA node where >>> + it is launched. Under NUMA configuration, the NUMA node where ``spp_primary`` >>> + is launched and the NUMA node where NIC is connected can be different >>> + (e.g. spp_primary runs in NUMA node 0 while NIC is connected with NUMA >>> + node 1). >>> + Such configuration may cause performance degradation. In general, under >>> + NUMA configuration, it is best practice to use CPU and NIC which belongs >>> + to the same NUMA node for best performance. So user should align those >>> + when performance degradation makes the situation critical. >>> + >> I have two comments. >> >> 1. Could I confirm WHAT should be configured for avoiding such a performance loss? > > NUMA node > - primary process will run (that can be specified with -l parameter) > - NIC belongs > should be the same to avoid performance loss. > > In general, topology regarding with NUMA node > (e.g. CPU core, NIC which is connected with specific NUMA node) > can be found in lstopo command. I would like to make it clear as an instruction for users. From my understanding, users should confirm that - Understand layout of hardware architecture of NICs and CPUs. - Assign lcores while launching spp_primary by considering the layout identified before. I understand your update for explanation is collect, but not so clear the purpose as instruction. I think it could be more agreeable if you start to explaining WHAT can be happened if you do not care about the layout (performance degradation actually), then HOW you get the layout by using `lstopo` and HOW you configure lcores by using `-l` option. Thanks, Yasufumi > > >> 2. It seems something abruptly considering context of this section because you start talking about performance suddenly. >> If it must be considered as a mandatory configuration and should be explained this section, I agree your update. >> On the other hand, what do you think to move this note to the next "Performance Optimization" section. >> I think no need to be a note if you move it to the next secion. > > I agree with your idea. > I think it is NOT mandatory, thus should be moved to next section > 'without' note. > >> >> Thanks >> >>> If ``spp_primary`` is launched with two or more lcores, forwarder or monitor >>> is activated. The default is forwarder and monitor is optional in this case. >>> If you use monitor thread, additional option ``--disp-stat`` is required. > >