From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D665A00BE for ; Mon, 8 Jun 2020 10:02:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 352701E35; Mon, 8 Jun 2020 10:02:27 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 9C7EA1E35 for ; Mon, 8 Jun 2020 10:02:26 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id i12so5417386pju.3 for ; Mon, 08 Jun 2020 01:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=54XEpk5snsUPJ1x9cUOM/gtm8envQaJ1DTucgE7t7Dk=; b=ppGItwibOGbsHCdD0WHR7g86DtTtPA3y/Oy4ENdw+cz7U4JOE0M/4dzZXnDaaRlQ37 3HNn1TVp2x56tL2s0TAW9v8RBd9izmOqZCcNqDggE+m5JT4gMWvMeDbLhPY/zK4GTQGr jEdGdLg9st9Q0XaEuUGq6Oj2ipXypl24fCzoy+5OHVYoOrYTYb2SmKrj/tyUTfLAWFP3 ZRxAXkyNex5i8rn/cO2kpjPeXFiEf4JshqBm2D6TIxDSgoj5MLTnbAwyXXxVrcOvHw9n cuv6M/QtQipGysjCihWWqccwkH7igkGFQzhrwNH/CGj//swj6rOKMtSN+oXhNSZMiiBl 9IFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=54XEpk5snsUPJ1x9cUOM/gtm8envQaJ1DTucgE7t7Dk=; b=BUZLur2eZlaYKWDSQUKXaEwvlcWaBTQcvtB6lvPHYQYYUUSsSB71ivkvNWYzxPA4Nb fGsmBLqm15ABX863VnmzFgjiBsWuszSB4ah83exbxEKnZ3WI7ZUpJimwNv1Ud6ltDkQz 9rfLhyGMwWcJ98jbF8E9hducJFzLcH36WRKVedlXqHxmY1PyBktSOCF6pnQqoyAb3ksi lJdlKCE1VZBQUBF82ENVhiLriaankcL3mcXoqwxl8S69xvtAfKZ1YeN66OiF9PL70bjJ HfJshlOEF9sXZcnZgttzeBR5nYi2xpoFXJSQNYS8mcjgeZxi9HJIvjGUPrW2/XQbPMSa fbYA== X-Gm-Message-State: AOAM530vGDetDrY40l9sqMtHw7UFKsytBz7x8ITuoZYluFcwBqiGnwoz EJRJDrqa6Zr5XB9eP5Gm/AZOKCeaeoY= X-Google-Smtp-Source: ABdhPJwOXvVFyeHtMQrrQ0jMEG6056P+K781ovjiJ35TM0bufKV8L7kwZvRqNIakRul2mrLTl7O2gg== X-Received: by 2002:a17:902:7783:: with SMTP id o3mr19471720pll.286.1591603345461; Mon, 08 Jun 2020 01:02:25 -0700 (PDT) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id q22sm6499075pfg.192.2020.06.08.01.02.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 01:02:24 -0700 (PDT) To: x-fn-spp-ml@ntt-tx.co.jp References: <20200605002854.24054-1-x-fn-spp-ml@ntt-tx.co.jp> <20200605002854.24054-4-x-fn-spp-ml@ntt-tx.co.jp> From: Yasufumi Ogawa Cc: spp@dpdk.org Message-ID: <41d3d83f-3908-6c60-796c-cfa5af41d6f0@gmail.com> Date: Mon, 8 Jun 2020 17:02:22 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200605002854.24054-4-x-fn-spp-ml@ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH 3/5] docs: catch up updates in dpdk-20.02 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Hi, Thanks for your update. I have three comments. > From: Hideyuki Yamashita > > This patch catch up the following updates in dpdk-20.02. > - new config to generate IGB_UIO module > - change supported target from x86_64-native-linuxapp-gcc to > x86_64_native-linux-gcc Plese take care about indenting. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > docs/guides/gsg/howto_use.rst | 20 ++++++++++---------- > docs/guides/gsg/install.rst | 9 ++++++--- > docs/guides/tools/sppc/app_launcher.rst | 2 +- > docs/guides/usecases/spp_mirror.rst | 10 +++++----- > docs/guides/usecases/spp_pcap.rst | 4 ++-- > docs/guides/usecases/spp_vf.rst | 8 ++++---- > 6 files changed, 28 insertions(+), 25 deletions(-) > [...] > diff --git a/docs/guides/gsg/install.rst b/docs/guides/gsg/install.rst > index 2abf330..f561f60 100644 > --- a/docs/guides/gsg/install.rst > +++ b/docs/guides/gsg/install.rst > @@ -119,8 +119,9 @@ Installing on Ubuntu and CentOS are almost the same, but required packages > are just bit different. > > PCAP is disabled by default in DPDK configuration. > -``CONFIG_RTE_LIBRTE_PMD_PCAP`` and ``CONFIG_RTE_PORT_PCAP`` defined in > -config file ``common_base`` should be changed to ``y`` to enable PCAP. > +``CONFIG_RTE_LIBRTE_PMD_PCAP``, ``CONFIG_RTE_PORT_PCAP`` and > +``CONFIG_RTE_EAL_IGB_UIO`` defined in config file ``common_base`` should be This sentence is to give a instruction for using PCAP, so should not include about IGB_UIO in the same sentence. Could you separate the sentence and add an explanation that igb_uio is no longer built as default? > +changed to ``y`` to enable PCAP. > > .. code-block:: console > > @@ -128,6 +129,8 @@ config file ``common_base`` should be changed to ``y`` to enable PCAP. > CONFIG_RTE_LIBRTE_PMD_PCAP=y > ... > CONFIG_RTE_PORT_PCAP=y > + ... > + CONFIG_RTE_EAL_IGB_UIO=y Please separate as similar to previous one. > > If you use MLX5 NIC, ``CONFIG_RTE_LIBRTE_MLX5_PMD`` defined in > config file ``common_base`` should be changed to ``y``. > @@ -143,7 +146,7 @@ Compile DPDK with target environment. > > $ cd dpdk > $ export RTE_SDK=$(pwd) > - $ export RTE_TARGET=x86_64-native-linuxapp-gcc # depends on your env > + $ export RTE_TARGET=x86_64-native-linux-gcc # depends on your env > $ make install T=$RTE_TARGET > > Pyhton > diff --git a/docs/guides/tools/sppc/app_launcher.rst b/docs/guides/tools/sppc/app_launcher.rst > index b368a15..40f40ca 100644 > --- a/docs/guides/tools/sppc/app_launcher.rst > +++ b/docs/guides/tools/sppc/app_launcher.rst > @@ -831,7 +831,7 @@ and three vhost interfaces. > sudo docker run \ > ... > sppc/pktgen-ubuntu:latest \ > - /root/dpdk/../pktgen-dpdk/app/x86_64-native-linuxapp-gcc/pktgen \ > + /root/dpdk/../pktgen-dpdk/app/x86_64-native-linux-gcc/pktgen \ > -l 8-14 \ > ... > -- \ > diff --git a/docs/guides/usecases/spp_mirror.rst b/docs/guides/usecases/spp_mirror.rst > index 4164a16..00d6eef 100644 > --- a/docs/guides/usecases/spp_mirror.rst > +++ b/docs/guides/usecases/spp_mirror.rst > @@ -70,7 +70,7 @@ three ports ``-p 0x07``. > .. code-block:: console > > # terminal 3 > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > -l 1 -n 4 \ > --socket-mem 512,512 \ > --huge-dir=/run/hugepages/kvm \ > @@ -87,7 +87,7 @@ Run secondary process ``spp_mirror``. > .. code-block:: console > > # terminal 4 > - $ sudo ./src/mirror/x86_64-native-linuxapp-gcc/app/spp_mirror \ > + $ sudo ./src/mirror/x86_64-native-linux-gcc/app/spp_mirror \ > -l 0,2 -n 4 \ > --proc-type secondary \ > -- \ > @@ -230,7 +230,7 @@ Start spp_primary with core list option ``-l 1``. > > # terminal 3 > # Type the following in different terminal > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > -l 1 -n 4 \ > --socket-mem 512,512 \ > --huge-dir=/run/hugepages/kvm \ > @@ -261,7 +261,7 @@ Launch ``VM1``, ``VM2`` and ``spp_vf`` with core list ``-l 0,2-8``. > .. code-block:: console > > # terminal 4 > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > -l 0,2-8 \ > -n 4 --proc-type secondary \ > -- \ > @@ -329,7 +329,7 @@ Run ``spp_mirror``. > .. code-block:: console > > # terminal 6 > - $ sudo ./src/mirror/x86_64-native-linuxapp-gcc/app/spp_mirror \ > + $ sudo ./src/mirror/x86_64-native-linux-gcc/app/spp_mirror \ > -l 0,9 \ > -n 4 --proc-type secondary \ > -- \ > diff --git a/docs/guides/usecases/spp_pcap.rst b/docs/guides/usecases/spp_pcap.rst > index 543538d..e94cfc4 100644 > --- a/docs/guides/usecases/spp_pcap.rst > +++ b/docs/guides/usecases/spp_pcap.rst > @@ -59,7 +59,7 @@ Then, run ``spp_primary`` with one physical port. > .. code-block:: console > > # terminal 3 > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > -l 0 -n 4 \ > --socket-mem 512,512 \ > --huge-dir /run/hugepages/kvm \ > @@ -79,7 +79,7 @@ writer threads. > .. code-block:: console > > # terminal 4 > - $ sudo ./src/pcap/x86_64-native-linuxapp-gcc/spp_pcap \ > + $ sudo ./src/pcap/x86_64-native-linux-gcc/spp_pcap \ > -l 1-6 -n 4 --proc-type=secondary \ > -- \ > --client-id 1 -s 192.168.1.100:6666 \ > diff --git a/docs/guides/usecases/spp_vf.rst b/docs/guides/usecases/spp_vf.rst > index c45feb8..6056636 100644 > --- a/docs/guides/usecases/spp_vf.rst > +++ b/docs/guides/usecases/spp_vf.rst > @@ -52,7 +52,7 @@ Launch ``spp-ctl`` and SPP CLI before primary and secondary processes. > .. code-block:: console > > # terminal 3 > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > -l 1 -n 4 \ > --socket-mem 512,512 \ > --huge-dir=/run/hugepages/kvm \ > @@ -68,7 +68,7 @@ worker threads. > .. code-block:: console > > # terminal 4 > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > -l 2-6 \ > -n 4 --proc-type=secondary \ > -- \ > @@ -281,7 +281,7 @@ Launch ``spp-ctl`` and SPP CLI before primary and secondary processes. > .. code-block:: console > > # terminal 3 > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > -l 1 -n 4 \ > --socket-mem 512,512 \ > --huge-dir=/run/hugepages/kvm \ > @@ -295,7 +295,7 @@ to use twelve lcores. > .. code-block:: console > > # terminal 4 > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > -l 0,2-13 \ > -n 4 --proc-type=secondary \ > -- \ >