From: Yasufumi Ogawa <geminoa@juno.ocn.ne.jp>
To: x-fn-spp@sl.ntt-tx.co.jp
Cc: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org
Subject: Re: [spp] [PATCH v2 1/6] shared: add dev_attach_by_devargs
Date: Sat, 24 Nov 2018 23:54:33 +0900 [thread overview]
Message-ID: <6eb5d6a7-af80-1158-f395-c95207634c70@juno.ocn.ne.jp> (raw)
In-Reply-To: <201811210652.wAL6qKJe011052@imss04.silk.ntt-tx.co.jp>
> SPP uses deprecated APIs removed in DPDK v18.11. Using rte_eth_hotplug_add()
> is recommended instead of rte_eth_dev_attach()[1]. This patch is to add
> dev_attach_by_devargs() to shared directory so that spp_primary, spp_nfv,
> spp_vm and spp_vf can refer this new function.
Hideyuki,
The number of characters per line should be less than 72. It exceeds the
limitation in 1st and 3rd lines.
Thanks
>
> [1]https://mails.dpdk.org/archives/dev/2018-October/117115.html
>
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
> src/shared/common.c | 26 ++++++++++++++++++++++++++
> src/shared/common.h | 17 +++++++++++++++++
> 2 files changed, 43 insertions(+)
>
> diff --git a/src/shared/common.c b/src/shared/common.c
> index f1754db..c88ce14 100644
> --- a/src/shared/common.c
> +++ b/src/shared/common.c
> @@ -500,3 +500,29 @@ append_patch_info_json(char *str,
>
> return 0;
> }
> +
> +/* attach the new device, then store port_id of the device */
> +int
> +dev_attach_by_devargs(const char *devargs, uint16_t *port_id)
> +{
> + int ret = -1;
> + struct rte_devargs da;
> +
> + memset(&da, 0, sizeof(da));
> +
> + /* parse devargs */
> + if (rte_devargs_parse(&da, devargs))
> + return -1;
> +
> + ret = rte_eal_hotplug_add(da.bus->name, da.name, da.args);
> + if (ret < 0) {
> + free(da.args);
> + return ret;
> + }
> +
> + ret = rte_eth_dev_get_port_by_name(da.name, port_id);
> +
> + free(da.args);
> +
> + return ret;
> +}
> diff --git a/src/shared/common.h b/src/shared/common.h
> index a5395aa..60514e5 100644
> --- a/src/shared/common.h
> +++ b/src/shared/common.h
> @@ -18,7 +18,9 @@
> #include <rte_common.h>
> #include <rte_config.h>
> #include <rte_eal.h>
> +#include <rte_devargs.h>
> #include <rte_ethdev.h>
> +#include <rte_ethdev_driver.h>
> #include <rte_launch.h>
> #include <rte_lcore.h>
> #include <rte_log.h>
> @@ -217,4 +219,19 @@ int spp_atoi(const char *str, int *val);
>
> #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1
>
> +/**
> + * Attach a new Ethernet device specified by arguments.
> + *
> + * @param devargs
> + * A pointer to a strings array describing the new device
> + * to be attached. The strings should be a pci address like
> + * '0000:01:00.0' or virtual device name like 'net_pcap0'.
> + * @param port_id
> + * A pointer to a port identifier actually attached.
> + * @return
> + * 0 on success and port_id is filled, negative on error
> + */
> +int
> +dev_attach_by_devargs(const char *devargs, uint16_t *port_id);
> +
> #endif
>
next prev parent reply other threads:[~2018-11-24 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 5:07 [spp] [PATCH 0/6] Replace deprecated APIs x-fn-spp
2018-11-09 3:34 ` Yasufumi Ogawa
2018-11-09 9:22 ` [spp] [spp 03539] " Hideyuki Yamashita
2018-11-12 11:15 ` Yasufumi Ogawa
2018-11-13 0:27 ` Hideyuki Yamashita
2018-11-13 8:22 ` Yasufumi Ogawa
2018-11-14 0:40 ` Hideyuki Yamashita
2018-11-15 0:16 ` Nakamura Hioryuki
2018-11-15 14:17 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 " x-fn-spp
2018-11-24 12:57 ` Yasufumi Ogawa
2018-11-28 2:44 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 1/6] shared: add dev_attach_by_devargs x-fn-spp
2018-11-24 14:54 ` Yasufumi Ogawa [this message]
2018-11-26 4:12 ` [spp] [spp 03664] " Hideyuki Yamashita
2018-11-21 6:52 ` [spp] [PATCH v2 2/6] spp_nfv: replace deprecated rte_eth_dev_attach x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 3/6] spp_vf: " x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 4/6] shared: add dev_detach_by_port_id x-fn-spp
2018-11-24 15:02 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 5/6] spp_nfv: replace deprecated rte_eth_dev_detach x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 6/6] spp_vm: " x-fn-spp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb5d6a7-af80-1158-f395-c95207634c70@juno.ocn.ne.jp \
--to=geminoa@juno.ocn.ne.jp \
--cc=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).