From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B332A0524 for ; Wed, 29 Jan 2020 03:17:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59B9C1D146; Wed, 29 Jan 2020 03:17:46 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id F0AD21D146 for ; Wed, 29 Jan 2020 03:17:44 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id i23so7655416pfo.2 for ; Tue, 28 Jan 2020 18:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qz9zCwGFrjp9KJXwfYba3u5aUefQdkSwvhOAXRWK0As=; b=Pnk8a0LNx+6yNyghKLARY6Z8+G11vhZGhW8+HfERFmNNbCQSInpK72dhOyACOD0E19 sDMqzcWKstXKyNq5NofutRl/YE6SVfm/yvDtAzx/lVtT+hZORjdWuOmurBBFbn701/jZ QwbHcE+i2oiK7Irv9rsMgotgJNu1IFStQKUJa1VaoH6woGxDDPnpLY+fG6aNKHiS2BGr agjBFchRYYpSKb3lujlhRwe2/2NVYG217KSGSKIgvjAcOr/gwMz4Fj6uzzwwmo+8c6iE P1OCx7YG32/pnz0Fkj5sdgsUnrRyRgwvoNr7a+hoALZ7LeCxrmrhwNl2TSvh6lQDu1Wy b5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qz9zCwGFrjp9KJXwfYba3u5aUefQdkSwvhOAXRWK0As=; b=Ed5JvuhP2e0Wz1K+Wd4adUhewKbMwEab0I33srd9/eoHhblE522v0qe17VpEgTdlk+ 6bndPU5dU42S/q3Sopu+WDpKzpS8Y1hTXHztDds88byqGQbzLfxtifEX+eBWbTwrvpAn pGUc7nLQy/wyaQv55Bapeexc/Oy60IFAifODc7ZDrpPmonRqqVHl68fgM1dcH3aINC0a m87v8kQq6pLDexKdR1BG+YQ4omVDGQKXSDH0Eqmrqy7cOD8blqZnf5aJn96whHbEekaO vaTfRr42TaZ8BoRV0GH+xDX362W9fRUdDGDx6jlDnVT7jadkrcZpB0l9Q6EmFoHPW0eo dK3w== X-Gm-Message-State: APjAAAVIBXgI5Z9HCvskakk8jl5kW+jrAKgND2bj9Wdwhpoqkk4s7sM8 /GqYpHr347sKDpYPCutv4Zzsr/ds X-Google-Smtp-Source: APXvYqwhGF5wXl1D/mafWDNfZjY/3h1R7lRK9KvwQBhYKqlIkVQSkBgA4glzPYV+zWSlenEPqF3k6w== X-Received: by 2002:aa7:94b0:: with SMTP id a16mr6966128pfl.35.1580264264017; Tue, 28 Jan 2020 18:17:44 -0800 (PST) Received: from [172.30.202.27] ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id m15sm345559pgi.91.2020.01.28.18.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 18:17:43 -0800 (PST) To: Itsuro Oda References: <20200128235251.23813-1-oda@valinux.co.jp> <20200128235251.23813-2-oda@valinux.co.jp> Cc: spp@dpdk.org, ferruh.yigit@intel.com From: Yasufumi Ogawa Message-ID: <7f7e98c2-32b9-7b08-9125-e4b66ac83a43@gmail.com> Date: Wed, 29 Jan 2020 11:18:29 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200128235251.23813-2-oda@valinux.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH 1/1] spp_primary: enable use of eth_vhost X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" On 2020/01/29 8:52, Itsuro Oda wrote: > This patch enables spp_primary to use eth_vhost by --vdev option. It's LGTM. Although tag of title should be 'shared', I'd like to correct it. Applied, thanks! > > Fixes: 5094c9b88cf9 (shared: switch to use vhost PMD for SPP) > Signed-off-by: Itsuro Oda > --- > src/shared/common.c | 4 +++- > src/shared/common.h | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/shared/common.c b/src/shared/common.c > index 5fdb29f..d878c5a 100644 > --- a/src/shared/common.c > +++ b/src/shared/common.c > @@ -91,7 +91,9 @@ int parse_dev_name(char *dev_name, int *port_type, int *port_id) > } else if (strncmp(dev_name, VDEV_ETH_VHOST, > strlen(VDEV_ETH_VHOST)) == 0 || > strncmp(dev_name, VDEV_NET_VHOST, > - strlen(VDEV_NET_VHOST)) == 0) { > + strlen(VDEV_NET_VHOST)) == 0 || > + strncmp(dev_name, VDEV_SPP_VHOST, > + strlen(VDEV_SPP_VHOST)) == 0) { > dev_str_len = strlen(VDEV_NET_VHOST); > pid_len = dev_name_len - dev_str_len; > strncpy(pid_str, dev_name + strlen(VDEV_NET_VHOST), > diff --git a/src/shared/common.h b/src/shared/common.h > index adabb79..b4af73c 100644 > --- a/src/shared/common.h > +++ b/src/shared/common.h > @@ -34,8 +34,9 @@ > > #define VDEV_ETH_RING "eth_ring" > #define VDEV_NET_RING "net_ring" > -#define VDEV_ETH_VHOST "spp_vhost" > +#define VDEV_ETH_VHOST "eth_vhost" > #define VDEV_NET_VHOST "net_vhost" > +#define VDEV_SPP_VHOST "spp_vhost" > #define VDEV_NET_PCAP "net_pcap" > #define VDEV_ETH_TAP "eth_tap" > #define VDEV_NET_TAP "net_tap" >