From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 6D30529C6 for ; Wed, 21 Nov 2018 06:46:02 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wAL5k11K012154; Wed, 21 Nov 2018 14:46:01 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id E9637638C2F; Wed, 21 Nov 2018 14:46:00 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id D2448638B31; Wed, 21 Nov 2018 14:46:00 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id C10A4400870; Wed, 21 Nov 2018 14:46:00 +0900 (JST) References: <201811210135.wAL1ZxN9009578@imss03.silk.ntt-tx.co.jp> <201811210516.wAL5GWXN024298@ccmail04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <804b8840-a66b-5e28-6fb6-8c00941390b6@lab.ntt.co.jp> Date: Wed, 21 Nov 2018 14:43:38 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201811210516.wAL5GWXN024298@ccmail04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Hideyuki Yamashita Cc: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [spp 03641] Re: [PATCH 00/23] move some codes of spp_vf into vf/common X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 05:46:03 -0000 > Hello Yasufumi-san, > > Thanks for your asking. > Please see inline. >>> Some spp_vf codes can be used by new secondary process which >>> is extended from spp_vf. This patch set move such codes into >>> spp_vf/common. >> Hi Hideyuki, >> >> I would like to confirm about your changes. New secondary process you mentioned is spp_mirror which is posted as the next series of patches, right? > Yes. > >> Do you have a plan to implement secondary extended from spp_vf other >> than spp_mirror? > Yes. I have a plan to implement secondary extended from spp_vf other > than spp_mirror. I think it is required to common directory for secondary processes. SPP has common directory named `shared`, but functions and defines in this directory are not well considered as common actually. We will need to re-organize them by thinking usages, for instance, which of function is used from secondaries, or both of primary and secondaries. I would like to re-organize them in future patches. It is OK to share `spp_vf/common` among secondaries extended from spp_vf until this re-organization is done. Thanks, Yasufumi > > BR, > Hideyuki Yamashita > NTT TechnoCross > >> Thanks, >> Yasufumi >>> >>> Hideyuki Yamashita (23): >>> spp_vf: fix invalid code for max chars >>> spp_vf: move common source and header files >>> spp_vf: change include path >>> spp_vf: update Makefile for common files >>> spp_vf: move functions to common directory >>> spp_vf: move defines to common dir >>> spp_vf: move functions for decode to common dir >>> spp_vf: move defines for decode to common dir >>> spp_vf: move functions to command_proc.c >>> spp_vf: add management data registration >>> spp_vf: change reference of management data >>> spp_vf: change return values to explain result >>> spp_vf: define terms of commands as consts >>> spp_vf: remove unnecessary includes >>> spp_vf: add include header files >>> spp_vf: update comments for header file >>> spp_vf: update makefile of spp_vf >>> spp_vf: add check num of ports before forwarding >>> spp_vf: add flag for classifier table >>> spp_vf: add checking the number of ports >>> spp_vf: add vlantag command check flag >>> spp_vf: simplify changing VLAN tag >>> spp_vf: add SPP_VF_MODULE preprocessor directive >>> >>> src/vf/Makefile | 7 +- >>> src/vf/classifier_mac.c | 139 ++- >>> src/vf/classifier_mac.h | 20 +- >>> src/vf/{ => common}/command_conn.c | 23 +- >>> src/vf/{ => common}/command_conn.h | 16 +- >>> src/vf/{ => common}/command_dec.c | 641 +++++++--- >>> src/vf/{ => common}/command_dec.h | 21 +- >>> src/vf/{ => common}/command_proc.c | 716 +++++++++-- >>> src/vf/{ => common}/command_proc.h | 10 +- >>> src/vf/{ => common}/ringlatencystats.c | 15 +- >>> src/vf/{ => common}/ringlatencystats.h | 4 +- >>> src/vf/{ => common}/spp_port.c | 34 +- >>> src/vf/{ => common}/spp_port.h | 2 +- >>> src/vf/common/spp_proc.c | 1029 ++++++++++++++++ >>> src/vf/common/spp_proc.h | 727 +++++++++++ >>> src/vf/{ => common}/string_buffer.c | 3 +- >>> src/vf/{ => common}/string_buffer.h | 0 >>> src/vf/spp_forward.c | 47 +- >>> src/vf/spp_forward.h | 12 +- >>> src/vf/spp_vf.c | 1574 +----------------------- >>> src/vf/spp_vf.h | 511 -------- >>> 21 files changed, 3074 insertions(+), 2477 deletions(-) >>> rename src/vf/{ => common}/command_conn.c (90%) >>> rename src/vf/{ => common}/command_conn.h (82%) >>> rename src/vf/{ => common}/command_dec.c (53%) >>> rename src/vf/{ => common}/command_dec.h (90%) >>> rename src/vf/{ => common}/command_proc.c (63%) >>> rename src/vf/{ => common}/command_proc.h (80%) >>> rename src/vf/{ => common}/ringlatencystats.c (92%) >>> rename src/vf/{ => common}/ringlatencystats.h (97%) >>> rename src/vf/{ => common}/spp_port.c (94%) >>> rename src/vf/{ => common}/spp_port.h (99%) >>> create mode 100644 src/vf/common/spp_proc.c >>> create mode 100644 src/vf/common/spp_proc.h >>> rename src/vf/{ => common}/string_buffer.c (97%) >>> rename src/vf/{ => common}/string_buffer.h (100%) >>>