Soft Patch Panel
 help / color / mirror / Atom feed
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: oda@valinux.co.jp
Cc: spp@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [spp] [PATCH 0/2] spp_mirror API support
Date: Thu, 29 Nov 2018 10:36:21 +0900	[thread overview]
Message-ID: <a1cfcd95-1cdb-028b-9d47-2a5ea6ed1f87@lab.ntt.co.jp> (raw)
In-Reply-To: <20181129005512.18526-1-oda@valinux.co.jp>

> As new process spp_mirror is introduced, spp-ctl supports
> its API.
Hi Itsuro,

Thank you for your update quickly. Your patches are looks good, but titles of commit messages are inappropriate.

Could you revise them for v2 patches as following if you agree?
     spp-ctl: add spp_mirror API support
     docs: add spp_mirror API api-reference

Thanks,
Yasufumi
> 
> Itsuro Oda (2):
>    spp_mirror API support
>    spp_mirror API api-reference
> 
>   docs/guides/spp-ctl/api-reference.rst | 316 ++++++++++++++++++++++++++
>   src/spp-ctl/spp_ctl.py                |   2 +-
>   src/spp-ctl/spp_proc.py               |  57 +++--
>   src/spp-ctl/spp_webapi.py             | 120 +++++++---
>   4 files changed, 443 insertions(+), 52 deletions(-)

  parent reply	other threads:[~2018-11-29  1:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  0:55 oda
2018-11-29  0:55 ` [spp] [PATCH 1/2] " oda
2018-11-29  0:55 ` [spp] [PATCH 2/2] spp_mirror API api-reference oda
2018-11-29  1:36 ` Yasufumi Ogawa [this message]
2018-11-29  2:04 ` [spp] [PATCH v2 0/2] spp_mirror API support oda
2018-11-29  2:04   ` [spp] [PATCH v2 1/2] spp-ctl: add " oda
2018-11-29  2:04   ` [spp] [PATCH v2 2/2] docs: add spp_mirror API api-reference oda
2018-11-29 10:01   ` [spp] [PATCH v2 0/2] spp_mirror API support Yasufumi Ogawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1cfcd95-1cdb-028b-9d47-2a5ea6ed1f87@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=oda@valinux.co.jp \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).