From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 70D8E1D7 for ; Mon, 12 Nov 2018 12:15:28 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id v18-v6so8865337wrt.8 for ; Mon, 12 Nov 2018 03:15:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=HntVYppx+z5dC+LXAJC6pf5pAchFl13zmcHNsuYC3vc=; b=VWLTHGnv1vdcVi4kvjVU7I2ukMcbMNHqiYMqxslIaMPvR+OQVwdtaZaPxrIqxEnue3 y1mZCC+xDeUzvR7TKEnta2bWaVTrw5JiQx/qT3mJIr/nx+SroOIyeiUDw9KSOw3NwkGN H7uqDhoLNd9SWcC4XvTnfA0ZZYWZezGopXjuYnXoQvkHNC+9yHRlsW/QQ8ZQUkNJnT68 1JpWq9BmUZAe0t8wgYwYgY9zMh0+yZ1vaZLJu8rnf4NPP6Cs0p2epPHnMznuqhZ4A8nq 83ZK/RyUQEpbQXWIem5etclFav5Rg2JsmVKKGwt8ZJQqOTcaWPIz8EEPaS0gPxhpdXCt 5m+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=HntVYppx+z5dC+LXAJC6pf5pAchFl13zmcHNsuYC3vc=; b=pw7ZrQAnkRjoFwXi5RWiLxqYzR/+0SMHrCemkGQl6HLxx+3c6gyAXZH+7LhKmDXYoD mjMxPchLrSly9uIMEG//tWX2LAXdz7b6FCARgG/QwA9HSBAWVq22zU4isXCOyhNSqaxA lrt1d+X3xnZqxsT85pZoUogqZaTVrdX5t1KxDNSMqtUxrsC64KDUlsjEUQhlCaQpuAaM fx/Xjg72ispz6Tv+ylQHhyLsB/T5v6mykBMix2oGhuphRSm6TcIIR4RPG31QGyIPD9yR /VsFJevxzfqpPEOFRt6zGmNHLEHWSXH+QrCdbV3Lf9wFJt9xGE6wWhyZUD/ysriDBRCx dthg== X-Gm-Message-State: AGRZ1gLRnj1VTT7YnMKydEOx8wLqf73AlgbdBKQEHhHJXQaRWMiZaJB5 45PxBzmXP3IBNvVZCLNMXZzeviLFKCI= X-Google-Smtp-Source: AJdET5drdh1lxd8U/NtzeFvaAhVfnd8vZaf4j4xGHBEQ4U35XmA0nTZSvLxRjgJxlLgA/H74ZILhVA== X-Received: by 2002:adf:dd89:: with SMTP id x9-v6mr587333wrl.246.1542021327866; Mon, 12 Nov 2018 03:15:27 -0800 (PST) Received: from mugwort.local ([88.128.80.83]) by smtp.gmail.com with ESMTPSA id o126-v6sm6988735wmo.3.2018.11.12.03.15.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 03:15:27 -0800 (PST) To: Hideyuki Yamashita Cc: Yasufumi Ogawa , x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org References: <201811070507.wA757WWo008866@imss03.silk.ntt-tx.co.jp> <201811090923.wA99MvqZ016850@ccmail04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Mon, 12 Nov 2018 20:15:02 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201811090923.wA99MvqZ016850@ccmail04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [spp] [spp 03539] Re: [PATCH 0/6] Replace deprecated APIs X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 11:15:28 -0000 > Hello Yasufumi-san, > > Thanks so much for your comments. > > About your first point, I think the follwing naming may be fit with DPDK > and SPP naming conventions, what do you think? > > attach -> spp_eth_dev_attach > detach -> spp_eth_dev_detach I think you should not use prefix `spp` without if it defines a behaviour of SPP itself. This function is more essential to attach device. For `spp_eth_dev_attach`, You might think similar name from original `rte_eth_dev_attach`, but I think we do not keep the name of deprecated APIs. More simply, how about `dev_attach_by_devargs` instead of? For `spp_eth_dev_detach`, I think `dev_detach_by_port_id` is more prefer. Other than the name of the function, I am curious why it takes second argument `name` because it is not used in the function. By the way, I am not clear what is the difference between your functions and `rte_eth_dev_attach` defined in `dpdk/lib/librte_ethdev/rte_ethdev.c` exactly. Could you explain about the difference shortly for helping my understanding? Thanks > About your second point, I appologize about my mistake. > > Once I get ack for above new naming of two interfaces from you, > I will revise my patch set including cover-letter and will send > those to mailing list. > > Thanks for your co-opearation! > > BR, > Hideyuki Yamashita > NTT TechnoCorss > >> On 2018/11/07 14:07, x-fn-spp@sl.ntt-tx.co.jp wrote: >>> From: Hideyuki Yamashita >>> >>> >From DPDK-18.08, the follwing APIs become deprecated and >>> will be deleted in DPDK18.08. >>> - rte_eth_dev_attach() >>> - rte_eth_dev_detach() >>> >>> For rte_eth_dev_attach(), use of rte_eal_hotplug_add() is recommended. >>> For rte_eth_dev_detach(), use of rte_eal_hotplug_remove() is recommended. >>> >>> To follow the above changes, this patch set provides replacement of >>> those APIs. >> Hideyuki, >> >> Thank you for suggesting to update to v18.08! >> >> Could you re-consider the name of function you added by referring conventions of DPDK and SPP? It has almost no means if just `attach` or `detach`. It is preferable to be self explanatory for how your function works. >> >> Commit messages are also required to be revised. Update for the change of function name and modify invalid descriptions for documentation guidelines. >> >> Thanks >>> Signed-off-by: Hideyuki Yamashita >>> Signed-off-by: Naoki Takada >>> >>> Hideyuki Yamashita (6): >>> shared: addition of attach() >>> spp_nfv: replacement of rte_eth_dev_attach() >>> spp_vf:replacement of rte_eth_dev_attach() >>> shared: addition of detach() >>> spp_nfv: replacement of rte_eth_dev_detach() >>> spp_vm: replacement of rte_eth_dev_detach(). >>> >>> src/nfv/nfv.c | 12 ++++----- >>> src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ >>> src/shared/common.h | 32 +++++++++++++++++++++++ >>> src/vf/spp_vf.c | 4 +-- >>> src/vm/main.c | 2 +- >>> 5 files changed, 105 insertions(+), 9 deletions(-) >>> >> >>