From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ogawa.yasufumi@lab.ntt.co.jp>
Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148])
 by dpdk.org (Postfix) with ESMTP id 3884911A4
 for <spp@dpdk.org>; Tue, 12 Mar 2019 06:04:22 +0100 (CET)
Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])
 by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x2C54LcZ030748;
 Tue, 12 Mar 2019 14:04:21 +0900
Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])
 by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 6588E638951;
 Tue, 12 Mar 2019 14:04:21 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
 by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 5A5EC638879;
 Tue, 12 Mar 2019 14:04:21 +0900 (JST)
Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73])
 by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 565004007AB;
 Tue, 12 Mar 2019 14:04:21 +0900 (JST)
References: <201902200944.x1K9iGN9015616@ccmail03.silk.ntt-tx.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Message-ID: <d7ffe5b2-f438-6ea3-8c65-bab6338c61d3@lab.ntt.co.jp>
Date: Tue, 12 Mar 2019 14:02:00 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <201902200944.x1K9iGN9015616@ccmail03.silk.ntt-tx.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CC-Mail-RelayStamp: 1
To: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Cc: spp@dpdk.org
X-TM-AS-MML: disable
Subject: Re: [spp] 3 bugs for spp_pcap
X-BeenThere: spp@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Soft Patch Panel <spp.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/spp>,
 <mailto:spp-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/spp/>
List-Post: <mailto:spp@dpdk.org>
List-Help: <mailto:spp-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/spp>,
 <mailto:spp-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Mar 2019 05:04:23 -0000

Hi Hideyuki,

Is there any reason you do not link liblz4.a with `-l` option? In the Makefile[1], althoogh you add this library to `SRCS-y`, I 
do not think it is better to use `-l`. What do you think?

[1] http://git.dpdk.org/apps/spp/tree/src/pcap/Makefile

Thanks,
Yasufumi

> Hi,
> 
> I found the following bugs for spp_pcap.
> 
> 1. Some packets can not be captured after pcap start.
> 
> 2. Packet drop happens when receiving 64 byte short packet on 10Gbps
> wire rate.
> 
> 3. On receiving pcap stop command, packets are not flushed to files.
> So when repeat capturing without shutdown of spp_pcap,
> old packets are included in the capture file.
> 
> I will fix those bugs and report patches to this ML.
> 
> Sorry for inconvenience.
> 
> BR,
> Hideyuki Yamashita
> NTT TechnoCross
>