From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3627941C96 for ; Tue, 14 Feb 2023 17:05:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F236A42FB4; Tue, 14 Feb 2023 17:05:54 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 38D90410EF; Tue, 14 Feb 2023 17:05:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676390752; x=1707926752; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=4G5vJ6VKW7Idrc6kfIeUEXkMisKUsqVQ5zLVH09n324=; b=blQNjJ8Gx1APLE39Hku5/SsGOcp3AHjidclGffbnbCbx+Q7BWhNWn3NF HR2sriHP6MQzyIq0F0EAYmLmk452e1WuhORJ4WTc4qAaPPW0QLCLaGzrk vd7cduU3keWoNrrphrWHjvh7qQwSNp+qzkpMGsqFfIhrS6MDa7eiIOvrV 2aXVf2pq4JszBg+lrjkmzNlVMagsCm3Z9V+XtUXIy0IJjIgD2Iwqf9UHt OsVN48cKagTsiBPgfXzgOo+pZYjzXF/FH2P2O/OenvGOuiKdNkkoC37yr Y2JULEGwUQNFhE1rylsrHEDOPot7pya1dVxNeHKOg7h4ONLxqbT0F53E2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="319224136" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="319224136" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 08:04:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="662580403" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="662580403" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 14 Feb 2023 08:04:33 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 14 Feb 2023 08:04:33 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f7l9iUNwaEet1aY+qLbNYIjihqZco9UBZdznurmTApMEssOWW3XbvTnsYrgVimhFtx9dnsMKc7oVq7XWjwm7WnGvLvxDw9IxQ7H51qPZ0B08Q1RPlPhv4hL/Lfq2iv7+m96+2iW6DauR2G/h9+cb4QsI9yLsJk9URhc4Po+lZX7I3v7jVXf3Ox5cIUZk7cYudg+TNeRVarxrZqWZvoPe3IzpyHgVwfZbIzeZ1ufHiBZ2AGqBV/1QQyPfFcEs6Oj6jY9IAsM7pIFI2kjzmPMMdKUomb2wutbCoQn2pX09zF8peK6uiZOs+RDhu6xs+MjGLUoFczvfrkL8M+dpZrEZng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4S9mGeQVNdK6vgjxCVLDV0jm8Z5kBypN7nflclKAbxs=; b=aLjVxw5onEtefGLuIAYC8qiAwOjbXqmpvrloyFVjj5XWUdXALGiWd5HTbP28rTPAzXbeC1OEEp8J4HTg5LGqqdBop9jMekotDoHd2D4t6hEfdVLb2PEYw9XwJ3NtIrvqRzUqNFh9lq7fkNTtqNGOUlAMTwd+GAQBZXVBf1XadyWVcV+nJdgXdoba8cW8TvKJvZYGBiqsnWkqf3hN03/AbLMGrwWizJmCXBJd4R/xRrsi1yxIuHp22niTGarF2m+F2M/ml/9ZLibqDZ2CILi9wtGg4eFtCBbI5P6vOy86sTFm4DmgRyVLsVOMToPZX8QgDXGoFmSxxRLXt3M+/S2LDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH3PR11MB7894.namprd11.prod.outlook.com (2603:10b6:610:12c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:04:31 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d%9]) with mapi id 15.20.6086.023; Tue, 14 Feb 2023 16:04:30 +0000 Message-ID: <0022a696-2308-91c6-9798-ced81d18a64e@intel.com> Date: Tue, 14 Feb 2023 16:04:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/6] dma/ioat: fix incorrectly set indexes after restart Content-Language: en-US To: Bruce Richardson , CC: , References: <20230116153714.554470-1-bruce.richardson@intel.com> <20230116173738.562322-1-bruce.richardson@intel.com> <20230116173738.562322-3-bruce.richardson@intel.com> From: Kevin Laatz In-Reply-To: <20230116173738.562322-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0228.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::17) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|CH3PR11MB7894:EE_ X-MS-Office365-Filtering-Correlation-Id: 0110f764-d782-4180-6ce9-08db0ea527a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sznYinGmT4TWNimP+PHNXrpI6fhX4lwmNl2ogZTK2uR7WBRuqkEbIAMDTploUu7RKvmIeAtin4opInC2P5CNWdqtW4Dy58DZ4Sr3b1KTEp/lHFxUTaPp1PSwDCpZcyjxoyd7ytNy9hUkHi1vGEOKwhF+PWJsPE9oUoQqw1aCHSTx5k2PoBeNWJ89YoSbfp0T+TLfBOfT0KlNMX2zHL4y2Vg3TXokh0AFF1AmbvGR7QT5dn9Rks+45ZSo35Ca9/IQ4ah4GALakp+nRnnssM6wdEiKFZTca1mEhcFo/MSK5oIzuAXOf1fHO9gkeb0fFj8PjFd57JahL7lF9d4T54R8RojgcwZTlV/ynplb+xDJ50om/kHPU8Pp57p/Xw+7n34Pk1fSs3b//W7cIZeE/zVpEhy1lF/25R8MV9xVBkeGXMHQsBFGyA5NIIxSdre6xzcFE7v73j3oNR25Urz8jduDi5m5Sh6mw/PgHjZygkxWWDLRIoSbc61uuezO/4Ly/lhocAotsLX/gTWIsflhAfffrVKKsGaxJPmkjglT5DW6+lCn42zyLJUpXc2lkTF3lND0gmfc6RWLK/7XXhmmXbhHSAH1bixg7lkWUiU1ftzISm2SqZAHYiibMxTBuPf+GgZmNe5TtDdXlKH1zJgJRMn6FgaGo7ZG3CmU44crdpS5GSIcUgd8TzVFwt7xMoEg+VbJvO166II00MSvyoUazG54WbQ4kbq2sS1fhq9S4zmYzVk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199018)(38100700002)(53546011)(44832011)(8936002)(5660300002)(31686004)(82960400001)(4744005)(41300700001)(186003)(26005)(6506007)(6512007)(6666004)(66946007)(66556008)(8676002)(66476007)(450100002)(478600001)(31696002)(4326008)(86362001)(2906002)(2616005)(316002)(6486002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHcvNzJXSVRLd1hzN0JNUUhSTXUrOTUvdGZhWnBSS3JKcXpNWnpaazdLbTYv?= =?utf-8?B?K20vMkdWRy85d2lMWFJQdHA0VnJZTFRxU0E1M3dIeHU1SnlSZkZ2MW0yV0xL?= =?utf-8?B?UUYxcmJzMVFTd3JjRE9VT2xWYnJYVDhHdXhDdVo4UWhvV00rM3E1bDVuT0R6?= =?utf-8?B?RktGK1kyZ2NRelpRQldCQnFMMHVhWCtQY3FUdWRsNHdIZmFZa3R2djhqeFh3?= =?utf-8?B?U0tzR1V3YW9uVnAydmppUUZ1KzBIVTAzMy83VFcybEkrdElVNFBDSm1ubnFJ?= =?utf-8?B?dnVLTmlqNW1BcHNPZjNNSTBpc1oyTUZ4V3doblNjZXhpeExveDE0VGwzME1t?= =?utf-8?B?RjU0dmNyR2xocDYwN2FFajVjMzRnL0JtbDA5WDFwbm9GbjhOS3k3ZFgrRmJK?= =?utf-8?B?YmIvbmRpTzVEVVp2Y2FYdytuWVFKemxsVGg1M0k1OXBFYXBUTklyQTV1N1pP?= =?utf-8?B?ZElubFc5ZnA2NlBWWGpZNGdPZEd1TjVzN2VRVWptOXdsZUZNTHlRZi9wUWMw?= =?utf-8?B?Q0NQZHdPWG9iMjN0dWRubUhiZUFQbEprZmM4UHN2NERqTkIvS0VTdC9uSC8v?= =?utf-8?B?dTFodWxyUHRzNkZIY3JuWWw1dDR2YWdYQ0JJU3RueFI0K3dYTGdFZkpJTDAx?= =?utf-8?B?UmJTdmtjMytrS0svQWhBd0VBc29PYTdNaHAzejUrc2FDZi9vV3RxMFYyL2hl?= =?utf-8?B?OTZOcHN4azF3VHhsVmcxaGdOVW5FRzVxYjRVZUxxem1XZk0vZ21rc1JlSm1t?= =?utf-8?B?bTE1RnRjNWRyTWlmVTdBVkhJVXV6eFRLV2YyWGlQWkdWby9ySGxoZndMOGtj?= =?utf-8?B?bWVZN01IWkhpRU5vYmRHWEx5UUx3eG53QjBBM3RCdlNGaEdvOEFyR2VLOVNU?= =?utf-8?B?Qk5pRTNXTGhCRmFvNlN6TzZtczZKbExRVUQvY2NiOE9hVHpSWHdVWlJaSmlw?= =?utf-8?B?b0ozMU1NaXlOYXJTZHFmMmVVL1lmbXFaZXBES2hQUHRlTW5NNGs4VHdtSWVu?= =?utf-8?B?aWgzYzkrYVFnbkQ5NDJXcTJiV2tTdytrWmtWTTREekdQbm1mN25va2pMNEww?= =?utf-8?B?MDMwc3MvNmlreC9mbWI5RGFlcnBQZ251ZDVzTndxaXVlLzNDZWFhL3hDTzlh?= =?utf-8?B?OWtDSEYwY0F5T01UQ2Z2MkdWSVFodjFQUVlUVDdPMXBUNXRKL1BEOUxEQ09z?= =?utf-8?B?SEh4aDlRNTNRaHlUQm9JekZYMHFGVCtBeW1VYS82bEw2MTRBQ0pXSXRtdHkv?= =?utf-8?B?V3c3SDVDVjR6Vnc2ak5TdWU3TS9hMUhiRDFNUWNLRzZad1NNTERBYTZzdmMv?= =?utf-8?B?YnkxSWtFRmtzYndIK28wcktOYmd3dmhNbHpsWVlvWXRRRWp3MzdnWDUwak95?= =?utf-8?B?bmR2UTIxU3NRZko3cUJGRlFhNkgzWUpXRUhNY0VZcDgvdmFPdnZmK1VVdW4w?= =?utf-8?B?TWtHcWk5bG5hejdna0VmbHdsTWsyVDRZRG9Uc1BmYzc1ckJqNHJ2WERMeFVC?= =?utf-8?B?TWtady80RXVFNnNaUXhQRlVBVkpWV2dJUWdlMGNtYlJCSG90bmsvUXVQVmxw?= =?utf-8?B?a0VpbGFLTGVSMzh1NWNjalh2dmFZdGlMNEh1VEJGYmxaUzBpa2JRL05jeW9m?= =?utf-8?B?TUg4dXFNZ1lVM0hoQmhlWWsyeUZINi9nNFRVTUJWdHlEYi9FYzFnelVzVnpw?= =?utf-8?B?Y3VhRjdpMGRvQllhZ3A5NkdRc2gxVGgvcHlEWGdoRHVPa3JnSUczdmVIYXoz?= =?utf-8?B?RktEV01GSWRGOW9ucE4yM0IybFUrUExzdkVIcTRJQWJlU2dCQWFpUjJBc2Ev?= =?utf-8?B?NW9wb1N2TzcvdGlkRmJrWjNHQi9ZR245cHB5SGxRRzhKK21ZTmFrQm5CWnVT?= =?utf-8?B?L2FnVEYyTDZVaUF1ZFl2RXhhV0lHRUR3RzRhZFpqbVV2enpFSzBwL1pvWm5Q?= =?utf-8?B?V2dQeWI0SVdzeHNRejB1dHNyL1p3bUFXZ1VuUDI1bWtzeHpUN0RtamxzVGxj?= =?utf-8?B?SW8va0pydUNvZkIyOEFabWVFN2pWRUpZdkNSMmRTUW9WbWIwRXpJU1d3d2pM?= =?utf-8?B?YVFOck1LTS9sNmZUTFk5N0JFNXlwTjYwbU05clBQTm0yYnc4cTRYeXJZWXlX?= =?utf-8?B?enR2L1B3RktZOGFaM29DMUo1UEV6S0NYbXpGeDBDMEM4OWVIN0lwSXd1Znl1?= =?utf-8?B?S2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0110f764-d782-4180-6ce9-08db0ea527a5 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:04:30.5587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ug5nm6ycOm2+8WlyCM5ew7SDJTkZG/DQKOnPtigJYzuYmJ9i56084do6yWGbMMXSwyyO7MH7KQq0G9GVuGep4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7894 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 16/01/2023 17:37, Bruce Richardson wrote: > As part of the process of restarting a dma instance, the IOAT driver > will reset the HW addresses and state values. The read and write > indexes for SW use need to be similarly reset to keep HW and SW in > sync. > > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.walsh@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > drivers/dma/ioat/ioat_dmadev.c | 7 +++++++ > 1 file changed, 7 insertions(+) Acked-by: Kevin Laatz