From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F39AA0093 for ; Thu, 23 Jun 2022 15:58:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FC8140042; Thu, 23 Jun 2022 15:58:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 44CBE40042 for ; Thu, 23 Jun 2022 15:58:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655992732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MKEzNQizSSu7E2OkUUbxT7K0VEhvECRT4kGaKaeueGM=; b=LAnkz59/WiEMtz6FtDt+B2+B3upPxzXB1prpk5UR5i4/EAq85QMFhXXQmknHV4loRNHWqq 7uD6SLEJ6IDRKtf/8T/xl7wMsFkruX7UMoB4jBfjeHVmJ77jVJ6nQ78oL9geLkuP68zng7 Vk2Dj5u8Zkg8fJmlw20EVp6u5/PpEcg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-609L1P43MwCSbIevT1fO2w-1; Thu, 23 Jun 2022 09:58:46 -0400 X-MC-Unique: 609L1P43MwCSbIevT1fO2w-1 Received: by mail-wm1-f70.google.com with SMTP id j31-20020a05600c1c1f00b0039c481c4664so7004402wms.7 for ; Thu, 23 Jun 2022 06:58:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=MKEzNQizSSu7E2OkUUbxT7K0VEhvECRT4kGaKaeueGM=; b=VgG09zQubusGoKGXKxU4RsVoKkyMHFZYnJT3p9Yffc5Td1E1AZSe/VUAVn7r3XPBub yl9K0P82Eu7a/1+pQYbgnm/CNnhp4RaXSEV9cw/teummBd3Gq/bGtSYBvQYyhhdfjtcN fn8H1LijnrI3ruK+zWKXad7hW7JEkAL0derKW3zO8J+id6wk4knioPHj5Atn+iuhCIrN VdOnTAs/8oN/2IXsHrw3eF1OcB9YmODWgaupAst37YVkYdFdncxkXB09cbSq0PfApW1s rz+WBNDxZ3TYvaKBMkKp8IpIH9qFWYAEAObKfRsq3dbdA15O4EzEdlSv8Urjnk+zypHD 8CCQ== X-Gm-Message-State: AJIora8GWtGLM3FS4/ePxiI8KOey2d691PjUnVWRVhI5qfO/C1f3cQWa juLJeagi0ytzWUMemPiY7vRo1iuDHs20wHb3ULORiddTMk5NtE1rjDSgIgJgbkceiV6KK2g1m0i e9UK+Vxw= X-Received: by 2002:a5d:584e:0:b0:218:511f:c8ea with SMTP id i14-20020a5d584e000000b00218511fc8eamr8457749wrf.664.1655992724951; Thu, 23 Jun 2022 06:58:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v2r4rJFsn0Dy0y9V9nXLs0z3WfAyiLLWo9uxMcuxv/dnBDIidxaczhku1P0dLbR8GZ2/1QVQ== X-Received: by 2002:a5d:584e:0:b0:218:511f:c8ea with SMTP id i14-20020a5d584e000000b00218511fc8eamr8457734wrf.664.1655992724788; Thu, 23 Jun 2022 06:58:44 -0700 (PDT) Received: from [192.168.0.36] ([78.17.181.1]) by smtp.gmail.com with ESMTPSA id p10-20020a5d48ca000000b002102f2fac37sm22839017wrs.51.2022.06.23.06.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 06:58:43 -0700 (PDT) Message-ID: <006b50c9-c897-abc5-1e6a-6f4389c1f356@redhat.com> Date: Thu, 23 Jun 2022 14:58:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Yiding Zhou , stable@dpdk.org Cc: Qi Zhang References: <20220622044125.133057-1-yidingx.zhou@intel.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/iavf: fix segfaults when calling API after VF reset failed In-Reply-To: <20220622044125.133057-1-yidingx.zhou@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 22/06/2022 05:41, Yiding Zhou wrote: > [ upstream commit 676d986b4b86ac6441b99cc1c89126640bd7e187 ] > > Some pointers will be set to NULL when iavf_dev_reset() failed, > for example vf->vf_res, vf->vsi_res vf->rss_key and etc. > APIs access these NULL pointers will trigger segfault. > > This patch adds closed flag to indicate that the VF is closed, > and rejects API calls in this state to avoid coredump. > > Fixes: e74e1bb6280d ("net/iavf: enable port reset") > > Signed-off-by: Yiding Zhou > Acked-by: Qi Zhang Thanks, applied.