patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Wang, ShougangX" <shougangx.wang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"Cao, Yahui" <yahui.cao@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/ice: fix memory release in FDIR
Date: Tue, 5 Nov 2019 06:10:49 +0000
Message-ID: <00A8E5A1740DFA49A87AFFAC34B8EDEA3BB834@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013CE80E82@SHSMSX101.ccr.corp.intel.com>

Hi, Beilei

> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, November 5, 2019 1:09 PM
> To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix memory release in FDIR
> 
> 
> 
> > -----Original Message-----
> > From: Wang, ShougangX
> > Sent: Tuesday, November 5, 2019 4:44 AM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Cao, Yahui <yahui.cao@intel.com>; Wang,
> > ShougangX <shougangx.wang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ice: fix memory release in FDIR
> >
> > To avoid wild pointer and memory leak, following resources management
> > should be added.
> > - Check if the FDIR Memzone already exists before reserving.
> > - Free FDIR memzone when teardown and other failure scenarios.
> > - Set pointers to NULL after free them.
> > - Release all counter resources when teardown.
> 
> Thanks for the patch, but could you split the patch according to different issues?
> 
> Beilei

OK, I will split them in next version.

Thanks.
Shougang

      reply	other threads:[~2019-11-05  6:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 20:43 Wang ShougangX
2019-11-05  5:09 ` Xing, Beilei
2019-11-05  6:10   ` Wang, ShougangX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00A8E5A1740DFA49A87AFFAC34B8EDEA3BB834@SHSMSX101.ccr.corp.intel.com \
    --to=shougangx.wang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=yahui.cao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git