[PATCH v3] app/testpmd: add help messages for multi-process

[PATCH v3] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..44698046b4 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,8 @@ usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs: the number of processes which will be used\n");
+	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "
-- 
2.33.0

Re: [PATCH v3] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..44698046b4 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the number of processes which will be used\n");
> +	printf("  --proc-id  : the id of the current process (id < num-procs)\n");

Hi Connor,

For people new to dpdk/test-pmd, it may be hard to figure out these two
parameter is related to multi-process support. What do you think updating
the description to clarify these are for multi-process support?

>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "

Re: [PATCH v3] app/testpmd: add help messages for multi-process

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

On Thu, Mar 3, 2022 at 4:09 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
> > From: Huisong Li <lihuisong@huawei.com>
> >
> > This patch adds help messages for multi-process.
> >
> > Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>
> > ---
> > v3,v2:
> > * adjust the position of parameters.
> > ---
> >   app/test-pmd/parameters.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index daf6a31b2b..44698046b4 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -61,6 +61,8 @@ usage(char* progname)
> >              "extended statistics to show. Used with --stats-period "
> >              "specified or interactive commands that show Rx/Tx statistics "
> >              "(i.e. 'show port stats').\n");
> > +     printf("  --num-procs: the number of processes which will be used\n");
> > +     printf("  --proc-id  : the id of the current process (id < num-procs)\n");
>
> Hi Connor,
>
> For people new to dpdk/test-pmd, it may be hard to figure out these two
> parameter is related to multi-process support. What do you think updating
> the description to clarify these are for multi-process support?
+1 not just for this but in general.
Group them and add a comment.
Or add that in the help text.

>
> >       printf("  --nb-cores=N: set the number of forwarding cores "
> >              "(1 <= N <= %d).\n", nb_lcores);
> >       printf("  --nb-ports=N: set the number of forwarding ports "
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

[PATCH] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 5251722d0f..6cc7afe15a 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -211,6 +211,8 @@ usage(char* progname)
 	printf("  --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
 	       "    0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
 	       "    0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
+	printf("  --num-procs: the number of processes which will be used\n");
+	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
 }
 
 #ifdef RTE_LIB_CMDLINE
-- 
2.33.0

Re: [PATCH] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Sorry, this patch should be abandoned.

在 2022/3/4 9:22, Min Hu (Connor) 写道:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
>   app/test-pmd/parameters.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 5251722d0f..6cc7afe15a 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -211,6 +211,8 @@ usage(char* progname)
>   	printf("  --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
>   	       "    0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
>   	       "    0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
> +	printf("  --num-procs: the number of processes which will be used\n");
> +	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
>   }
>   
>   #ifdef RTE_LIB_CMDLINE
> 

[PATCH v4] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs <N>, where N is the total number of symmetric_mp instances
that will be run side-by-side to perform packet processing. This parameter
is used to configure the appropriate number of receive queues on each
network port.

--proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
of processes, specified above). This identifies which symmetric_mp instance
is being run, so that each process can read a unique receive queue on each
network port.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v4:
* update description for parameters.
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..908e8a15f5 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,8 @@ usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");
+	printf("  --proc-id  : the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "
-- 
2.33.0

Re: [PATCH v3] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Hi, Ferruh,
	V4 has been sent to fix it, thanks.

在 2022/3/3 20:09, Ferruh Yigit 写道:
> On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..44698046b4 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,8 @@ usage(char* progname)
>>              "extended statistics to show. Used with --stats-period "
>>              "specified or interactive commands that show Rx/Tx 
>> statistics "
>>              "(i.e. 'show port stats').\n");
>> +    printf("  --num-procs: the number of processes which will be 
>> used\n");
>> +    printf("  --proc-id  : the id of the current process (id < 
>> num-procs)\n");
> 
> Hi Connor,
> 
> For people new to dpdk/test-pmd, it may be hard to figure out these two
> parameter is related to multi-process support. What do you think updating
> the description to clarify these are for multi-process support?
> 
>>       printf("  --nb-cores=N: set the number of forwarding cores "
>>              "(1 <= N <= %d).\n", nb_lcores);
>>       printf("  --nb-ports=N: set the number of forwarding ports "
> 
> .

RE: [PATCH v4] app/testpmd: add help messages for multi-process

[Zhang, Yuying]

Hi Connor,

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, March 4, 2022 9:28 AM
> To: dev@dpdk.org
> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
> Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH v4] app/testpmd: add help messages for multi-process
> 
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances that
> will be run side-by-side to perform packet processing. This parameter is used to
> configure the appropriate number of receive queues on each network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> processes, specified above). This identifies which symmetric_mp instance is
> being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>  app/test-pmd/parameters.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> daf6a31b2b..908e8a15f5 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>  	       "extended statistics to show. Used with --stats-period "
>  	       "specified or interactive commands that show Rx/Tx statistics "
>  	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances that
> will be run side-by-side\n");
> +	printf("  --proc-id  : the id of the current process (id < num-procs)
> +to identify which symmetric_mp instance is being run\n");

Could you delete the space before colon?

>  	printf("  --nb-cores=N: set the number of forwarding cores "
>  	       "(1 <= N <= %d).\n", nb_lcores);
>  	printf("  --nb-ports=N: set the number of forwarding ports "
> --
> 2.33.0

[PATCH v5] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs <N>, where N is the total number of symmetric_mp instances
that will be run side-by-side to perform packet processing. This parameter
is used to configure the appropriate number of receive queues on each
network port.

--proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
of processes, specified above). This identifies which symmetric_mp instance
is being run, so that each process can read a unique receive queue on each
network port.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v5:
* delete space
v4:
* update description for parameters.
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..6c4253ae61 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,8 @@ usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");
+	printf("  --proc-id: the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "
-- 
2.33.0

Re: [PATCH v4] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Hi,

在 2022/3/4 10:50, Zhang, Yuying 写道:
> Hi Connor,
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Friday, March 4, 2022 9:28 AM
>> To: dev@dpdk.org
>> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
>> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
>> Deep <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
>> Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH v4] app/testpmd: add help messages for multi-process
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs <N>, where N is the total number of symmetric_mp instances that
>> will be run side-by-side to perform packet processing. This parameter is used to
>> configure the appropriate number of receive queues on each network port.
>>
>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>> processes, specified above). This identifies which symmetric_mp instance is
>> being run, so that each process can read a unique receive queue on each
>> network port.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> v4:
>> * update description for parameters.
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>> daf6a31b2b..908e8a15f5 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,8 @@ usage(char* progname)
>>   	       "extended statistics to show. Used with --stats-period "
>>   	       "specified or interactive commands that show Rx/Tx statistics "
>>   	       "(i.e. 'show port stats').\n");
>> +	printf("  --num-procs: the total number of symmetric_mp instances that
>> will be run side-by-side\n");
>> +	printf("  --proc-id  : the id of the current process (id < num-procs)
>> +to identify which symmetric_mp instance is being run\n");
> 
> Could you delete the space before colon?
already delete the space in v5, thanks.
> 
>>   	printf("  --nb-cores=N: set the number of forwarding cores "
>>   	       "(1 <= N <= %d).\n", nb_lcores);
>>   	printf("  --nb-ports=N: set the number of forwarding ports "
>> --
>> 2.33.0
> 
> .
> 

RE: [PATCH v5] app/testpmd: add help messages for multi-process

[Zhang, Yuying]

Hi Minhu,

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, March 4, 2022 2:27 PM
> To: dev@dpdk.org
> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: [PATCH v5] app/testpmd: add help messages for multi-process
> 
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances
> that will be run side-by-side to perform packet processing. This parameter is
> used to configure the appropriate number of receive queues on each
> network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> processes, specified above). This identifies which symmetric_mp instance is
> being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Acked-by: Yuying Zhang <yuying.zhang@intel.com>

> ---
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>  app/test-pmd/parameters.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> daf6a31b2b..6c4253ae61 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>  	       "extended statistics to show. Used with --stats-period "
>  	       "specified or interactive commands that show Rx/Tx statistics "
>  	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances
> that will be run side-by-side\n");
> +	printf("  --proc-id: the id of the current process (id < num-procs) to
> +identify which symmetric_mp instance is being run\n");
>  	printf("  --nb-cores=N: set the number of forwarding cores "
>  	       "(1 <= N <= %d).\n", nb_lcores);
>  	printf("  --nb-ports=N: set the number of forwarding ports "
> --
> 2.33.0

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 3/4/2022 6:26 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances
> that will be run side-by-side to perform packet processing. This parameter
> is used to configure the appropriate number of receive queues on each
> network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
> of processes, specified above). This identifies which symmetric_mp instance
> is being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..6c4253ae61 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");

I am not exactly sure what is 'symmetric' in 'symmetric_mp' here,
there is a sample application with this name but I guess 'symmetric'
is related to that sample functionality.

Would you mind if I change 'symmetric_mp' with 'multi-process'
while applying?

> +	printf("  --proc-id: the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
> Hi Minhu,
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Friday, March 4, 2022 2:27 PM
>> To: dev@dpdk.org
>> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
>> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
>> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
>> <yuying.zhang@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>
>> Subject: [PATCH v5] app/testpmd: add help messages for multi-process
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs <N>, where N is the total number of symmetric_mp instances
>> that will be run side-by-side to perform packet processing. This parameter is
>> used to configure the appropriate number of receive queues on each
>> network port.
>>
>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>> processes, specified above). This identifies which symmetric_mp instance is
>> being run, so that each process can read a unique receive queue on each
>> network port.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
> 

Updated 'symmetric_mp' -> 'multi-process', with this change
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Thomas Monjalon]

04/03/2022 16:35, Ferruh Yigit:
> On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
> > From: Min Hu (Connor) <humin29@huawei.com>
> >> From: Huisong Li <lihuisong@huawei.com>
> >>
> >> This patch adds help messages for multi-process.
> >> --num-procs <N>, where N is the total number of symmetric_mp instances
> >> that will be run side-by-side to perform packet processing. This parameter is
> >> used to configure the appropriate number of receive queues on each
> >> network port.
> >>
> >> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> >> processes, specified above). This identifies which symmetric_mp instance is
> >> being run, so that each process can read a unique receive queue on each
> >> network port.
> >>
> >> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> > 
> > Acked-by: Yuying Zhang <yuying.zhang@intel.com>
> > 
> 
> Updated 'symmetric_mp' -> 'multi-process', with this change
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied to dpdk-next-net/main, thanks.

Why not reusing these defines?

#define PARAM_PROC_ID "proc-id"
#define PARAM_NUM_PROCS "num-procs"

Why not having "N" in the help messages like others?

I won't pull it in main.
Please rework and try to improve the description to make it shorter
and easier to understand.

[PATCH v5] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs=N: set the total number of multi-process instances
--proc-id=id:  set the id of the current process from multi-process
instances(0 <= id < num-procs)

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v6:
* fix comments.
v5:
* delete space
v4:
* update description for parameters.
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..2834e9e180 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,9 @@ usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs=N: set the total number of multi-process instances\n");
+	printf("  --proc-id=id:  set the id of the current process from multi-process instances\n"
+	       "(0 <= id < num-procs).\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "
-- 
2.33.0

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Hi, Thomas,
	v6 has been sent, thanks.

在 2022/3/7 6:52, Thomas Monjalon 写道:
> 04/03/2022 16:35, Ferruh Yigit:
>> On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
>>> From: Min Hu (Connor) <humin29@huawei.com>
>>>> From: Huisong Li <lihuisong@huawei.com>
>>>>
>>>> This patch adds help messages for multi-process.
>>>> --num-procs <N>, where N is the total number of symmetric_mp instances
>>>> that will be run side-by-side to perform packet processing. This parameter is
>>>> used to configure the appropriate number of receive queues on each
>>>> network port.
>>>>
>>>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>>>> processes, specified above). This identifies which symmetric_mp instance is
>>>> being run, so that each process can read a unique receive queue on each
>>>> network port.
>>>>
>>>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
>>>
>>
>> Updated 'symmetric_mp' -> 'multi-process', with this change
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Applied to dpdk-next-net/main, thanks.
> 
> Why not reusing these defines?
> 
> #define PARAM_PROC_ID "proc-id"
> #define PARAM_NUM_PROCS "num-procs"
> 
> Why not having "N" in the help messages like others?
> 
> I won't pull it in main.
> Please rework and try to improve the description to make it shorter
> and easier to understand.
> 
> 
> .
> 

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Hi, Ferruh,
	what do you think of this patch?

在 2022/3/7 9:04, Min Hu (Connor) 写道:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs=N: set the total number of multi-process instances
> --proc-id=id:  set the id of the current process from multi-process
> instances(0 <= id < num-procs)
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v6:
> * fix comments.
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..2834e9e180 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,9 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs=N: set the total number of multi-process instances\n");
> +	printf("  --proc-id=id:  set the id of the current process from multi-process instances\n"
> +	       "(0 <= id < num-procs).\n");
>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "
> 

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Min Hu (Connor)]

Hi, all,
    any comments?

在 2022/3/7 9:04, Min Hu (Connor) 写道:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs=N: set the total number of multi-process instances
> --proc-id=id:  set the id of the current process from multi-process
> instances(0 <= id < num-procs)
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v6:
> * fix comments.
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..2834e9e180 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,9 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs=N: set the total number of multi-process instances\n");
> +	printf("  --proc-id=id:  set the id of the current process from multi-process instances\n"
> +	       "(0 <= id < num-procs).\n");
>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "
> 

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 6/2/2022 3:24 AM, Min Hu (Connor) wrote:
> Hi, all,
>     any comments?
> 
> 在 2022/3/7 9:04, Min Hu (Connor) 写道:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs=N: set the total number of multi-process instances
>> --proc-id=id:  set the id of the current process from multi-process
>> instances(0 <= id < num-procs)
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> v6:
>> * fix comments.
>> v5:
>> * delete space
>> v4:
>> * update description for parameters.
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..2834e9e180 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,9 @@ usage(char* progname)
>>              "extended statistics to show. Used with --stats-period "
>>              "specified or interactive commands that show Rx/Tx 
>> statistics "
>>              "(i.e. 'show port stats').\n");
>> +    printf("  --num-procs=N: set the total number of multi-process 
>> instances\n");
>> +    printf("  --proc-id=id:  set the id of the current process from 
>> multi-process instances\n"
>> +           "(0 <= id < num-procs).\n");
>>       printf("  --nb-cores=N: set the number of forwarding cores "
>>              "(1 <= N <= %d).\n", nb_lcores);
>>       printf("  --nb-ports=N: set the number of forwarding ports "
>>

Hi Connor,

output is as following [1], is "(0 <= id < num-procs)." part break into 
next line intentionally? This breaks the output.

I assume the line is broken in source code to fit into line length, but 
it doesn't have to break the line in output, what do you think?


[1]
...
   --num-procs=N: set the total number of multi-process instances
   --proc-id=id:  set the id of the current process from multi-process ..
(0 <= id < num-procs).
   --nb-cores=N: set the number of forwarding cores (1 <= N <= 55).
...

Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Dongdong Liu]

Hi Ferruh

Many thanks for your review.
On 2022/6/3 7:08, Ferruh Yigit wrote:
> On 6/2/2022 3:24 AM, Min Hu (Connor) wrote:
>> Hi, all,
>>     any comments?
>>
>> 在 2022/3/7 9:04, Min Hu (Connor) 写道:
>>> From: Huisong Li <lihuisong@huawei.com>
>>>
>>> This patch adds help messages for multi-process.
>>> --num-procs=N: set the total number of multi-process instances
>>> --proc-id=id:  set the id of the current process from multi-process
>>> instances(0 <= id < num-procs)
>>>
>>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>> ---
>>> v6:
>>> * fix comments.
>>> v5:
>>> * delete space
>>> v4:
>>> * update description for parameters.
>>> v3,v2:
>>> * adjust the position of parameters.
>>> ---
>>>   app/test-pmd/parameters.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>>> index daf6a31b2b..2834e9e180 100644
>>> --- a/app/test-pmd/parameters.c
>>> +++ b/app/test-pmd/parameters.c
>>> @@ -61,6 +61,9 @@ usage(char* progname)
>>>              "extended statistics to show. Used with --stats-period "
>>>              "specified or interactive commands that show Rx/Tx
>>> statistics "
>>>              "(i.e. 'show port stats').\n");
>>> +    printf("  --num-procs=N: set the total number of multi-process
>>> instances\n");
>>> +    printf("  --proc-id=id:  set the id of the current process from
>>> multi-process instances\n"
>>> +           "(0 <= id < num-procs).\n");
>>>       printf("  --nb-cores=N: set the number of forwarding cores "
>>>              "(1 <= N <= %d).\n", nb_lcores);
>>>       printf("  --nb-ports=N: set the number of forwarding ports "
>>>
>
> Hi Connor,
>
> output is as following [1], is "(0 <= id < num-procs)." part break into
> next line intentionally? This breaks the output.
>
> I assume the line is broken in source code to fit into line length, but
> it doesn't have to break the line in output, what do you think?
Thanks for pointing this, will fix.

Thanks,
Dongdong
>
>
> [1]
> ...
>   --num-procs=N: set the total number of multi-process instances
>   --proc-id=id:  set the id of the current process from multi-process ..
> (0 <= id < num-procs).
>   --nb-cores=N: set the number of forwarding cores (1 <= N <= 55).
> ...
> .
>

[PATCH v6] app/testpmd: add help messages for multi-process

[Dongdong Liu]

From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs=N: set the total number of multi-process instances.
--proc-id=id:  set the id of the current process from multi-process
instances(0 <= id < num-procs).

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
v5->v6:
- Adjust the print information for multi-process.
---
 app/test-pmd/parameters.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 641c9c767e..0201382294 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,9 @@ usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs=N: set the total number of multi-process instances.\n");
+	printf("  --proc-id=id:  set the id of the current process from "
+	       "multi-process instances (0 <= id < num-procs).\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "
-- 
2.33.0

Re: [PATCH v6] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 6/9/2022 9:52 AM, Dongdong Liu wrote:

> 
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs=N: set the total number of multi-process instances.
> --proc-id=id:  set the id of the current process from multi-process
> instances(0 <= id < num-procs).
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
> v5->v6:
> - Adjust the print information for multi-process.
> ---
>   app/test-pmd/parameters.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 641c9c767e..0201382294 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,9 @@ usage(char* progname)
>                 "extended statistics to show. Used with --stats-period "
>                 "specified or interactive commands that show Rx/Tx statistics "
>                 "(i.e. 'show port stats').\n");
> +       printf("  --num-procs=N: set the total number of multi-process instances.\n");
> +       printf("  --proc-id=id:  set the id of the current process from "

there are double space after '--proc-id=id:', but I can fix it while 
merging.

> +              "multi-process instances (0 <= id < num-procs).\n");
>          printf("  --nb-cores=N: set the number of forwarding cores "
>                 "(1 <= N <= %d).\n", nb_lcores);
>          printf("  --nb-ports=N: set the number of forwarding ports "
> --
> 2.33.0
> 

Re: [PATCH v6] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 6/9/2022 3:06 PM, Ferruh Yigit wrote:
> On 6/9/2022 9:52 AM, Dongdong Liu wrote:
> 
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs=N: set the total number of multi-process instances.
>> --proc-id=id:  set the id of the current process from multi-process
>> instances(0 <= id < num-procs).
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>

Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Applied to dpdk-next-net/main, thanks.