Re: 24.11.2 patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 21/04/2025 07:18, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Friday, March 28, 2025 6:15 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>> <thomas@monjalon.net>; yanghliu@redhat.com
>> Subject: 24.11.2 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 24.11.2.
>>
>> The planned date for the final release is 14 April.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v24.11.2-rc1
>>
>> These patches are located at branch 24.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---

Hi Hailin,

Thanks for the testing and report. Comments below.

> Update the test status for Intel part. dpdk24.11.2-rc1 all validation test done. no new issue is found.
> 
> known issues: fix patch has been merged into main, but they not merged 24.11 LTS, so this issue still exists in 24.11.2-rc1
>   1. Bug 1606 - flow_filtering/flow_filtering_mismatch_rule: Some mismatch rule packets match the rule.
>      - has fix patch: https://patches.dpdk.org/project/dpdk/patch/20250112075200.5020-1-shperetz@nvidia.com/

(CC: Shani)

This patch is part of 24.11.2-rc2, so not sure if it's the same issue
you are seeing ?

It is applied here
https://git.dpdk.org/dpdk-stable/commit/?id=b540e51a864d25b1e254fa8c311b92223e0f4162

$ git tag --contains b540e51a8
v24.11.2-rc1

$ git show b540e51a8
commit b540e51a864d25b1e254fa8c311b92223e0f4162
Author: Shani Peretz <shperetz@nvidia.com>
Date:   Sun Jan 12 09:52:00 2025 +0200

    examples/flow_filtering: fix IPv4 matching snippet

    [ upstream commit 5fa25916f1ab47c82310264449a6d67dbb15ca4d ]

    This patch corrects the destination IP address mask to
    restore the previous implementation's behavior.

    Also it fixes a misuse of rte_flow_item_tcp struct.
    Replace it with the appropriate rte_flow_item_ipv4 struct,
    as the code in this context filters ipv4 traffic.

    Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases
snippets")

    Signed-off-by: Shani Peretz <shperetz@nvidia.com>


>   2. Linkville vfs can't forward packets
>      - has fix patches: https://patches.dpdk.org/project/dpdk/list/?series=34939&archive=both&state=*
> 

This issue was introduced by missing case in commit '316637762a5f
("net/ixgbe/base: enable E610 device")' from 24.07. The patches linked
are already applied in main branch and patch 2/3 has the fix.

In summary, the first reported issue is example code. The second issue
is not a regression from 24.11.1 but I'll apply the fix patch for that
as it's straightforward.

I will go ahead with the release as it is overdue. It would be nice if
we can resolve the first issue for 24.11.3 but we have time.

thanks,
Kevin

> * Build & CFLAG compile: cover the build test with latest GCC/Clang version on the following OS(all passed)
>   - Ubuntu24.10/Ubuntu24.04.1
>   - RHEL9.4/RHEL9.5/RHEL10 beta
>   - Fedora41
>   - FreeBSD14.2
>   - SUSE15.6
>   - OpenAnolis8.9
>   - AzureLinux3.0
> 
> * Function tests: All test done and there are two known issues.
>   - i40E-(XXV710, X722) PF/VF: test scenarios including basic/RTE_FLOW/TSO/Jumboframe/checksum offload/mac_filter/VLAN/VXLAN/RSS, etc. 
>   - IXGBE-(82599, E610) PF/VF: test scenarios including basic/RTE_FLOW/TSO/Jumboframe/checksum offload/mac_filter/VLAN/VXLAN/RSS, etc. 
>   - ICE-(E810, E830, E2100) PF/VF: test scenarios including basic/Switch/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>   - IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
>   - Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
>   - Cryptodev: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>   - DLB: test scenarios including DLB2.0 and DLB2.5
>   - Other: test scenarios including AF_XDP, Power, CBDMA, DSA
> 
> * Performance test: All test done and passed
>   - Thoughput Performance
>   - Cryptodev Latency
>   - PF/VF NIC single core
>   - XXV710/E810 NIC Performance
> 
> 
> Regards,
> Xu, Hailin
>