From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 29D401B006; Thu, 2 Aug 2018 04:22:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 19:22:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="250996166" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2018 19:22:00 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 19:22:01 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 19:22:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 10:21:58 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Li, Xiaoyun" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/avf: fix missing offload capabilities Thread-Index: AQHUKTXW3z8NeeEHg0ySallm5y9356Splw6AgAGYcgCAAI0WIA== Date: Thu, 2 Aug 2018 02:21:58 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153262AD9@SHSMSX103.ccr.corp.intel.com> References: <1532502870-448711-1-git-send-email-xiaoyun.li@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B80C02C@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B80C4C2@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B80C4C2@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDViYzZkOTItNWZiNy00MWU3LWI4ZWMtNmYzNmVhMWY0NDZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFh3VEhybjRVQnJsMHZYU3N3QlVJcXFwNUgxRzREZU5vUVdNUytiVks3WUtDTTZnK014WXdRc3o5Rlg4blVmZiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 02:22:03 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Thursday, August 2, 2018 9:56 AM > To: Li, Xiaoyun ; Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities >=20 > Hi Xiaoyun, >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Wednesday, August 1, 2018 9:35 AM > > To: Lu, Wenzhuo ; Wu, Jingjing > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > Hi > > > > > -----Original Message----- > > > From: Lu, Wenzhuo > > > Sent: Wednesday, August 1, 2018 09:19 > > > To: Li, Xiaoyun ; Wu, Jingjing > > > > > > Cc: dev@dpdk.org; stable@dpdk.org > > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > > > Hi Xiaoyun, > > > > > > > > > > -----Original Message----- > > > > From: Li, Xiaoyun > > > > Sent: Wednesday, July 25, 2018 3:15 PM > > > > To: Lu, Wenzhuo ; Wu, Jingjing > > > > > > > > Cc: dev@dpdk.org; Li, Xiaoyun ; > > > > stable@dpdk.org > > > > Subject: [PATCH] net/avf: fix missing offload capabilities > > > > > > > > There are several tx/rx offload capabilities missing in AVF. > > > > Add them in this patch since AVF supports them. > > > > > > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Xiaoyun Li > > > > --- > > > > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/net/avf/avf_ethdev.c > > > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644 > > > > --- a/drivers/net/avf/avf_ethdev.c > > > > +++ b/drivers/net/avf/avf_ethdev.c > > > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, > > > > struct rte_eth_dev_info *dev_info) > > > > dev_info->max_mac_addrs =3D AVF_NUM_MACADDR_MAX; > > > > dev_info->rx_offload_capa =3D > > > > DEV_RX_OFFLOAD_VLAN_STRIP | > > > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > > > DEV_RX_OFFLOAD_UDP_CKSUM | > > > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > > > + DEV_RX_OFFLOAD_CRC_STRIP | > > > > + DEV_RX_OFFLOAD_KEEP_CRC | > > > Don't find this flag. Does this path depend on another? > > > Do we need to announce this capa? > > > > You mean KEEP_CRC? I copy the flags from i40evf. > > In release note: > > In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, > > default > > behavior without any flag will be changed to CRC strip. > > To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. > > ``KEEP_CRC``: Keep CRC in packet > > No flag: Strip CRC from packet > O, got the history. > Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel. Thanks! Qi