From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <qi.z.zhang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id E113D7D05;
Wed, 13 Feb 2019 04:35:04 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
12 Feb 2019 19:35:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,364,1544515200"; d="scan'208";a="133150673"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
by FMSMGA003.fm.intel.com with ESMTP; 12 Feb 2019 19:35:03 -0800
Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by
FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Tue, 12 Feb 2019 19:35:03 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.194]) by
SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0415.000;
Wed, 13 Feb 2019 11:35:01 +0800
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF
Thread-Index: AQHUrVw6DNWwa4HCsUOvyXjjU77ayaXdPuNQ
Date: Wed, 13 Feb 2019 03:35:00 +0000
Message-ID: <039ED4275CED7440929022BC67E7061153333BB6@SHSMSX103.ccr.corp.intel.com>
References: <1547613775-58027-1-git-send-email-wei.zhao1@intel.com>
<1547614920-59680-1-git-send-email-wei.zhao1@intel.com>
<1547614920-59680-2-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1547614920-59680-2-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhhMjg1Y2YtNmE2Zi00MjQyLTk1MGMtMGI4NTM1NmI0MWRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR01EM1wvVmtCMURzN1ZcL21pMXJoaU5VeVJKc1R6T1U4SzQ4THdRdmgrdUg0dExXb1NDQ0c0a3c4ODRacjdxSHMxIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH v2 1/3] net/ixgbe: promiscuous mode enable
on VF
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 03:35:05 -0000
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, January 16, 2019 1:02 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF
>=20
> There is need to enable two ops of promiscuous_enable and
> promiscuous_disable on VF.
>=20
> Fixes: af75078fece3 ("first public release")
I think this is not a fix, we just add some feature not be implemented.
Btw, you need to update doc/guides/nics/features/ixgbe_vf.ini
>=20
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 91ba620..e8a2c6e 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -260,6 +260,8 @@ static int ixgbevf_dev_rx_queue_intr_disable(struct
> rte_eth_dev *dev, static void ixgbevf_set_ivar_map(struct ixgbe_hw *hw,
> int8_t direction,
> uint8_t queue, uint8_t msix_vector); static void
> ixgbevf_configure_msix(struct rte_eth_dev *dev);
> +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);
> +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);
> static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev); s=
tatic
> void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev);
>=20
> @@ -596,6 +598,8 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops =
=3D {
> .xstats_get_names =3D ixgbevf_dev_xstats_get_names,
> .dev_close =3D ixgbevf_dev_close,
> .dev_reset =3D ixgbevf_dev_reset,
> + .promiscuous_enable =3D ixgbevf_dev_promiscuous_enable,
> + .promiscuous_disable =3D ixgbevf_dev_promiscuous_disable,
> .allmulticast_enable =3D ixgbevf_dev_allmulticast_enable,
> .allmulticast_disable =3D ixgbevf_dev_allmulticast_disable,
> .dev_infos_get =3D ixgbevf_dev_info_get,
> @@ -8290,6 +8294,22 @@ ixgbe_dev_udp_tunnel_port_del(struct rte_eth_dev
> *dev, }
>=20
> static void
> +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) {
> + struct ixgbe_hw *hw =3D
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + hw->mac.ops.update_xcast_mode(hw,
> IXGBEVF_XCAST_MODE_PROMISC); }
> +
> +static void
> +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) {
> + struct ixgbe_hw *hw =3D
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE); }
> +
> +static void
> ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev) {
> struct ixgbe_hw *hw =3D
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> --
> 2.7.5