From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FD26A0487 for ; Fri, 5 Jul 2019 03:14:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E40131B970; Fri, 5 Jul 2019 03:14:58 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 46A711BE0; Fri, 5 Jul 2019 03:14:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 18:14:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,453,1557212400"; d="scan'208";a="175365337" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 04 Jul 2019 18:14:53 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 18:14:53 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 18:14:53 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0439.000; Fri, 5 Jul 2019 09:14:51 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix unexpected skip fdir setup Thread-Index: AQHVMWkdr816FIcmEEyJyj3G2lDjg6a5NGmAgAIGo4A= Date: Fri, 5 Jul 2019 01:14:50 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D60388@SHSMSX105.ccr.corp.intel.com> References: <20190703063449.23848-1-qi.z.zhang@intel.com> <94479800C636CB44BD422CB454846E013CE0163D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CE0163D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGY5YWMwYTQtOWQzYi00MzRlLThiOGMtYmUwMTcwM2Y4NTVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY0JGaVlUaUd2dDd0VFJTSkIxQXErYlBKUlVPUk1FMENaTTRMOWZaSXlrQjNsNnBCdXRoN0VEOHZRa0o2QWhlaSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix unexpected skip fdir setup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, July 4, 2019 10:18 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/i40e: fix unexpected skip fdir setup >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, July 3, 2019 2:35 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > > Subject: [PATCH] net/i40e: fix unexpected skip fdir setup > > > > In i40e_flow_flush_fdir_filter, i40e_fdir_teardown is called, so > > i40e_fdir_setup is required to be called before create a new fdir flow. > > > > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > > Cc: stable@dpdk.org Added Bugzilla ID: 265 > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/i40e/i40e_flow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > d62b32f17..48a6782a8 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -3175,8 +3175,8 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev > > *dev, > > > > cons_filter_type =3D RTE_ETH_FILTER_FDIR; > > > > - if (dev->data->dev_conf.fdir_conf.mode !=3D > > - RTE_FDIR_MODE_PERFECT) { > > + if (dev->data->dev_conf.fdir_conf.mode !=3D > > RTE_FDIR_MODE_PERFECT || > > + pf->fdir.fdir_vsi =3D=3D NULL) { > > /* Enable fdir when fdir flow is added at first time. */ > > ret =3D i40e_fdir_setup(pf); > > if (ret !=3D I40E_SUCCESS) { > > -- > > 2.13.6 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi