* [dpdk-stable] [PATCH] net/i40e: fix flow control broken
@ 2019-12-06 15:41 Guinan Sun
2019-12-08 23:51 ` Zhang, Qi Z
2019-12-16 5:06 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
0 siblings, 2 replies; 4+ messages in thread
From: Guinan Sun @ 2019-12-06 15:41 UTC (permalink / raw)
To: dev; +Cc: Beilei Xing, Qi Zhang, Qiming Yang, Guinan Sun, stable
Repeat switching flow control on or off during receiving traffic,
testpmd reports "failed to switch Tx queue occurs" after quit.
The patch fixes the issue.
Fixes: f53577f06925 ("i40e: support flow control")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5999c964b..5507f6c39 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -53,7 +53,7 @@
/* Wait count and interval */
#define I40E_CHK_Q_ENA_COUNT 1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
/* Maximun number of VSI */
#define I40E_MAX_NUM_VSIS (384UL)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/i40e: fix flow control broken
2019-12-06 15:41 [dpdk-stable] [PATCH] net/i40e: fix flow control broken Guinan Sun
@ 2019-12-08 23:51 ` Zhang, Qi Z
2019-12-16 5:06 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2019-12-08 23:51 UTC (permalink / raw)
To: Sun, GuinanX, dev; +Cc: Xing, Beilei, Yang, Qiming, stable
> -----Original Message-----
> From: Sun, GuinanX <guinanx.sun@intel.com>
> Sent: Friday, December 6, 2019 11:41 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Sun, GuinanX
> <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix flow control broken
>
> Repeat switching flow control on or off during receiving traffic, testpmd reports
> "failed to switch Tx queue occurs" after quit.
> The patch fixes the issue.
The explain more about the root cause and the fix.
>
> Fixes: f53577f06925 ("i40e: support flow control")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 5999c964b..5507f6c39 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -53,7 +53,7 @@
>
> /* Wait count and interval */
> #define I40E_CHK_Q_ENA_COUNT 1000
> -#define I40E_CHK_Q_ENA_INTERVAL_US 1000
> +#define I40E_CHK_Q_ENA_INTERVAL_US 50000
>
> /* Maximun number of VSI */
> #define I40E_MAX_NUM_VSIS (384UL)
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix flow control broken
2019-12-06 15:41 [dpdk-stable] [PATCH] net/i40e: fix flow control broken Guinan Sun
2019-12-08 23:51 ` Zhang, Qi Z
@ 2019-12-16 5:06 ` Ye Xiaolong
2019-12-16 5:22 ` Ye Xiaolong
1 sibling, 1 reply; 4+ messages in thread
From: Ye Xiaolong @ 2019-12-16 5:06 UTC (permalink / raw)
To: Guinan Sun; +Cc: dev, Beilei Xing, Qi Zhang, Qiming Yang, stable
On 12/06, Guinan Sun wrote:
>Repeat switching flow control on or off during receiving traffic,
>testpmd reports "failed to switch Tx queue occurs" after quit.
>The patch fixes the issue.
>
>Fixes: f53577f06925 ("i40e: support flow control")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 5999c964b..5507f6c39 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -53,7 +53,7 @@
>
> /* Wait count and interval */
> #define I40E_CHK_Q_ENA_COUNT 1000
>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
>
> /* Maximun number of VSI */
> #define I40E_MAX_NUM_VSIS (384UL)
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix flow control broken
2019-12-16 5:06 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-12-16 5:22 ` Ye Xiaolong
0 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2019-12-16 5:22 UTC (permalink / raw)
To: Guinan Sun; +Cc: dev, Beilei Xing, Qi Zhang, Qiming Yang, stable
On 12/16, Ye Xiaolong wrote:
>On 12/06, Guinan Sun wrote:
>>Repeat switching flow control on or off during receiving traffic,
>>testpmd reports "failed to switch Tx queue occurs" after quit.
>>The patch fixes the issue.
>>
>>Fixes: f53577f06925 ("i40e: support flow control")
>>Cc: stable@dpdk.org
>>
>>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>>---
>> drivers/net/i40e/i40e_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>>index 5999c964b..5507f6c39 100644
>>--- a/drivers/net/i40e/i40e_ethdev.c
>>+++ b/drivers/net/i40e/i40e_ethdev.c
>>@@ -53,7 +53,7 @@
>>
>> /* Wait count and interval */
>> #define I40E_CHK_Q_ENA_COUNT 1000
>>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
>>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
>>
>> /* Maximun number of VSI */
>> #define I40E_MAX_NUM_VSIS (384UL)
>>--
>>2.17.1
>>
>
>Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Applied to dpdk-next-net-intel, Thanks.
Sorry, there is still concern about this patch, drop it from next-net-intel first.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-16 5:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 15:41 [dpdk-stable] [PATCH] net/i40e: fix flow control broken Guinan Sun
2019-12-08 23:51 ` Zhang, Qi Z
2019-12-16 5:06 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-12-16 5:22 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).