patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Jiang, MaoX" <maox.jiang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Jiang, MaoX" <maox.jiang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource	error
Date: Mon, 20 Jul 2020 10:31:06 +0000
Message-ID: <039ED4275CED7440929022BC67E70611548625B6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20200708195239.4543-1-maox.jiang@intel.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jiang Mao
> Sent: Thursday, July 9, 2020 3:53 AM
> To: Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Jiang, MaoX <maox.jiang@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error
> 
> Fdir allocating msix resource is not strictly necessary, if no resource left, print a
> warning message.
> 
> Fixes: 4861cde461 (i40e: new poll mode driver)
> Cc: stable@dpdk.org
> Signed-off-by: Jiang Mao <maox.jiang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 16fcb8d..885b637 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -5732,6 +5732,17 @@ struct i40e_vsi *
>  			vsi->nb_msix = RTE_MIN(vsi->nb_qps,
>  					       RTE_MAX_RXTX_INTR_VEC_ID);
>  		}
> +	} else if (type == I40E_VSI_FDIR) {
> +		ret = i40e_res_pool_alloc(&pf->msix_pool, 1);
> +		if (ret < 0) {
> +			PMD_DRV_LOG(WARNING, "MSIX vectors used up, FDIR can`t
> bind interrupt");
> +			vsi->msix_intr = 0;
> +			vsi->nb_msix = 0;
> +		} else {
> +			vsi->msix_intr = ret;
> +			vsi->nb_msix = 1;
> +		}
> +

Better to merge above branch into below branch and remove the "else" branch

>  	} else if (type != I40E_VSI_SRIOV) {
>  		ret = i40e_res_pool_alloc(&pf->msix_pool, 1);
>  		if (ret < 0) {
> --
> 1.8.3.1


  reply	other threads:[~2020-07-20 10:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  2:25 [dpdk-stable] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors Jiang Mao
2020-06-09  2:25 ` [dpdk-stable] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error Jiang Mao
2020-06-17  5:43   ` [dpdk-stable] [dpdk-dev] " Huang, ZhiminX
2020-07-08 19:52   ` [dpdk-stable] " Jiang Mao
2020-07-20 10:31     ` Zhang, Qi Z [this message]
2020-07-21 19:51     ` [dpdk-stable] [PATCH] " Jiang Mao
2020-06-17  5:42 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors Huang, ZhiminX
2020-07-08 19:50 ` [dpdk-stable] " Jiang Mao
2020-07-21  3:57   ` [dpdk-stable] [dpdk-dev] " Jeff Guo
2020-07-21  6:50     ` Jiang, MaoX
2020-07-22 17:57   ` [dpdk-stable] [PATCH v3 " Jiang Mao
2020-07-22 17:57     ` [dpdk-stable] [PATCH v3 2/2] net/i40e: fix fdir allocating msix resource error Jiang Mao
2020-07-23 16:11       ` [dpdk-stable] [PATCH v4 " Jiang Mao
2020-07-23 12:40         ` Zhang, Qi Z
2020-07-23 15:27     ` [dpdk-stable] [PATCH v4 1/2] net/i40e: fix binding interrupt without msix vectors Jiang Mao
2020-07-23 12:40       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E70611548625B6@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=maox.jiang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git