patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [DPDK v2] net/i40e: add VLAN filter feature to capability
       [not found] <20200720024214.13972-1-zhihongx.peng@intel.com>
@ 2020-07-21  2:45 ` zhihongx.peng
  2020-07-21  3:11   ` Jeff Guo
  0 siblings, 1 reply; 3+ messages in thread
From: zhihongx.peng @ 2020-07-21  2:45 UTC (permalink / raw)
  To: beilei.xing, jia.guo; +Cc: dev, Peng Zhihong, stable

From: Peng Zhihong <zhihongx.peng@intel.com>

The rte_eth_dev_set_vlan_offload function will check vlan rx offload
capability, the i40e vf has vlan filter feature but
DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
cause setting fail. So need to add this capability in
i40e_vf_representor_dev_infos_get function.

Fixes: e0cb96204b71 (net/i40e: add support for representor ports)
Cc: stable@dpdk.org

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 drivers/net/i40e/i40e_vf_representor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
index b07b35c03..083bc1a5f 100644
--- a/drivers/net/i40e/i40e_vf_representor.c
+++ b/drivers/net/i40e/i40e_vf_representor.c
@@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
 		DEV_RX_OFFLOAD_QINQ_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |
-		DEV_RX_OFFLOAD_TCP_CKSUM;
+		DEV_RX_OFFLOAD_TCP_CKSUM |
+		DEV_RX_OFFLOAD_VLAN_FILTER;
 	dev_info->tx_offload_capa =
 		DEV_TX_OFFLOAD_MULTI_SEGS  |
 		DEV_TX_OFFLOAD_VLAN_INSERT |
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [DPDK v2] net/i40e: add VLAN filter feature to capability
  2020-07-21  2:45 ` [dpdk-stable] [DPDK v2] net/i40e: add VLAN filter feature to capability zhihongx.peng
@ 2020-07-21  3:11   ` Jeff Guo
  2020-07-21  5:01     ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Guo @ 2020-07-21  3:11 UTC (permalink / raw)
  To: zhihongx.peng, beilei.xing; +Cc: dev, stable

Acked-by: Jeff Guo <jia.guo@intel.com>

On 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:
> From: Peng Zhihong <zhihongx.peng@intel.com>
>
> The rte_eth_dev_set_vlan_offload function will check vlan rx offload
> capability, the i40e vf has vlan filter feature but
> DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
> cause setting fail. So need to add this capability in
> i40e_vf_representor_dev_infos_get function.
>
> Fixes: e0cb96204b71 (net/i40e: add support for representor ports)
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>   drivers/net/i40e/i40e_vf_representor.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
> index b07b35c03..083bc1a5f 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
>   		DEV_RX_OFFLOAD_QINQ_STRIP |
>   		DEV_RX_OFFLOAD_IPV4_CKSUM |
>   		DEV_RX_OFFLOAD_UDP_CKSUM |
> -		DEV_RX_OFFLOAD_TCP_CKSUM;
> +		DEV_RX_OFFLOAD_TCP_CKSUM |
> +		DEV_RX_OFFLOAD_VLAN_FILTER;
>   	dev_info->tx_offload_capa =
>   		DEV_TX_OFFLOAD_MULTI_SEGS  |
>   		DEV_TX_OFFLOAD_VLAN_INSERT |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability
  2020-07-21  3:11   ` Jeff Guo
@ 2020-07-21  5:01     ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2020-07-21  5:01 UTC (permalink / raw)
  To: Guo, Jia, Peng, ZhihongX, Xing, Beilei; +Cc: dev, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jeff Guo
> Sent: Tuesday, July 21, 2020 11:12 AM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability
> 
> Acked-by: Jeff Guo <jia.guo@intel.com>
> 
> On 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:
> > From: Peng Zhihong <zhihongx.peng@intel.com>
> >
> > The rte_eth_dev_set_vlan_offload function will check vlan rx offload
> > capability, the i40e vf has vlan filter feature but
> > DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
> > cause setting fail. So need to add this capability in
> > i40e_vf_representor_dev_infos_get function.
> >
> > Fixes: e0cb96204b71 (net/i40e: add support for representor ports)

Fix line should be (".....")

> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-21  5:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200720024214.13972-1-zhihongx.peng@intel.com>
2020-07-21  2:45 ` [dpdk-stable] [DPDK v2] net/i40e: add VLAN filter feature to capability zhihongx.peng
2020-07-21  3:11   ` Jeff Guo
2020-07-21  5:01     ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git