From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 199CFA0527 for ; Thu, 23 Jul 2020 12:25:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8E241BFD9; Thu, 23 Jul 2020 12:25:43 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 277B42C01; Thu, 23 Jul 2020 12:25:40 +0200 (CEST) IronPort-SDR: BiXTRhjHAlK1glRrBHiAl4GplK1YUHzfb7pcEF0gQeBs9OokMXYaMzRU4/3WQTghZgT2AtdOLR UADDCdZjecKw== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="235366069" X-IronPort-AV: E=Sophos;i="5.75,386,1589266800"; d="scan'208";a="235366069" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 03:25:39 -0700 IronPort-SDR: 43Etm/X2qJMk9tTVaZbQkJMjBdGhxrg9EQfaqO5qwQNPGqxa7k3zNnz9NNLeCCxwnowPuo/KxF dRxADyNAZucA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,386,1589266800"; d="scan'208";a="310977328" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 23 Jul 2020 03:25:39 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Jul 2020 03:25:38 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 23 Jul 2020 03:25:38 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 23 Jul 2020 03:25:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.135]) with mapi id 14.03.0439.000; Thu, 23 Jul 2020 18:25:35 +0800 From: "Zhang, Qi Z" To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Yang, Qiming" , "Yao, Lei A" , "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix default RSS key configuration Thread-Index: AQHWXz67Bt3NSbuAn0WM6QcBqBhv0KkTEnwAgAHlp/A= Date: Thu, 23 Jul 2020 10:25:35 +0000 Message-ID: <039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com> References: <20200721090258.65715-1-xiao.w.wang@intel.com> <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ice: fix default RSS key configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, July 22, 2020 1:26 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; Yang, Qiming ; Yao, Lei A > ; Wu, Jingjing ; stable@dpdk.= org > Subject: RE: [PATCH] net/ice: fix default RSS key configuration >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Xiao W > > Sent: Tuesday, July 21, 2020 5:03 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Yang, Qiming ; Yao, Lei A > > ; Wu, Jingjing ; Wang, > > Xiao W ; stable@dpdk.org > > Subject: [PATCH] net/ice: fix default RSS key configuration > > > > There's chance that rte_rand() doesn't provision suitable values for > > RSS hash, an extreme example could be a key with a lot of 0s in it. > > > > This patch adds a default RSS key which has been used in ixgbe driver > > and fm10k driver. > > > > Fixes: 50370662b727 ("net/ice: support device and queue ops") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Wang >=20 > Acked-by: Qi Zhang >=20 > Applied to dpdk-next-net-intel. After some internal discussion, we decide to keep the random key as default= , and user can use rte_eth_dev_rss_hash_update to update a new key. So the patch has been removed from dpdk-next-net-intel. >=20 > Thanks > Qi