From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46AE6A04DD for ; Wed, 21 Oct 2020 00:47:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECB296A44; Wed, 21 Oct 2020 00:47:03 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0D9206A44 for ; Wed, 21 Oct 2020 00:47:02 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201020224645euoutp016e44bd79028cce0ed11bbc9eab3d859e~-1NVm-oYs1076010760euoutp01P for ; Tue, 20 Oct 2020 22:46:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201020224645euoutp016e44bd79028cce0ed11bbc9eab3d859e~-1NVm-oYs1076010760euoutp01P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1603234005; bh=sjdJj89eWBEROhLO+L7k3bmd82DCRNHLrh8PhvkQOIE=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=M9rkL2db0+BFzzCsDHep0e4ExKJ/WYzF+nmBi52inXp7Kdwj/XBGPenwrOHKfi2+2 BxZgPijrLad4A+fSTFzjC0PJHTAFWfyDZBWgDlbG+GTmWM1yf09B+cPiVa+y+7aetR HxQx3i5tsQR1WVanDIWW9jy+Wgi/HqHQHVHetmwY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201020224635eucas1p20c9803874d9f5df0d71d10c146638c8a~-1NM1lxLd2916829168eucas1p2f; Tue, 20 Oct 2020 22:46:35 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 67.98.05997.BC86F8F5; Tue, 20 Oct 2020 23:46:35 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201020224634eucas1p214e5aba0859d86854abcefbf0e4738bd~-1NLjbHv30572405724eucas1p2P; Tue, 20 Oct 2020 22:46:34 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201020224634eusmtrp2dc36e92747779867a10d177c14daa553~-1NLit7xm2962429624eusmtrp2V; Tue, 20 Oct 2020 22:46:34 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-1b-5f8f68cb855a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id AB.B5.06017.AC86F8F5; Tue, 20 Oct 2020 23:46:34 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201020224633eusmtip16273db31135c658f07f9cf610cf4a8de~-1NKpgcqS2380623806eusmtip1S; Tue, 20 Oct 2020 22:46:33 +0000 (GMT) To: Honnappa Nagarahalli , dev@dpdk.org, john.mcnamara@intel.com Cc: ruifeng.wang@arm.com, juraj.linkes@pantheon.tech, david.marchand@redhat.com, nd@arm.com, ian.betts@intel.com, stable@dpdk.org, "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: <04382a3f-66f0-4e85-bb52-588ac9ad0414@partner.samsung.com> Date: Wed, 21 Oct 2020 00:46:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201016060349.19940-2-honnappa.nagarahalli@arm.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAKsWRmVeSWpSXmKPExsWy7djP87qnM/rjDc5etbDYvqKLzeLdp+1M FjOftrBb/Hwxjc3i/LytrBZLjxxhtHjWs47R4szyHmaLq303mC3+dfxhd+DyWDNvDaPHrwVL WT0W73nJ5HFw6i1Gj4Pv9jB5vN93lS2ALYrLJiU1J7MstUjfLoEr497f+SwFM3krWpZ3MjUw ruDuYuTkkBAwkfg4fzZTFyMXh5DACkaJS31TmCGcL4wSO6+dhsp8ZpSY/m8qkMMB1nL0aA5E fDmjxJaTH6CK3jJKvPg5gxlkrrBAqMSHl80sIA0iAgkSy6dZg9QwCxxnlDix6AUbSA2bgK3E kZlfWUFsXgE3iY6Zi8FsFgFViRN/LzOB2KICcRITNrawQNQISpyc+QTM5hRwkni3aj8jiM0s IC/RvHU2M4QtLnHryXywgyQEzrFLzP6wlgXiUReJD/d6mSFsYYlXx7ewQ9gyEv93wjRsY5S4 +vsnI4Szn1Hieu8KqCpricP/frOBvMMsoCmxfpc+RNhR4sLireyQYOGTuPFWEOIIPolJ26Yz Q4R5JTrahCCq9SSe9kxlhFn7Z+0TlgmMSrOQvDYLyTuzkLwzC2HvAkaWVYziqaXFuempxUZ5 qeV6xYm5xaV56XrJ+bmbGIHp6vS/4192MO76k3SIUYCDUYmHt4KpP16INbGsuDL3EKMEB7OS CK/T2dNxQrwpiZVVqUX58UWlOanFhxilOViUxHmNF72MFRJITyxJzU5NLUgtgskycXBKNTBq KnJ9fMej/GndhMacmrnfNS/FuSbvNF2iEZUSlXtV1y5FTuFZdYyny77Ft+LOnHoVxjzv1Ael SpEf/NtCrfkEeWXnh1hnTrg8gbvQgElmfelNJ54Dnx2TNh+45G/Hvff4vkr/9Rcd0yurvgfk LqrMllvts/GDbMYpd3uX0snJMcKFYZ0X5yqxFGckGmoxFxUnAgDoWtgzUwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t/xu7qnMvrjDU71yVlsX9HFZvHu03Ym i5lPW9gtfr6YxmZxft5WVoulR44wWjzrWcdocWZ5D7PF1b4bzBb/Ov6wO3B5rJm3htHj14Kl rB6L97xk8jg49Rajx8F3e5g83u+7yhbAFqVnU5RfWpKqkJFfXGKrFG1oYaRnaGmhZ2RiqWdo bB5rZWSqpG9nk5Kak1mWWqRvl6CXce/vfJaCmbwVLcs7mRoYV3B3MXJwSAiYSBw9mtPFyMkh JLCUUeLYhGqIsIzEh0sCIGEJAWGJP9e62CBKXjNKfNyXCWILC4RKfHjZzAJiiwgkSHyb3wZU w8XBLHCcUeLT9/+MEA1nGSUmbg8BsdkEbCWOzPzKCmLzCrhJdMxcDGazCKhKnPh7mQnEFhWI k/gxsZcNokZQ4uTMJ2ALOAWcJN6t2g82k1nATGLe5ofMELa8RPPW2VC2uMStJ/OZJjAKzULS PgtJyywkLbOQtCxgZFnFKJJaWpybnltspFecmFtcmpeul5yfu4kRGJnbjv3csoOx613wIUYB DkYlHt4LLP3xQqyJZcWVuYcYJTiYlUR4nc6ejhPiTUmsrEotyo8vKs1JLT7EaAr03ERmKdHk fGDSyCuJNzQ1NLewNDQ3Njc2s1AS5+0QOBgjJJCeWJKanZpakFoE08fEwSnVwKjD3uh6ULtX 5Vzu7OezQudbzZ7TNKvBJCEi2En3V6tm95KYoxe1rI04Gy8tZ9rS8WCitorW0q8up/86CvS/ a1XfoByXvrEroZo3/7i+/OZZC135W+x92DadWNQQxWJmIZN9INVVq/7S8y/M5XXf7U4Wsny9 3DDbmCF67mKx/w7/1JbptoWmK7EUZyQaajEXFScCAGJA6HjiAgAA X-CMS-MailID: 20201020224634eucas1p214e5aba0859d86854abcefbf0e4738bd X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201016060439eucas1p2ff6e4c4fdd18df26914b3e2ee9fd87cb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201016060439eucas1p2ff6e4c4fdd18df26914b3e2ee9fd87cb References: <20201016060349.19940-1-honnappa.nagarahalli@arm.com> <20201016060349.19940-2-honnappa.nagarahalli@arm.com> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] examples/performance-thread: fix undef behavior X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Looks good! W dniu 16.10.2020 o 08:03, Honnappa Nagarahalli pisze: > When the value of RTE_MAX_LCORE is small, it results in the > following compilation error. > > ../examples/performance-thread/l3fwd-thread/main.c:2338:34: error: > iteration 4 invokes undefined behavior > [-Werror=aggressive-loop-optimizations] > > Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") > Cc: ian.betts@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang     Tested-by: Lukasz Wojciechowski     Reviewed-by: Lukasz Wojciechowski > --- > examples/performance-thread/l3fwd-thread/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c > index 818e483d2..dc34d4893 100644 > --- a/examples/performance-thread/l3fwd-thread/main.c > +++ b/examples/performance-thread/l3fwd-thread/main.c > @@ -599,8 +599,8 @@ struct thread_rx_conf rx_thread[MAX_RX_THREAD]; > struct thread_tx_conf { > struct thread_conf conf; > > - uint16_t tx_queue_id[RTE_MAX_LCORE]; > - struct mbuf_table tx_mbufs[RTE_MAX_LCORE]; > + uint16_t tx_queue_id[RTE_MAX_ETHPORTS]; > + struct mbuf_table tx_mbufs[RTE_MAX_ETHPORTS]; > > struct rte_ring *ring; > struct lthread_cond **ready; -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com