patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Andrew Rybchenko <>
To: Viacheslav Ovsiienko <>,
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port
Date: Thu, 1 Jul 2021 17:01:34 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 6/19/21 6:40 PM, Viacheslav Ovsiienko wrote:
> For the newly attached ports (with "port attach" command) the
> default offloads settings, configured from application command
> line, were not applied, causing port start failure following
> the attach. For example, if scattering offload was configured
> in command line and rxpkts was configured for multiple segments,
> the newly attached port start was failed due to missing scattering
> offload enable in the new port settings. The missing code to apply
> the offloads to the new device and its queues is added.
> Cc:
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")

Two above lines should be swapped.

> Signed-off-by: Viacheslav Ovsiienko <>

The patch duplicates too much from init_config() function.
Please, factor out a helper function to do the job and
use it in init_config() and reconfig().

  reply	other threads:[~2021-07-01 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 15:40 [dpdk-stable] " Viacheslav Ovsiienko
2021-07-01 14:01 ` Andrew Rybchenko [this message]
2021-07-12 10:24 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
2021-07-12 12:40 ` [dpdk-stable] [PATCH v3] " Viacheslav Ovsiienko
2021-07-13  5:37   ` Li, Xiaoyun
2021-07-13  9:50     ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).