From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 136BDA0A0F for ; Thu, 1 Jul 2021 16:01:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A2D8412F4; Thu, 1 Jul 2021 16:01:37 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C8E5F4003E; Thu, 1 Jul 2021 16:01:34 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 77AB27F57E; Thu, 1 Jul 2021 17:01:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 77AB27F57E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625148094; bh=fGH8Elm65U2C1qekgBEgzTuWi5Hp3tJZsMTwu5pYOA0=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ibdF5ZpWd1P2gEoVuM7jOd8bqNiwo2gcGgBmyz+vKdUJsymINE4wCmKsuXQ8iw5+H Y7JYy5vkYNLMBd3jCeYpA2snxviLYe/UM+1N4l5hmMQ5eHEdIVxQhAZzh5xO9x9Q1p fR1z8Sg//GwsJls2gffJW0VSEcih6eEibIP04Bek= To: Viacheslav Ovsiienko , dev@dpdk.org Cc: stable@dpdk.org References: <20210619154012.27295-1-viacheslavo@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <04b70a3a-6d79-6e25-27ee-a07cf4931ea1@oktetlabs.ru> Date: Thu, 1 Jul 2021 17:01:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210619154012.27295-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 6/19/21 6:40 PM, Viacheslav Ovsiienko wrote: > For the newly attached ports (with "port attach" command) the > default offloads settings, configured from application command > line, were not applied, causing port start failure following > the attach. For example, if scattering offload was configured > in command line and rxpkts was configured for multiple segments, > the newly attached port start was failed due to missing scattering > offload enable in the new port settings. The missing code to apply > the offloads to the new device and its queues is added. > > Cc: stable@dpdk.org > Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions") Two above lines should be swapped. > > Signed-off-by: Viacheslav Ovsiienko The patch duplicates too much from init_config() function. Please, factor out a helper function to do the job and use it in init_config() and reconfig().