From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Cheng Jiang <cheng1.jiang@intel.com>, Chenbo.Xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix async packed ring batch datapath
Date: Mon, 19 Jul 2021 11:07:42 +0200 [thread overview]
Message-ID: <04bbf1a8-793d-1cc0-d427-3bc885390e91@redhat.com> (raw)
In-Reply-To: <20210708102528.36581-1-cheng1.jiang@intel.com>
Hi,
On 7/8/21 12:25 PM, Cheng Jiang wrote:
> We assume that in the sync path, if there is no buffer wrap in the
> avail descriptors fetched in a batch, there is no buffer wrap in the
> used descriptors which need to be written back in this batch, but
> this assumption is wrong in the async path since there are inflight
> descriptors which are processed by the DMA device.
>
> This patch refactors the batch copy code and adds used ring buffer
> wrap check as a batch copy condition to fix this issue.
>
> Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath")
> Cc: stable@dpdk.org
>
> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> ---
> lib/vhost/virtio_net.c | 163 ++++++++++++++++++++++++++++++++---------
> 1 file changed, 128 insertions(+), 35 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2021-07-19 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 10:25 Cheng Jiang
2021-07-19 9:07 ` Maxime Coquelin [this message]
2021-07-20 2:46 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04bbf1a8-793d-1cc0-d427-3bc885390e91@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Chenbo.Xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=stable@dpdk.org \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).