From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>, dev@dpdk.org
Cc: stable@dpdk.org, arybchenko@solarflare.com, thomas@monjalon.net
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] ethdev: fix VLAN offloads set if no driver callback
Date: Fri, 17 Jan 2020 14:34:20 +0000 [thread overview]
Message-ID: <050e9407-87ab-1dfe-179f-88f7a13eeea7@intel.com> (raw)
In-Reply-To: <7ca8acf4-05d4-f0e8-4021-043261307b6c@intel.com>
On 1/17/2020 2:31 PM, Ferruh Yigit wrote:
> On 1/17/2020 11:49 AM, Wei Hu (Xavier) wrote:
>> From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
>>
>> Currently, there is a potential problem that changing the content of
>> dev->data->dev_conf.rxmode.offloads even when there is no vlan_offload_set
>> driver callback.
>>
>> It is a good idea that prevent the side effect and make the API return
>> success if no change requested. This patch fixes the problem, the detail
>> information as below:
>> - keep possibility to do dummy set even if there is no driver callback
>> - do not touch Rx mode offloads in device data before checking the driver
>> callback availability
>> - ensure that Rx mode offloads are rolled back correctly if driver
>> callback returns error
>>
>> Fixes: dfebfc9882fb ("ethdev: support dynamic configuration of QinQ strip")
>
> I think the problem (API modifying the device config even 'vlan_offload_set'
> dev_ops is not implemented) exists from the beginning.
>
> Fixes: 81f9db8ecc2c ("ethdev: add vlan offload support")
>
>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>> Signed-off-by: Min Wang (Jushui) <wangmin3@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-01-17 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 11:49 [dpdk-stable] " Wei Hu (Xavier)
2020-01-17 14:31 ` Ferruh Yigit
2020-01-17 14:34 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050e9407-87ab-1dfe-179f-88f7a13eeea7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=huwei013@chinasoftinc.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).