From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Yu Wenjun <yuwenjun0x@163.com>, "Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/ice: fix deadlock in ice_flow_query()
Date: Sun, 29 Aug 2021 13:06:04 +0000 [thread overview]
Message-ID: <051f8891567d42f78c3c042d776eb22c@intel.com> (raw)
In-Reply-To: <20210819121002.1433-1-yuwenjun0x@163.com>
> -----Original Message-----
> From: Yu Wenjun <yuwenjun0x@163.com>
> Sent: Thursday, August 19, 2021 8:10 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Yu Wenjun <yuwenjun0x@163.com>
> Subject: [PATCH] net/ice: fix deadlock in ice_flow_query()
>
> It will cause deadlock when use switch-default, so fix it
>
> Signed-off-by: Yu Wenjun<yuwenjun0x@163.com>
Fixes: 0d6ef740e411 ("net/ice: support flow ops thread safe")
Cc: stable@dpdk.org
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> ---
> drivers/net/ice/ice_generic_flow.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_generic_flow.c
> b/drivers/net/ice/ice_generic_flow.c
> index 66b5743abf..c2fa75f165 100644
> --- a/drivers/net/ice/ice_generic_flow.c
> +++ b/drivers/net/ice/ice_generic_flow.c
> @@ -2518,15 +2518,16 @@ ice_flow_query(struct rte_eth_dev *dev,
> ret = flow->engine->query_count(ad, flow, count, error);
> break;
> default:
> - return rte_flow_error_set(error, ENOTSUP,
> + ret = rte_flow_error_set(error, ENOTSUP,
> RTE_FLOW_ERROR_TYPE_ACTION,
> actions,
> "action not supported");
> + goto out;
> }
> }
>
> +out:
> rte_spinlock_unlock(&pf->flow_ops_lock);
> -
> return ret;
> }
>
> --
> 2.32.0.windows.1
>
prev parent reply other threads:[~2021-08-29 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 12:10 Yu Wenjun
2021-08-29 13:06 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=051f8891567d42f78c3c042d776eb22c@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yuwenjun0x@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).