From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35C81A046B for ; Sat, 9 May 2020 10:54:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 121141D91E; Sat, 9 May 2020 10:54:53 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E5EDF1D914; Sat, 9 May 2020 10:54:49 +0200 (CEST) IronPort-SDR: +5UNpTjBTvPsz4ixDT/24/CbscFmjBSgPX+FQzDYDv91shyCuOb82JEowGN0tOTZEHx6zTBY1T 2Ywx+yhh6u/Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2020 01:54:48 -0700 IronPort-SDR: 2ntJXev3b60P8GQQa4g1ZBjQc+6CbSrLbP1BulEfxar3iOg+veCLotuDru5h572gUP9VvaWDjp PyD93XmkG60A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,371,1583222400"; d="scan'208";a="297190570" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 09 May 2020 01:54:48 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 01:54:48 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 9 May 2020 01:54:48 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 9 May 2020 01:54:47 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.225]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.200]) with mapi id 14.03.0439.000; Sat, 9 May 2020 16:54:44 +0800 From: "Sun, GuinanX" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Zhang, Qi Z" , "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting Thread-Index: AQHV5g4SQCYyNSj5GkWMk/UwaDOS2Kif2TsQgAAYZ+A= Date: Sat, 9 May 2020 08:54:43 +0000 Message-ID: <05758BDAD7FC8E4BAED63D0390A8A955847ABE@SHSMSX101.ccr.corp.intel.com> References: <20191219044356.30762-1-guinanx.sun@intel.com> <20200218033931.81821-1-guinanx.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi ,zhaowei > -----Original Message----- > From: Zhao1, Wei > Sent: Saturday, May 9, 2020 3:35 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; Sun, GuinanX > ; stable@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting >=20 > Hi, guinan >=20 > In this patch, you have add a new parameter of mac_ctrl_frame_fwd, it sh= ould > not be clear in ixgbe_dev_stop(), Or it will be over write when do port r= eset, and > also you should add mac_ctrl_frame_fwd in ixgbe_flow_ctrl_get() for FC in= fo > get. > Although this patch has been merged, please commit fix patch for it, than= ks! >=20 For this question, I need to confirm the requirements with Konieczny Tomasz= X before I can decide whether to make changes. >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Guinan Sun > > Sent: Tuesday, February 18, 2020 11:40 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; Zhang, Qi Z ; Sun, > > GuinanX ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting > > > > When the port starts, the hw register is reset first, and then the > > required parameters are set again. > > If the parameters to be used are not set after resetting the register, > > a read register error will occur. This patch is used to fix the problem= . > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Guinan Sun > > --- > > v4: changes > > * rebase to dpdk-next-net-intel > > > > v3: changes > > * wrap duplication code into a function > > * Modify checkpatch warnings > > > > v2: changes > > * Modify the initial value of requested_mode and current_mode > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 76 > > +++++++++++++++++++++----------- drivers/net/ixgbe/ixgbe_ethdev.h | 1 > > + > > 2 files changed, 51 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 3aab24e82..08b4cc689 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +} > > + > > err =3D ixgbe_dev_rxtx_start(dev); > > if (err < 0) { > > PMD_INIT_LOG(ERR, "Unable to start rxtx queues"); @@ -2900,6 > > +2939,8 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) > > > > adapter->rss_reta_updated =3D 0; > > > > +adapter->mac_ctrl_frame_fwd =3D 0; > > + >=20 > Delete it please. >=20 >=20 >=20 >=20 >=20