From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAAE5A0351 for ; Sat, 9 May 2020 11:48:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F0C71D732; Sat, 9 May 2020 11:48:30 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 06B021D726; Sat, 9 May 2020 11:48:26 +0200 (CEST) IronPort-SDR: 8DSc08f038p93js2nt90LvC0QtW9Sb5m8wE8PtDeWBr9FEpAZMkzxuL97BvX9C39nAJCBkIFOJ 9+StEpabnwEw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2020 02:48:25 -0700 IronPort-SDR: Wjspx3DYYVBvpfq8I7odXlkKuxkR/tFejRD8vgV13pzrAJBCJV+HB3zDZiq+s51OOBo5mTdBp1 h0pWHSORx9Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,371,1583222400"; d="scan'208";a="296393300" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 09 May 2020 02:48:25 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 02:48:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 02:48:24 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.225]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.77]) with mapi id 14.03.0439.000; Sat, 9 May 2020 17:48:21 +0800 From: "Sun, GuinanX" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Zhang, Qi Z" , "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting Thread-Index: AQHV5g4SQCYyNSj5GkWMk/UwaDOS2Kif2TsQgAAYZ+CAAAi2kIAAB2Gg Date: Sat, 9 May 2020 09:48:20 +0000 Message-ID: <05758BDAD7FC8E4BAED63D0390A8A955847B29@SHSMSX101.ccr.corp.intel.com> References: <20191219044356.30762-1-guinanx.sun@intel.com> <20200218033931.81821-1-guinanx.sun@intel.com> <05758BDAD7FC8E4BAED63D0390A8A955847ABE@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, zhaowei > -----Original Message----- > From: Zhao1, Wei > Sent: Saturday, May 9, 2020 5:30 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; > stable@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting >=20 > Hi=1B$B!$=1B(Bguinan >=20 > More info for this problem: > If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port r= eset > process of " > 1. testpmd> start > 2. testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 3. testpmd> stop 4. tes= tpmd> > port stop 0 5. testpmd> port start 0 6. testpmd> start " > Then after this process, the mac_ctrl_frame_fwd has been change to "off",= so > we should delete " adapter->mac_ctrl_frame_fwd =3D 0;" from dev-stop. >=20 Thank you very much , I get it. > Another problem is "add mac_ctrl_frame_fwd in ixgbe_flow_ctrl_get() for F= C > info get", it is Independent on the above one. >=20 >=20 > > -----Original Message----- > > From: Sun, GuinanX > > Sent: Saturday, May 9, 2020 4:55 PM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; Zhang, Qi Z ; > > stable@dpdk.org; Guo, Jia > > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode > > setting > > > > Hi ,zhaowei > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Saturday, May 9, 2020 3:35 PM > > > To: Sun, GuinanX ; dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Yang, Qiming > > > ; Zhang, Qi Z ; Sun, > > > GuinanX ; stable@dpdk.org; Guo, Jia > > > > > > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode > > > setting > > > > > > Hi, guinan > > > > > > In this patch, you have add a new parameter of mac_ctrl_frame_fwd, > > > it should not be clear in ixgbe_dev_stop(), Or it will be over write > > > when do port reset, and also you should add mac_ctrl_frame_fwd in > > > ixgbe_flow_ctrl_get() for FC info get. > > > Although this patch has been merged, please commit fix patch for it, = thanks! > > > > > > > For this question, I need to confirm the requirements with Konieczny > > TomaszX before I can decide whether to make changes. > > > > > > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Guinan Sun > > > > Sent: Tuesday, February 18, 2020 11:40 AM > > > > To: dev@dpdk.org > > > > Cc: Lu, Wenzhuo ; Yang, Qiming > > > > ; Zhang, Qi Z ; Sun, > > > > GuinanX ; stable@dpdk.org > > > > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode > > > > setting > > > > > > > > When the port starts, the hw register is reset first, and then the > > > > required parameters are set again. > > > > If the parameters to be used are not set after resetting the > > > > register, a read register error will occur. This patch is used to > > > > fix the > > problem. > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Guinan Sun > > > > --- > > > > v4: changes > > > > * rebase to dpdk-next-net-intel > > > > > > > > v3: changes > > > > * wrap duplication code into a function > > > > * Modify checkpatch warnings > > > > > > > > v2: changes > > > > * Modify the initial value of requested_mode and current_mode > > > > --- > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 76 > > > > +++++++++++++++++++++----------- drivers/net/ixgbe/ixgbe_ethdev.h > > > > +++++++++++++++++++++| > > > > +++++++++++++++++++++1 > > > > + > > > > 2 files changed, 51 insertions(+), 26 deletions(-) > > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > > index 3aab24e82..08b4cc689 100644 > > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > > +} > > > > + > > > > err =3D ixgbe_dev_rxtx_start(dev); > > > > if (err < 0) { > > > > PMD_INIT_LOG(ERR, "Unable to start rxtx queues"); @@ -2900,6 > > > > +2939,8 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) > > > > > > > > adapter->rss_reta_updated =3D 0; > > > > > > > > +adapter->mac_ctrl_frame_fwd =3D 0; > > > > + > > > > > > Delete it please. > > > > > > > > > > > > > > > > > >=20