From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) by dpdk.org (Postfix) with ESMTP id 4410F2B9A for ; Thu, 17 Jan 2019 07:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vSKL7wRg8j9CgPTGqbKCPAAV5L2E9nFKrkV8hy5arO4=; b=m7rhsjbKrcdJyJBUABfBHQQD5c/Wj1AAWpCzY4izjY4RhhJK6d3gXMLJdjpOqr71QdtQTHmmeAWGnN1cWU9hfjQbqDHdATEh700QBXP9KCEncyF6ZN+EnYwbr8+Go0qkr3ur/ID6qPfRQ74BlAJpgeolja9q6DTEC1YPKXEGYBE= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4059.eurprd05.prod.outlook.com (52.134.66.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.27; Thu, 17 Jan 2019 06:57:37 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c%2]) with mapi id 15.20.1537.018; Thu, 17 Jan 2019 06:57:37 +0000 From: Yongseok Koh To: Nikhil Rao CC: dpdk stable Thread-Topic: [PATCH 17.11] eventdev: fix unlock in Rx adapter Thread-Index: AQHUriK7r8Eygf5Y3UO7rV/BXTmqWKWzB5SA Date: Thu, 17 Jan 2019 06:57:37 +0000 Message-ID: <07A53DEF-81A4-4C62-8805-2364732CD58D@mellanox.com> References: <1547700431-145205-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1547700431-145205-1-git-send-email-nikhil.rao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4059; 6:oz/RqFdtUuo6KsyJzJKq5NRC1UiuVIPoj2r/8VItOpwG1iky5Fq/3lZvtpCtMpou9R671xaGg1Scgnb2BSP2T54t5y6+Y8NyLW9O3JKo6tbv6nV7R8xSEdmulmxsnomAhcqYUiYI2oXTKlRcsrMw+hVRBVsPtNfNmbBcQjoHQE/WXUvd4x2azReJBifzBtBMCHpBwuKLHsjv706raQ6zeSoYVDyTxF17pyji7ZcMwq6dH/d6I4Y7larFw3I00UhM59sDT877iFGk6rCGqHHgLMPCfRuWOgbf+7ny2v8oLrSxbEHNQAFDxppu4FWb/HbMmy4AW94fzY9TPGv4bYhoUB0n49u8Lu8uZqLt49ycDATAxwYbO1pQ+Bpzh+xjzYGiN8re9U4xPqWzNmokWHoEJNPtS9nOzGO0aT4X/ug82reAfMyrELiGf8CSh6mY3ba9lfrQN1Rso66P+Rip9F/vdw==; 5:qVv9DJewm86wtI+TI8M98JtYt14WStqumbhZKTSTmVaCtPhmutJvIsSJITSN0S3DR2JhVRLQPa8m+9kKHLK3reyCBDPHPamaYztx6kqHTN88kVt6JNuYjTsd4DfjXvdhK9+Geluwob4E9xiOwuvBWCaE2xf2WOvr5wDwKnHIgYiVaMaq2ydOHeVqWoZT34vwQggAn1xhLe/CQ50ycH1nvA==; 7:cK064uCwxaRffKKiv8bfzTu5eSrhTKj516eKDVV75VQZNaA0n/Yr9FBH39B/NBsJJUzIBA6tJjcM6oXHOtiQCO2MKReZ7ctkOq3EN48NRBs8R97Ysy4YMglwWiRo6Xbd3uBYmZjryhN19SvMsLcVhg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: df5aade5-4643-4e77-f6cf-08d67c4910f1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4059; x-ms-traffictypediagnostic: DB3PR0502MB4059: x-microsoft-antispam-prvs: x-forefront-prvs: 0920602B08 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(136003)(199004)(189003)(229853002)(99286004)(8936002)(316002)(83716004)(6436002)(6486002)(71200400001)(33656002)(71190400001)(14454004)(446003)(11346002)(486006)(476003)(2616005)(76176011)(26005)(186003)(6506007)(102836004)(53546011)(6246003)(305945005)(53936002)(8676002)(81156014)(81166006)(7736002)(6512007)(25786009)(82746002)(478600001)(66066001)(14444005)(4326008)(256004)(105586002)(106356001)(36756003)(2906002)(86362001)(68736007)(3846002)(6116002)(5660300001)(97736004)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4059; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gQ5DLhMDJavbQs7l6MQJ9W/Y++MuQX2WnkjYOKWIJPT/ppppp9ysOuKTcMd/iD3Np174DlcRBsHdUryzLaVKcprcQYXVoCtwW9Ptb36iN/XHpv/flFozrrxhRGgK3sW+uTsywMVfwZ50qYufyzVXAjqlxOXViH8sA8DOwc9MAb0G7amyUrujtAvgONzDi4/BKj0/iSNSf/9kxxo+KTDH6+m257CSNFXdbPtWaxEFKucg56fAC9Knfldeecrk9AcUUOCwNulv3hunWJNsH4qaMigr+Z28sonBnwTYZJxvhqvEfM7Kj12SqIQCxI/vhOcnKWlFIMAVqL8f5U1XqVIxPh1vB2ueZgiQgSNuVHZE5LK03dQmie0iJmLHFjdHDcQCPwFamkYlLR54p7VgVNOPO4b6/lbRpeXv5NqqzdaHvMQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <7727DD015ADEC64D90A21A22AC797636@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: df5aade5-4643-4e77-f6cf-08d67c4910f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 06:57:37.7082 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4059 Subject: Re: [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 06:57:39 -0000 > On Jan 16, 2019, at 8:47 PM, Nikhil Rao wrote: >=20 > [ backported from upstream commit e846cfdec34cc58b9a1a2438d313028246b8e98= 6 ] >=20 > In the eth Rx adapter SW service function, > move the return to after the spinlock unlock. >=20 > Coverity issue: 302857 > Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Nikhil Rao > Acked-by: Jerin Jacob > --- Applied to stable/17.11 Thanks, Yongseok > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_= eventdev/rte_event_eth_rx_adapter.c > index d5c3fd5..de4cf73 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -545,8 +545,8 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b) > if (rte_spinlock_trylock(&rx_adapter->rx_lock) =3D=3D 0) > return 0; > if (!rx_adapter->rxa_started) { > - return 0; > rte_spinlock_unlock(&rx_adapter->rx_lock); > + return 0; > } > eth_rx_poll(rx_adapter); > rte_spinlock_unlock(&rx_adapter->rx_lock); > --=20 > 1.8.3.1 >=20