* [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter
@ 2019-01-17 4:47 Nikhil Rao
2019-01-17 6:57 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Rao @ 2019-01-17 4:47 UTC (permalink / raw)
To: yskoh; +Cc: Nikhil Rao, stable
[ backported from upstream commit e846cfdec34cc58b9a1a2438d313028246b8e986 ]
In the eth Rx adapter SW service function,
move the return to after the spinlock unlock.
Coverity issue: 302857
Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index d5c3fd5..de4cf73 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -545,8 +545,8 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0)
return 0;
if (!rx_adapter->rxa_started) {
- return 0;
rte_spinlock_unlock(&rx_adapter->rx_lock);
+ return 0;
}
eth_rx_poll(rx_adapter);
rte_spinlock_unlock(&rx_adapter->rx_lock);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter
2019-01-17 4:47 [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter Nikhil Rao
@ 2019-01-17 6:57 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2019-01-17 6:57 UTC (permalink / raw)
To: Nikhil Rao; +Cc: dpdk stable
> On Jan 16, 2019, at 8:47 PM, Nikhil Rao <nikhil.rao@intel.com> wrote:
>
> [ backported from upstream commit e846cfdec34cc58b9a1a2438d313028246b8e986 ]
>
> In the eth Rx adapter SW service function,
> move the return to after the spinlock unlock.
>
> Coverity issue: 302857
> Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
Applied to stable/17.11
Thanks,
Yongseok
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index d5c3fd5..de4cf73 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -545,8 +545,8 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
> if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0)
> return 0;
> if (!rx_adapter->rxa_started) {
> - return 0;
> rte_spinlock_unlock(&rx_adapter->rx_lock);
> + return 0;
> }
> eth_rx_poll(rx_adapter);
> rte_spinlock_unlock(&rx_adapter->rx_lock);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-17 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 4:47 [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter Nikhil Rao
2019-01-17 6:57 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).