patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol"
@ 2020-02-28 18:20 luca.boccassi
  2020-02-28 18:33 ` Kevin Traynor
  2020-03-02 10:23 ` David Marchand
  0 siblings, 2 replies; 4+ messages in thread
From: luca.boccassi @ 2020-02-28 18:20 UTC (permalink / raw)
  To: stable

From: Luca Boccassi <luca.boccassi@microsoft.com>

This reverts commit bd979fff652326e042c21aaaf3df1f515ffdff6e.

It changed the public symbol version from @Base to @DPDK_18.05,
breaking ABI compatibility.

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
 drivers/common/octeontx/rte_common_octeontx_version.map | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map
index a9b3cff9bc..f04b3b7f8a 100644
--- a/drivers/common/octeontx/rte_common_octeontx_version.map
+++ b/drivers/common/octeontx/rte_common_octeontx_version.map
@@ -1,7 +1,6 @@
 DPDK_18.05 {
 	global:
 
-	octeontx_logtype_mbox;
 	octeontx_mbox_set_ram_mbox_base;
 	octeontx_mbox_set_reg;
 	octeontx_mbox_send;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol"
  2020-02-28 18:20 [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol" luca.boccassi
@ 2020-02-28 18:33 ` Kevin Traynor
  2020-03-02 10:23 ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2020-02-28 18:33 UTC (permalink / raw)
  To: luca.boccassi, stable

On 28/02/2020 18:20, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> This reverts commit bd979fff652326e042c21aaaf3df1f515ffdff6e.
> 
> It changed the public symbol version from @Base to @DPDK_18.05,
> breaking ABI compatibility.
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>  drivers/common/octeontx/rte_common_octeontx_version.map | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map
> index a9b3cff9bc..f04b3b7f8a 100644
> --- a/drivers/common/octeontx/rte_common_octeontx_version.map
> +++ b/drivers/common/octeontx/rte_common_octeontx_version.map
> @@ -1,7 +1,6 @@
>  DPDK_18.05 {
>  	global:
>  
> -	octeontx_logtype_mbox;
>  	octeontx_mbox_set_ram_mbox_base;
>  	octeontx_mbox_set_reg;
>  	octeontx_mbox_send;
> 

Applied, thanks :(


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol"
  2020-02-28 18:20 [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol" luca.boccassi
  2020-02-28 18:33 ` Kevin Traynor
@ 2020-03-02 10:23 ` David Marchand
  2020-03-02 10:45   ` Luca Boccassi
  1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2020-03-02 10:23 UTC (permalink / raw)
  To: Luca Boccassi; +Cc: dpdk stable, Kevin Traynor

On Fri, Feb 28, 2020 at 7:20 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> This reverts commit bd979fff652326e042c21aaaf3df1f515ffdff6e.
>
> It changed the public symbol version from @Base to @DPDK_18.05,
> breaking ABI compatibility.

This symbol is exported through private macro logs used by octeontx drivers.
The drivers are all built at once and released together.

The symbol is not exported in a public header.
This is not an application ABI breakage.

>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
>  drivers/common/octeontx/rte_common_octeontx_version.map | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map
> index a9b3cff9bc..f04b3b7f8a 100644
> --- a/drivers/common/octeontx/rte_common_octeontx_version.map
> +++ b/drivers/common/octeontx/rte_common_octeontx_version.map
> @@ -1,7 +1,6 @@
>  DPDK_18.05 {
>         global:
>
> -       octeontx_logtype_mbox;
>         octeontx_mbox_set_ram_mbox_base;
>         octeontx_mbox_set_reg;
>         octeontx_mbox_send;
> --
> 2.20.1
>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol"
  2020-03-02 10:23 ` David Marchand
@ 2020-03-02 10:45   ` Luca Boccassi
  0 siblings, 0 replies; 4+ messages in thread
From: Luca Boccassi @ 2020-03-02 10:45 UTC (permalink / raw)
  To: David Marchand; +Cc: dpdk stable, Kevin Traynor

On Mon, 2020-03-02 at 11:23 +0100, David Marchand wrote:
> On Fri, Feb 28, 2020 at 7:20 PM <
> luca.boccassi@gmail.com
> > wrote:
> > From: Luca Boccassi <
> > luca.boccassi@microsoft.com
> > >
> > 
> > This reverts commit bd979fff652326e042c21aaaf3df1f515ffdff6e.
> > 
> > It changed the public symbol version from @Base to @DPDK_18.05,
> > breaking ABI compatibility.
> 
> This symbol is exported through private macro logs used by octeontx
> drivers.
> The drivers are all built at once and released together.
> 
> The symbol is not exported in a public header.
> This is not an application ABI breakage.

It is part of the list of public symbols exposed by the shared object.
Whether it is used or not, as a matter of policy, I cannot upload a new
LTS release to Debian/Ubuntu if it removes/changes a public symbol.

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-02 10:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 18:20 [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol" luca.boccassi
2020-02-28 18:33 ` Kevin Traynor
2020-03-02 10:23 ` David Marchand
2020-03-02 10:45   ` Luca Boccassi

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git