From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 860DDA0567 for ; Tue, 10 Mar 2020 16:31:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AAB41BFFD; Tue, 10 Mar 2020 16:31:07 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 603CB1BFF5; Tue, 10 Mar 2020 16:31:05 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id a5so1900583wmb.0; Tue, 10 Mar 2020 08:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IeGkjHo/grRJ1c5ri+d8L/Hohr8DskYaLnGL4KiHw7w=; b=Qdl8tAgQIvnteb1O9Mb6NOiUxH0qvyJQZT3fZeCuGbh7n1a4QqfcLYxBTDtgOvF9Xb FpYzmu5hQgirXjFJfn07HPUNfiCvccCnPgGcUbryuZ+bzjCwzIl2yM2F5KUNFlNGIxgb vVVcNruTpHB5MHZREsKLw2mbYXZaCoVf/6VIx3xho5al3wpTd8HO4TF/5eS6o9z1Sn1z IubY3lQqmnU7JgtVUmm1FU7Tls3v4oLddaeXq/vFglzVqFUrenSMu23i+nH9cQ6l4FcZ Lo2janRCtZFyVy3twtykzy1UpyQsgcFfvhNLMA1SyoJ0N5VnXj3hN85Vy8haeMs+wxX8 7Ebg== X-Gm-Message-State: ANhLgQ0vcCWZ4MsbV+IgsSpkVnlpOXVQvy5C74vbt5Ba81YG/JfoteQl RoqMRTBoYhAYIYZ5w82ASOk= X-Google-Smtp-Source: ADFU+vuIddCYd42jcqkNSvrca3vY5D0NSuo4JiYC6p+Vw3Q2YTjFJG6YP9UkUAkHlNIBr/HSwCdFgA== X-Received: by 2002:a1c:2701:: with SMTP id n1mr2705511wmn.180.1583854265012; Tue, 10 Mar 2020 08:31:05 -0700 (PDT) Received: from [192.168.1.88] (host204-61-dynamic.23-79-r.retail.telecomitalia.it. [79.23.61.204]) by smtp.gmail.com with ESMTPSA id q13sm15268934wrs.91.2020.03.10.08.31.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2020 08:31:04 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) From: Alfredo Cardigliano In-Reply-To: <7305ce1e-026a-3654-5f1a-8c5d85e1cf07@intel.com> Date: Tue, 10 Mar 2020 16:31:02 +0100 Cc: Sunil Kumar Kori , dev@dpdk.org, stable@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <0809A9C0-612D-4366-9F11-D1917F744F78@ntop.org> References: <20200309075328.23351-1-skori@marvell.com> <20200309090927.24206-1-skori@marvell.com> <7305ce1e-026a-3654-5f1a-8c5d85e1cf07@intel.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3608.60.0.2.5) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > On 10 Mar 2020, at 16:21, Ferruh Yigit wrote: >=20 > On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote: >> Any DPDK public header file which includes stdbool.h may conflict = with >> local definition of bool, if any, which further results in = compilation >> error. To avoid, used standard stdbool.h instead of defining bool >> internally. >>=20 >> I observed this issue during a development where I included = rte_uuid.h >> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it = started >> throwing error as given below: >>=20 >> CC ionic_rxtx.o >> In file included from .../dpdk/build/include/rte_uuid.h:17:0, >> from .../dpdk/build/include/rte_ethdev.h:161, >> from .../dpdk/build/include/rte_ethdev_driver.h:18, >> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34: >> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more = data types in declaration specifiers >> typedef uint8_t bool; >> ^ >> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0, >> from .../dpdk/drivers/net/ionic/ionic.h:13, >> from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8, >> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45: >> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type = name in empty declaration >> typedef uint8_t bool; >> ^~~~~~~ >> cc1: warning: unrecognized command line option = =E2=80=98-Wno-address-of-packed-member=E2=80=99 >> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target = 'ionic_rxtx.o' failed >>=20 >> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter") >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Sunil Kumar Kori >=20 > Hi Alfredo, >=20 > Do you have any concern/objection on the patch? If not it will be = merged soon. >=20 > Thanks, > ferruh >=20 Hi Ferruh it looks fine, please go ahead. Thank you Alfredo=