From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D7E1A04E6 for ; Fri, 20 Nov 2020 18:41:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3228BC8B0; Fri, 20 Nov 2020 18:40:59 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2044.outbound.protection.outlook.com [40.107.236.44]) by dpdk.org (Postfix) with ESMTP id 7FF56DED; Fri, 20 Nov 2020 18:40:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QN594kAaY7ag74o+ghwjB4G0B5wnUjak2aTgCG/PUtB+j7emOKk60Pclq9I/FIVhFYcJIoeF5cDfVu9YmcVcC81OwMfLfQv493RZFmmGVide+R+OS2JAp9Erw7rF9gEZL7hb3MKbrOuhBnb4O4PIPTiSTRhWvFBpCJHri6s/jmapGKwxN0jrO4kL7WQ1fJapwofDi1H0u0YXwlCsrerFNj4Y9TiMgXAFizxjtOUg6FpgYU95LHOr3bms1EIPFYFvnxxmh7IYKZdNQ2Ads6t3PzZTN73yWhNT9KEijR+a+ltUYlIX3GyF+rT7ggX9MaNrjjQ30rdFthi6hiStFiKXlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDjENzNZktpZ+kpTJ+nt3LfjUCxyUgaD7mT5XlUJCOg=; b=AZVRLMG9jR+4EGq/wL9VdjJ2tXqbIPOuEFmdaGBTpgybJ350lO9lbFuAkCT7gXcciBCC8Net1MvSBzxYRFVdZ/sIStyYz6a2f6PxB5vtkjS9oNmJ5pDVCUfQqFuyN6++b6ZbOB6qt2LoEKc9TKXv3jaX6PFsCbP9qW7X6Hg6bL8Kgdnz41g8qwpusyctqkPyY7jHmZcwR9ofU2QWLgxzn5tn/VspNXfkN4sfCPPU+edxRhSzx2hBteY3Q1vob4VlmPkWpRiZPBt/yxas5gzBIXMEnsC9ZySk4nmAPAs2o23Ep82zoH22SRFm+xYsgYucOzg0Uv6Hsbvh0KIhSjbjpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDjENzNZktpZ+kpTJ+nt3LfjUCxyUgaD7mT5XlUJCOg=; b=f+AYf5BD7OnFZNQ7QT8H3Qq4bfyb6XNxCtwsZltsctotYKUqPRS0lQr1ChkwjTTNsL2OmV+urIHSt3bM4Mr6D3RxxQZ2ThbTi7gQLQSEVObiYz16fFZcvR4D6GIBOIv7UGsT9etM+CWBxQky0JsL3sWjjzquTufV+A/CGiZXHoA= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=windriver.com; Received: from DM6PR11MB4330.namprd11.prod.outlook.com (2603:10b6:5:1dc::30) by DM6PR11MB2699.namprd11.prod.outlook.com (2603:10b6:5:ce::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 20 Nov 2020 17:40:53 +0000 Received: from DM6PR11MB4330.namprd11.prod.outlook.com ([fe80::31e4:b0f1:f438:4bc1]) by DM6PR11MB4330.namprd11.prod.outlook.com ([fe80::31e4:b0f1:f438:4bc1%6]) with mapi id 15.20.3564.028; Fri, 20 Nov 2020 17:40:52 +0000 To: Ferruh Yigit , dev@dpdk.org, Matt Peters , Vincent Jardin , Allain Legacy Cc: stable@dpdk.org References: <20200824094021.2323605-1-ferruh.yigit@intel.com> <20201119115900.4095566-1-ferruh.yigit@intel.com> <20201119115900.4095566-11-ferruh.yigit@intel.com> From: Steven Webster Message-ID: <082a2601-8a65-1e77-bbb9-714ce45419a0@windriver.com> Date: Fri, 20 Nov 2020 12:40:49 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 In-Reply-To: <20201119115900.4095566-11-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [174.112.227.107] X-ClientProxiedBy: YTBPR01CA0014.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::27) To DM6PR11MB4330.namprd11.prod.outlook.com (2603:10b6:5:1dc::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.11] (174.112.227.107) by YTBPR01CA0014.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Fri, 20 Nov 2020 17:40:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d77ed77e-3506-4dca-1641-08d88d7b6d12 X-MS-TrafficTypeDiagnostic: DM6PR11MB2699: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N2A6uCIBuRo/RnX9omyGy0uo1+ifQPsBBDxUzQfKT1tKPJzTp8qCMdUvmGiXxip0oL+CnFDnZYElQDGPPIzM+s2V6vkogj2u3B4KgIcVpxzjJ9SJ9qbrTouNJBzP9ZhqKp5IZ5N/SM91QjfLGWuwBosvj71Mcyz0cBbfpSH0/dTN7YlG1RJVzmKcHC43yYGA/x19BKUQTq5uCqT8vFU7Ic+NzvMRPcWzt7prmQFyaAgDWcEyDpaIk/MZgLvokKklhRozuHlavaTdiCzT5DI7FwHJtY11U/0cxTlWTPmk8ZIUfEdYJVAO8AOck7jxj7jg2OVkYCHL5J/A61BpAsb4aw1yhf4WNAFqfgGUtRDAhS8UPBfHbB6kxbFSHG/VFeYB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4330.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39850400004)(396003)(346002)(136003)(6486002)(83380400001)(6636002)(53546011)(52116002)(66556008)(66476007)(86362001)(66946007)(36756003)(2906002)(5660300002)(478600001)(316002)(8676002)(16526019)(8936002)(2616005)(110136005)(4326008)(956004)(16576012)(4001150100001)(26005)(31686004)(31696002)(44832011)(4744005)(186003)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 2nTeqEaxm3TYCd05NNmzYUU2VvmSjyt5JyaPmwTAnUMY6WR2um/nbPj2CgwsqN7ZrWn1wweBhuzejdG0EpNsnGQDTzb65vWQ11Hcg3vDla0xvFxsoaiUevq7NJyJ6guambeUGyfOQbt4uNYSd01nwAEEOLef+QcES+vx4PbGt9WScXarcjFRF5rG/5vpeiUThFsBG2RftNCKu436C+PyilxXeO74cvNkB83NoAJZu5PKrWfMmLwSvIIQZYVUi4M4qG5CDMRotfFScmazS6lNcdyIFczmoFN9/DI+pE6+p0Rarfv6ya9P5ZvREqfK+DTYNCyAen3cc0b65CuyBZmamd1iydbAoeZg6Uj2/vYMwQcZKDCHfVDmWVCJcMcf56jGa2F2wNzPB4Jp9gTsWV10oE3d6uDuMY9NYJvzUQEe9TJ8dNgMqz4dohFTKjOq+lkyl6Yfv1JLN9zBFpEToRKxZ+MF2Bz+UEpMpWjzGp687cHLEAfFID1d56K/kkN5mxTxb4o3AfMdtqug9jvXbksR/h6lmNfsO4Mdk3rhmyBh+m3GFUg/L5lYpiaXN7GuIpCjoA2pZnLrRtq67niXNPAryiEVZqELsGFF5LRNv8eDPutcxSJ0qopEUR2zM6lkPOVcwX7hrE4oZy3UW+7Qc9uh+w== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: d77ed77e-3506-4dca-1641-08d88d7b6d12 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4330.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2020 17:40:52.8997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Hx9k+Pj57fFr6iT81arYXM5czkyKI8ot+9Mt4qNX64jxGJ2EiSNKybfBaNB7Iry+QXHm2lGvVLdLujggZt7tL6n5wrHbfPBvmWKwIeCe4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2699 Subject: Re: [dpdk-stable] [v21.02 v3 10/10] net/avp: remove always true condition X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 2020-11-19 6:59 a.m., Ferruh Yigit wrote: > There is already a break above for the case "count >= 1", so at this > stage 'count' should be always '0'. > > Fixes: 1a85922369c4 ("net/avp: add device configuration") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > drivers/net/avp/avp_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c > index 5f8187b905..f531e03c02 100644 > --- a/drivers/net/avp/avp_ethdev.c > +++ b/drivers/net/avp/avp_ethdev.c > @@ -267,7 +267,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) > break; > } > > - if ((count < 1) && (retry == 0)) { > + if (retry == 0) { > PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n", > request->req_id); > ret = -ETIME; > -- > 2.26.2 > Acked-by: Steven Webster