* [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses
@ 2020-09-18 18:53 Long Li
2020-09-21 13:50 ` Ferruh Yigit
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Long Li @ 2020-09-18 18:53 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Long Li, stable
From: Long Li <longli@microsoft.com>
The address should be calculated before type cast, not after.
Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
Cc: stable@dpdk.org
Reported-by: Souvik Dey <sodey@rbbn.com>
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 813f8c3cc..70f8b8332 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
txd->queue_id = txq->queue_id;
txd->chim_index = NVS_CHIM_IDX_INVALID;
- txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
- + idx * HN_RNDIS_PKT_ALIGNED;
+ txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
+ + idx * HN_RNDIS_PKT_ALIGNED);
}
int
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-18 18:53 [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses Long Li
@ 2020-09-21 13:50 ` Ferruh Yigit
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-09-24 10:03 ` [dpdk-stable] " Kevin Traynor
2 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:50 UTC (permalink / raw)
To: Long Li, Stephen Hemminger; +Cc: dev, Long Li, stable
On 9/18/2020 7:53 PM, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> The address should be calculated before type cast, not after.
>
> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
> Cc: stable@dpdk.org
>
> Reported-by: Souvik Dey <sodey@rbbn.com>
> Signed-off-by: Long Li <longli@microsoft.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-18 18:53 [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses Long Li
2020-09-21 13:50 ` Ferruh Yigit
@ 2020-09-21 16:04 ` Kevin Traynor
2020-09-21 16:06 ` Kevin Traynor
2020-09-21 16:19 ` Kevin Traynor
2020-09-24 10:03 ` [dpdk-stable] " Kevin Traynor
2 siblings, 2 replies; 7+ messages in thread
From: Kevin Traynor @ 2020-09-21 16:04 UTC (permalink / raw)
To: Long Li, Stephen Hemminger
Cc: dev, Long Li, stable, Souvik Dey <sodey, Ferruh Yigit
On 18/09/2020 19:53, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> The address should be calculated before type cast, not after.
>
This is being requested for 18.11.10 as it is fixing a reported
regression introduced in 18.11.9.
If netvsc maintainers agree and it is merged in DPDK mainline this week,
I can take it into 18.11.10, otherwise it will be for 18.11.11.
Souvik, maybe you can give tested-by tags?
> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
> Cc: stable@dpdk.org
>
> Reported-by: Souvik Dey <sodey@rbbn.com>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/hn_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
> index 813f8c3cc..70f8b8332 100644
> --- a/drivers/net/netvsc/hn_rxtx.c
> +++ b/drivers/net/netvsc/hn_rxtx.c
> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>
> txd->queue_id = txq->queue_id;
> txd->chim_index = NVS_CHIM_IDX_INVALID;
> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
> - + idx * HN_RNDIS_PKT_ALIGNED;
> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
> + + idx * HN_RNDIS_PKT_ALIGNED);
> }
>
> int
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
@ 2020-09-21 16:06 ` Kevin Traynor
2020-09-21 16:19 ` Kevin Traynor
1 sibling, 0 replies; 7+ messages in thread
From: Kevin Traynor @ 2020-09-21 16:06 UTC (permalink / raw)
To: Long Li, Stephen Hemminger; +Cc: dev, Long Li, stable, Souvik Dey, Ferruh Yigit
+fixed Souvik email
On 21/09/2020 17:04, Kevin Traynor wrote:
> On 18/09/2020 19:53, Long Li wrote:
>> From: Long Li <longli@microsoft.com>
>>
>> The address should be calculated before type cast, not after.
>>
>
> This is being requested for 18.11.10 as it is fixing a reported
> regression introduced in 18.11.9.
>
> If netvsc maintainers agree and it is merged in DPDK mainline this week,
> I can take it into 18.11.10, otherwise it will be for 18.11.11.
>
> Souvik, maybe you can give tested-by tags?
>
>> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Souvik Dey <sodey@rbbn.com>
>> Signed-off-by: Long Li <longli@microsoft.com>
>> ---
>> drivers/net/netvsc/hn_rxtx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
>> index 813f8c3cc..70f8b8332 100644
>> --- a/drivers/net/netvsc/hn_rxtx.c
>> +++ b/drivers/net/netvsc/hn_rxtx.c
>> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>>
>> txd->queue_id = txq->queue_id;
>> txd->chim_index = NVS_CHIM_IDX_INVALID;
>> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
>> - + idx * HN_RNDIS_PKT_ALIGNED;
>> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
>> + + idx * HN_RNDIS_PKT_ALIGNED);
>> }
>>
>> int
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-09-21 16:06 ` Kevin Traynor
@ 2020-09-21 16:19 ` Kevin Traynor
2020-09-21 19:09 ` Long Li
1 sibling, 1 reply; 7+ messages in thread
From: Kevin Traynor @ 2020-09-21 16:19 UTC (permalink / raw)
To: Long Li, Stephen Hemminger; +Cc: dev, Long Li, stable, Souvik Dey, Ferruh Yigit
On 21/09/2020 17:04, Kevin Traynor wrote:
> On 18/09/2020 19:53, Long Li wrote:
>> From: Long Li <longli@microsoft.com>
>>
>> The address should be calculated before type cast, not after.
>>
>
> This is being requested for 18.11.10 as it is fixing a reported
> regression introduced in 18.11.9.
>
> If netvsc maintainers agree and it is merged in DPDK mainline this week,
> I can take it into 18.11.10, otherwise it will be for 18.11.11.
>
> Souvik, maybe you can give tested-by tags?
>
Ah, already applied to next-net, Ferruh is fast.
Stephen/Long - I will assume you ack this for 18.11.10 (normally it
would be 18.11.11 after 20.11 release). Please let me know if any doubt.
>> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Souvik Dey <sodey@rbbn.com>
>> Signed-off-by: Long Li <longli@microsoft.com>
>> ---
>> drivers/net/netvsc/hn_rxtx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
>> index 813f8c3cc..70f8b8332 100644
>> --- a/drivers/net/netvsc/hn_rxtx.c
>> +++ b/drivers/net/netvsc/hn_rxtx.c
>> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>>
>> txd->queue_id = txq->queue_id;
>> txd->chim_index = NVS_CHIM_IDX_INVALID;
>> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
>> - + idx * HN_RNDIS_PKT_ALIGNED;
>> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
>> + + idx * HN_RNDIS_PKT_ALIGNED);
>> }
>>
>> int
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-21 16:19 ` Kevin Traynor
@ 2020-09-21 19:09 ` Long Li
0 siblings, 0 replies; 7+ messages in thread
From: Long Li @ 2020-09-21 19:09 UTC (permalink / raw)
To: Kevin Traynor, Long Li, Stephen Hemminger
Cc: dev, stable, Souvik Dey, Ferruh Yigit
>On 21/09/2020 17:04, Kevin Traynor wrote:
>> On 18/09/2020 19:53, Long Li wrote:
>>> From: Long Li <longli@microsoft.com>
>>>
>>> The address should be calculated before type cast, not after.
>>>
>>
>> This is being requested for 18.11.10 as it is fixing a reported
>> regression introduced in 18.11.9.
>>
>> If netvsc maintainers agree and it is merged in DPDK mainline this
>> week, I can take it into 18.11.10, otherwise it will be for 18.11.11.
>>
>> Souvik, maybe you can give tested-by tags?
>>
>
>Ah, already applied to next-net, Ferruh is fast.
>
>Stephen/Long - I will assume you ack this for 18.11.10 (normally it would be
>18.11.11 after 20.11 release). Please let me know if any doubt.
Yes, please get this patch in 18.11.10.
>
>>> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
>>> Cc: stable@dpdk.org
>>>
>>> Reported-by: Souvik Dey <sodey@rbbn.com>
>>> Signed-off-by: Long Li <longli@microsoft.com>
>>> ---
>>> drivers/net/netvsc/hn_rxtx.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/netvsc/hn_rxtx.c
>>> b/drivers/net/netvsc/hn_rxtx.c index 813f8c3cc..70f8b8332 100644
>>> --- a/drivers/net/netvsc/hn_rxtx.c
>>> +++ b/drivers/net/netvsc/hn_rxtx.c
>>> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp
>>> __rte_unused,
>>>
>>> txd->queue_id = txq->queue_id;
>>> txd->chim_index = NVS_CHIM_IDX_INVALID;
>>> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
>>> - + idx * HN_RNDIS_PKT_ALIGNED;
>>> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
>>> + + idx * HN_RNDIS_PKT_ALIGNED);
>>> }
>>>
>>> int
>>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses
2020-09-18 18:53 [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses Long Li
2020-09-21 13:50 ` Ferruh Yigit
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
@ 2020-09-24 10:03 ` Kevin Traynor
2 siblings, 0 replies; 7+ messages in thread
From: Kevin Traynor @ 2020-09-24 10:03 UTC (permalink / raw)
To: Long Li, Stephen Hemminger; +Cc: Dey, Souvik, Long Li, stable
On 18/09/2020 19:53, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> The address should be calculated before type cast, not after.
>
> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
> Cc: stable@dpdk.org
>
> Reported-by: Souvik Dey <sodey@rbbn.com>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/hn_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
> index 813f8c3cc..70f8b8332 100644
> --- a/drivers/net/netvsc/hn_rxtx.c
> +++ b/drivers/net/netvsc/hn_rxtx.c
> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>
> txd->queue_id = txq->queue_id;
> txd->chim_index = NVS_CHIM_IDX_INVALID;
> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
> - + idx * HN_RNDIS_PKT_ALIGNED;
> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
> + + idx * HN_RNDIS_PKT_ALIGNED);
> }
>
> int
>
Applied to 18.11 branch (to be part of 18.11.10), Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-09-24 10:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 18:53 [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses Long Li
2020-09-21 13:50 ` Ferruh Yigit
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-09-21 16:06 ` Kevin Traynor
2020-09-21 16:19 ` Kevin Traynor
2020-09-21 19:09 ` Long Li
2020-09-24 10:03 ` [dpdk-stable] " Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).