patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: stable@dpdk.org, Yuanhan Liu <yliu@fridaylinux.org>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
	"Yongseok Koh" <yskoh@mellanox.com>
Subject: [dpdk-stable] [PATCH 3/3] net/mlx5: fix flow priority on queue action
Date: Tue, 27 Feb 2018 10:36:45 +0100	[thread overview]
Message-ID: <097114bc2ce60833804089c85fc684dce667eb66.1519724131.git.nelio.laranjeiro@6wind.com> (raw)
In-Reply-To: <7b8e3cb89da9d10b3afffa2c297a417c59c6d82b.1519724131.git.nelio.laranjeiro@6wind.com>
In-Reply-To: <20180207093155.GA31542@yliu-mob>

From: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>

[ backported from upstream commit c3299d76867f23e595d8e1b3e6b9ad4d6aa87155 ]

A single queue should have the same verbs priority as an RSS one.

Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Cc: stable@dpdk.org

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index bc2bba21b..092644ff1 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -865,7 +865,7 @@ priv_flow_convert_items_validate(struct priv *priv,
 			}
 			parser->inner = IBV_FLOW_SPEC_INNER;
 		}
-		if (parser->drop || parser->queues_n == 1) {
+		if (parser->drop) {
 			parser->queue[HASH_RXQ_ETH].offset += cur_item->dst_sz;
 		} else {
 			for (n = 0; n != hash_rxq_init_n; ++n)
@@ -1097,15 +1097,12 @@ priv_flow_convert(struct priv *priv,
 	 * Second step.
 	 * Allocate the memory space to store verbs specifications.
 	 */
-	if (parser->drop || parser->queues_n == 1) {
-		unsigned int priority =
-			attr->priority +
-			hash_rxq_init[HASH_RXQ_ETH].flow_priority;
-		unsigned int offset = parser->queue[HASH_RXQ_ETH].offset;
-
+	if (parser->drop) {
 		parser->queue[HASH_RXQ_ETH].ibv_attr =
-			priv_flow_convert_allocate(priv, priority,
-						   offset, error);
+			priv_flow_convert_allocate
+			(priv, attr->priority,
+			 parser->queue[HASH_RXQ_ETH].offset,
+			 error);
 		if (!parser->queue[HASH_RXQ_ETH].ibv_attr)
 			return ENOMEM;
 		parser->queue[HASH_RXQ_ETH].offset =
@@ -1159,14 +1156,9 @@ priv_flow_convert(struct priv *priv,
 	 * Last step. Complete missing specification to reach the RSS
 	 * configuration.
 	 */
-	if (parser->queues_n > 1) {
+	if (!parser->drop) {
 		priv_flow_convert_finalise(priv, parser);
 	} else {
-		/*
-		 * Action queue have their priority overridden with
-		 * Ethernet priority, this priority needs to be adjusted to
-		 * their most specific layer priority.
-		 */
 		parser->queue[HASH_RXQ_ETH].ibv_attr->priority =
 			attr->priority +
 			hash_rxq_init[parser->layer].flow_priority;
-- 
2.11.0

      parent reply	other threads:[~2018-02-27  9:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  9:31 [dpdk-stable] please help backporting some patches to LTS release 17.11.1 Yuanhan Liu
2018-02-08  7:44 ` [dpdk-stable] 答复: " wang.yong19
2018-02-08  8:46 ` [dpdk-stable] " Pavan Nikhilesh
2018-02-08  8:56   ` Yuanhan Liu
2018-02-11  4:54 ` Yuanhan Liu
2018-02-12 10:36 ` Burakov, Anatoly
2018-02-13 11:46   ` Yuanhan Liu
2018-02-13 11:49     ` Burakov, Anatoly
2018-02-20 11:02       ` Burakov, Anatoly
2019-03-06 10:56         ` Burakov, Anatoly
2019-03-06 19:03           ` Yongseok Koh
2019-03-07 12:04             ` Burakov, Anatoly
2019-03-07 20:10               ` Yongseok Koh
2018-02-14  8:58 ` [dpdk-stable] [PATCH 1/3] net/mlx5: fix secondary process verification Nelio Laranjeiro
2018-02-16 13:01   ` Yuanhan Liu
2018-02-14  8:58 ` [dpdk-stable] [PATCH 2/3] net/mlx5: fix port stop by verify flows are still present Nelio Laranjeiro
2018-02-14  8:58 ` [dpdk-stable] [PATCH 3/3] net/mlx5: fix flow priority on queue action Nelio Laranjeiro
2018-02-27  9:36 ` [dpdk-stable] [PATCH 1/3] Revert "net/mlx5: fix flow priority on queue action" Nelio Laranjeiro
2018-02-27  9:49   ` Yuanhan Liu
2018-02-27  9:36 ` [dpdk-stable] [PATCH 2/3] net/mlx5: remove parser/flow drop queue Nelio Laranjeiro
2018-02-27  9:36 ` Nelio Laranjeiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=097114bc2ce60833804089c85fc684dce667eb66.1519724131.git.nelio.laranjeiro@6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=stable@dpdk.org \
    --cc=yliu@fridaylinux.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).