patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] raw/ifpga: modify log output.
Date: Tue, 19 Mar 2019 03:09:18 +0000	[thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A613AE2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1552556863-35966-1-git-send-email-andy.pei@intel.com>

Hi,

This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer.
To enable this macro, pls follow these guides:
1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g'
2. add this option in testpmd startup: --log-level=driver.raw.init,8

> -----Original Message-----
> From: Pei, Andy
> Sent: Thursday, March 14, 2019 17:48
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] raw/ifpga: modify log output.
> 
> print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE.
> The original code just print ">>", no other useful infomation is printed.
> A new line goes after every IFPGA log.
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> index c7759b8..52fca63 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> @@ -8,10 +8,11 @@
>  extern int ifpga_rawdev_logtype;
> 
>  #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
> +	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt "\n",
> \
>  		##args)
> 
> -#define IFPGA_RAWDEV_PMD_FUNC_TRACE()
> IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
> +#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \
> +	IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__)
> 
>  #define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \
>  	IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args)
> --
> 1.8.3.1


  reply	other threads:[~2019-03-19  3:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14  9:47 Andy Pei
2019-03-19  3:09 ` Xu, Rosen [this message]
2019-03-19  7:56   ` Pei, Andy
2019-03-19 10:40     ` Xu, Rosen
2019-03-20  7:36       ` Pei, Andy
     [not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com>
2019-03-20  8:16   ` [dpdk-stable] [PATCH v2] " Xu, Rosen
2019-03-20 11:11     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0E78D399C70DA940A335608C6ED296D73A613AE2@SHSMSX104.ccr.corp.intel.com \
    --to=rosen.xu@intel.com \
    --cc=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).