From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 5B225A00E6
for <public@inbox.dpdk.org>; Wed, 17 Apr 2019 09:14:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4CDE12BC1;
Wed, 17 Apr 2019 09:14:21 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id EF7532BC1;
Wed, 17 Apr 2019 09:14:19 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
17 Apr 2019 00:14:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208";a="141348390"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
by fmsmga008.fm.intel.com with ESMTP; 17 Apr 2019 00:14:19 -0700
Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by
FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Wed, 17 Apr 2019 00:14:18 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by
SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000;
Wed, 17 Apr 2019 15:14:16 +0800
From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Kovacevic, Marko" <marko.kovacevic@intel.com>, "liq3ea@163.com"
<liq3ea@163.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
Thread-Index: AQHU9Oq+VaYIkCo18UyRqG9Ykpg/TKY/7zyQ
Date: Wed, 17 Apr 2019 07:14:16 +0000
Message-ID: <0E78D399C70DA940A335608C6ED296D73A6B81CB@SHSMSX104.ccr.corp.intel.com>
References: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
In-Reply-To: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGIxN2FlZjYtZTYwYS00YWYzLWEwZDYtNTQ3OGQ4ZjY0NGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWtiRXdLa1g4bWNnc1dNaGlTQVNIdU1CNlM0NEFvV2RHVGJxeTk2bzRhK2d1cTNRZytuazd2ZCtTM0NjY1N1WSJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
> -----Original Message-----
> From: Pei, Andy
> Sent: Wednesday, April 17, 2019 14:49
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com;
> stable@dpdk.org
> Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
Pls use raw/ifpga_rawdev prefix.
I suggest you to run ./devtools/check-git-log.sh -1 before you sending patc=
h.
> In rte_fpga_do_pr() function, if 'stat' returns error,
> rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has b=
een
> opened.
> After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EI=
NVAL
> when 'stat' returns error
Pls put this in the commit message:
Coverity issue: 279441
=20
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu@intel.com
> Cc: marko.kovacevic@intel.com
> Cc: liq3ea@163.com
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d0..eff001b 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,8 @@
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
> + ret =3D -EINVAL;
> + goto close_fd;
> }
> buffer_size =3D file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 1.8.3.1