From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E95A04B4 for ; Fri, 8 Nov 2019 15:50:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E19A91C21A; Fri, 8 Nov 2019 15:50:11 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8446F1C1F7; Fri, 8 Nov 2019 15:50:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 06:50:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,281,1569308400"; d="scan'208";a="404474299" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 08 Nov 2019 06:50:06 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 06:50:06 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 Nov 2019 06:50:06 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 8 Nov 2019 06:50:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Fri, 8 Nov 2019 22:50:04 +0800 From: "Xu, Rosen" To: Kevin Traynor , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "stable@dpdk.org" Thread-Topic: [v2 PATCH 5/8] net/ipn3ke: remove commented out code Thread-Index: AQHVlNTHWyOliXzt10CRHvrZ4x0LW6eBXdzw Date: Fri, 8 Nov 2019 14:50:04 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AB3936F@SHSMSX104.ccr.corp.intel.com> References: <20191001125315.6191-1-ktraynor@redhat.com> <20191106190203.10750-1-ktraynor@redhat.com> <20191106190203.10750-6-ktraynor@redhat.com> In-Reply-To: <20191106190203.10750-6-ktraynor@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTUwNTBmODMtNzUyZS00ODFhLWE0MTktMmVhZjhiNTBhZTRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1ExdUkwZmZqb2hOaE1qUU5uVnZTcmNXWWVaRVwvYWIzbTNGODMrb0pDUkRYZ3hNVzJDcnY0aCtVMjdQbEtqeEYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [v2 PATCH 5/8] net/ipn3ke: remove commented out code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Kevin Traynor [mailto:ktraynor@redhat.com] > Sent: Thursday, November 07, 2019 3:02 > To: dev@dpdk.org > Cc: david.marchand@redhat.com; Kevin Traynor ; > Xu, Rosen ; stable@dpdk.org > Subject: [v2 PATCH 5/8] net/ipn3ke: remove commented out code >=20 > These struct members and variable were commented out. Remove them. >=20 > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Fixes: c820468ac99c ("net/ipn3ke: support TM") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Kevin Traynor > Reviewed-by: David Marchand > --- > drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 ------- > drivers/net/ipn3ke/ipn3ke_tm.c | 1 - > 2 files changed, 8 deletions(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h > b/drivers/net/ipn3ke/ipn3ke_ethdev.h > index 985f20352..9b0cf309c 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h > @@ -97,18 +97,11 @@ struct ipn3ke_tm_node { struct ipn3ke_tm_hierarchy > { > struct ipn3ke_tm_node *port_node; > - /*struct ipn3ke_tm_node_list vt_node_list;*/ > - /*struct ipn3ke_tm_node_list cos_node_list;*/ > - > uint32_t n_shaper_profiles; > - /*uint32_t n_shared_shapers;*/ > uint32_t n_tdrop_profiles; > uint32_t n_vt_nodes; > uint32_t n_cos_nodes; > - > struct ipn3ke_tm_node *port_commit_node; > struct ipn3ke_tm_node_list vt_commit_node_list; > struct ipn3ke_tm_node_list cos_commit_node_list; > - > - /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/ > }; No problem. > diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c > b/drivers/net/ipn3ke/ipn3ke_tm.c index a93145d59..5a16c5f96 100644 > --- a/drivers/net/ipn3ke/ipn3ke_tm.c > +++ b/drivers/net/ipn3ke/ipn3ke_tm.c > @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t > tm_id, > struct rte_tm_error *error) > { > - /*struct ipn3ke_tm_internals *tm =3D > IPN3KE_DEV_PRIVATE_TO_TM(dev);*/ > uint32_t node_index; > uint32_t parent_index; > -- > 2.21.0 Reviewed-by: Rosen Xu