From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BC56A0524 for ; Sat, 4 Jul 2020 03:22:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31C931DCC8; Sat, 4 Jul 2020 03:22:26 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 8F06F1DC94; Sat, 4 Jul 2020 03:22:22 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A6C75BE4B18B8A9B6403; Sat, 4 Jul 2020 09:22:19 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Sat, 4 Jul 2020 09:22:17 +0800 To: <197020236@qq.com> References: <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com> CC: , From: "Wei Hu (Xavier)" Message-ID: <0a48f05e-f24a-a50c-65d6-3ee5a115e60c@huawei.com> Date: Sat, 4 Jul 2020 09:22:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 2020/7/4 9:15, 197020236@qq.com wrote: > From: pandongyang <197020236@qq.com> > > The function valid_bonded_port_id() has already contains function > rte_eth_dev_is_valid_port(), so delete redundant check. > > Fixes: 588ae95e7983 ("net/bonding: fix port ID check") > Cc: stable@dpdk.org > > Signed-off-by: pandongyang <197020236@qq.com> Reviewed-by: Wei Hu (Xavier) > --- > v1 -> v2: Adjust commit info > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index b77a37ddb..339374337 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port) > dev = &rte_eth_devices[port]; > internals = dev->data->dev_private; > > - if (check_for_bonded_ethdev(dev) != 0) > - return -1; > - > if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0) > return -1; > > @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port) > dev = &rte_eth_devices[port]; > internals = dev->data->dev_private; > > - if (check_for_bonded_ethdev(dev) != 0) > - return -1; > - > /* Device must be stopped to set up slow queue */ > if (dev->data->dev_started) > return -1;