* [PATCH] net/cnxk: fix deadlock in security session creation
@ 2023-01-05 13:57 David Marchand
2023-01-05 14:04 ` Zhang, Fan
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-01-05 13:57 UTC (permalink / raw)
To: dev
Cc: stable, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Vidya Sagar Velumuri
Releasing the lock was missing in this branch.
Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/cnxk/cn9k_ethdev_sec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/cnxk/cn9k_ethdev_sec.c b/drivers/net/cnxk/cn9k_ethdev_sec.c
index 67966a4e49..327f221e38 100644
--- a/drivers/net/cnxk/cn9k_ethdev_sec.c
+++ b/drivers/net/cnxk/cn9k_ethdev_sec.c
@@ -556,6 +556,7 @@ cn9k_eth_sec_session_create(void *device,
if (!dev->outb.lf_base) {
plt_err("Could not allocate security session private data");
+ rte_spinlock_unlock(lock);
return -ENOMEM;
}
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/cnxk: fix deadlock in security session creation
2023-01-05 13:57 [PATCH] net/cnxk: fix deadlock in security session creation David Marchand
@ 2023-01-05 14:04 ` Zhang, Fan
2023-01-05 14:52 ` [EXT] " Nithin Kumar Dabilpuram
0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Fan @ 2023-01-05 14:04 UTC (permalink / raw)
To: David Marchand, dev
Cc: stable, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Vidya Sagar Velumuri
On 1/5/2023 1:57 PM, David Marchand wrote:
> Releasing the lock was missing in this branch.
>
> Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/cnxk/cn9k_ethdev_sec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/cnxk/cn9k_ethdev_sec.c b/drivers/net/cnxk/cn9k_ethdev_sec.c
> index 67966a4e49..327f221e38 100644
> --- a/drivers/net/cnxk/cn9k_ethdev_sec.c
> +++ b/drivers/net/cnxk/cn9k_ethdev_sec.c
> @@ -556,6 +556,7 @@ cn9k_eth_sec_session_create(void *device,
>
> if (!dev->outb.lf_base) {
> plt_err("Could not allocate security session private data");
> + rte_spinlock_unlock(lock);
> return -ENOMEM;
> }
>
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] net/cnxk: fix deadlock in security session creation
2023-01-05 14:04 ` Zhang, Fan
@ 2023-01-05 14:52 ` Nithin Kumar Dabilpuram
2023-01-11 10:44 ` Jerin Jacob
0 siblings, 1 reply; 4+ messages in thread
From: Nithin Kumar Dabilpuram @ 2023-01-05 14:52 UTC (permalink / raw)
To: Zhang, Fan, David Marchand, dev
Cc: stable, Kiran Kumar Kokkilagadda, Sunil Kumar Kori,
Satha Koteswara Rao Kottidi, Vidya Sagar Velumuri
> -----Original Message-----
> From: Zhang, Fan <fanzhang.oss@gmail.com>
> Sent: Thursday, January 5, 2023 7:35 PM
> To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar
> Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha
> Koteswara Rao Kottidi <skoteshwar@marvell.com>; Vidya Sagar Velumuri
> <vvelumuri@marvell.com>
> Subject: [EXT] Re: [PATCH] net/cnxk: fix deadlock in security session creation
>
> External Email
>
> ----------------------------------------------------------------------
>
> On 1/5/2023 1:57 PM, David Marchand wrote:
> > Releasing the lock was missing in this branch.
> >
> > Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > drivers/net/cnxk/cn9k_ethdev_sec.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/cnxk/cn9k_ethdev_sec.c b/drivers/net/cnxk/cn9k_ethdev_sec.c
> > index 67966a4e49..327f221e38 100644
> > --- a/drivers/net/cnxk/cn9k_ethdev_sec.c
> > +++ b/drivers/net/cnxk/cn9k_ethdev_sec.c
> > @@ -556,6 +556,7 @@ cn9k_eth_sec_session_create(void *device,
> >
> > if (!dev->outb.lf_base) {
> > plt_err("Could not allocate security session private data");
> > + rte_spinlock_unlock(lock);
> > return -ENOMEM;
> > }
> >
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [EXT] Re: [PATCH] net/cnxk: fix deadlock in security session creation
2023-01-05 14:52 ` [EXT] " Nithin Kumar Dabilpuram
@ 2023-01-11 10:44 ` Jerin Jacob
0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2023-01-11 10:44 UTC (permalink / raw)
To: Nithin Kumar Dabilpuram
Cc: Zhang, Fan, David Marchand, dev, stable,
Kiran Kumar Kokkilagadda, Sunil Kumar Kori,
Satha Koteswara Rao Kottidi, Vidya Sagar Velumuri
On Thu, Jan 5, 2023 at 8:22 PM Nithin Kumar Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
>
> > -----Original Message-----
> > From: Zhang, Fan <fanzhang.oss@gmail.com>
> > Sent: Thursday, January 5, 2023 7:35 PM
> > To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar
> > Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha
> > Koteswara Rao Kottidi <skoteshwar@marvell.com>; Vidya Sagar Velumuri
> > <vvelumuri@marvell.com>
> > Subject: [EXT] Re: [PATCH] net/cnxk: fix deadlock in security session creation
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> >
> > On 1/5/2023 1:57 PM, David Marchand wrote:
> > > Releasing the lock was missing in this branch.
> > >
> > > Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > drivers/net/cnxk/cn9k_ethdev_sec.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/cnxk/cn9k_ethdev_sec.c b/drivers/net/cnxk/cn9k_ethdev_sec.c
> > > index 67966a4e49..327f221e38 100644
> > > --- a/drivers/net/cnxk/cn9k_ethdev_sec.c
> > > +++ b/drivers/net/cnxk/cn9k_ethdev_sec.c
> > > @@ -556,6 +556,7 @@ cn9k_eth_sec_session_create(void *device,
> > >
> > > if (!dev->outb.lf_base) {
> > > plt_err("Could not allocate security session private data");
> > > + rte_spinlock_unlock(lock);
> > > return -ENOMEM;
> > > }
> > >
> > Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
>
> Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-11 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 13:57 [PATCH] net/cnxk: fix deadlock in security session creation David Marchand
2023-01-05 14:04 ` Zhang, Fan
2023-01-05 14:52 ` [EXT] " Nithin Kumar Dabilpuram
2023-01-11 10:44 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).