* [PATCH v1 1/3] test/bbdev: explicit check for allocation failure [not found] <20221214233346.391973-1-nicolas.chautru@intel.com> @ 2022-12-14 23:33 ` Nicolas Chautru 2023-01-06 14:51 ` Maxime Coquelin 2023-01-10 8:32 ` Maxime Coquelin 0 siblings, 2 replies; 4+ messages in thread From: Nicolas Chautru @ 2022-12-14 23:33 UTC (permalink / raw) To: dev, maxime.coquelin; +Cc: hernan.vargas, Nicolas Chautru, stable Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: stable@dpdk.org Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index a922d69ada..b2096525ea 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, burst_sz = num_to_process - dequeued; ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); if (test_vector.op_type != RTE_BBDEV_OP_NONE) copy_reference_fft_op(ops_enq, burst_sz, dequeued, bufs->inputs, @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, burst_sz = num_to_process - dequeued; ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); if (test_vector.op_type != RTE_BBDEV_OP_NONE) copy_reference_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs, @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, burst_sz = num_to_process - dequeued; ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); if (test_vector.op_type != RTE_BBDEV_OP_NONE) copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs, -- 2.34.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure 2022-12-14 23:33 ` [PATCH v1 1/3] test/bbdev: explicit check for allocation failure Nicolas Chautru @ 2023-01-06 14:51 ` Maxime Coquelin 2023-01-06 15:37 ` Chautru, Nicolas 2023-01-10 8:32 ` Maxime Coquelin 1 sibling, 1 reply; 4+ messages in thread From: Maxime Coquelin @ 2023-01-06 14:51 UTC (permalink / raw) To: Nicolas Chautru, dev; +Cc: hernan.vargas, stable Hi Nicolas, On 12/15/22 00:33, Nicolas Chautru wrote: > Adding check for error on return of the > rte_bbdev_*_op_alloc_bulk calls in bbdev-test. > > Fixes: f714a18885a6 ("app/testbbdev: add test application for > bbdev") Above line should not be breaked, can be fixed while applying if no other comments on the series. > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index a922d69ada..b2096525ea 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_fft_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, The title and commit message does not seem to relate to the content of the patch. Is it actually fixing the patch I already merged? Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure 2023-01-06 14:51 ` Maxime Coquelin @ 2023-01-06 15:37 ` Chautru, Nicolas 0 siblings, 0 replies; 4+ messages in thread From: Chautru, Nicolas @ 2023-01-06 15:37 UTC (permalink / raw) To: Maxime Coquelin, dev; +Cc: Vargas, Hernan, stable Hi Maxime, Yes this new commit fixes the last commit on the tree. You might want to merge these 2 commits into one or not. I mentioned this in the cover letter I believe. Thanks Nic > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Friday, January 6, 2023 6:51 AM > To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org > Cc: Vargas, Hernan <hernan.vargas@intel.com>; stable@dpdk.org > Subject: Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure > > Hi Nicolas, > > On 12/15/22 00:33, Nicolas Chautru wrote: > > Adding check for error on return of the rte_bbdev_*_op_alloc_bulk > > calls in bbdev-test. > > > > Fixes: f714a18885a6 ("app/testbbdev: add test application for > > bbdev") > > Above line should not be breaked, can be fixed while applying if no other > comments on the series. > > > Cc: stable@dpdk.org > > > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > > --- > > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-bbdev/test_bbdev_perf.c > > b/app/test-bbdev/test_bbdev_perf.c > > index a922d69ada..b2096525ea 100644 > > --- a/app/test-bbdev/test_bbdev_perf.c > > +++ b/app/test-bbdev/test_bbdev_perf.c > > @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool > *mempool, struct test_buffers *bufs, > > burst_sz = num_to_process - dequeued; > > > > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, > burst_sz); > > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > ops_enq); > > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > burst_sz); > > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > > copy_reference_fft_op(ops_enq, burst_sz, > dequeued, > > bufs->inputs, > > @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool > *mempool, struct test_buffers *bufs, > > burst_sz = num_to_process - dequeued; > > > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, > burst_sz); > > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > ops_enq); > > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > burst_sz); > > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > > copy_reference_dec_op(ops_enq, burst_sz, > dequeued, > > bufs->inputs, > > @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct > rte_mempool *mempool, > > burst_sz = num_to_process - dequeued; > > > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, > burst_sz); > > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > ops_enq); > > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", > burst_sz); > > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > > copy_reference_ldpc_dec_op(ops_enq, burst_sz, > dequeued, > > bufs->inputs, > > The title and commit message does not seem to relate to the content of the > patch. Is it actually fixing the patch I already merged? > > Thanks, > Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure 2022-12-14 23:33 ` [PATCH v1 1/3] test/bbdev: explicit check for allocation failure Nicolas Chautru 2023-01-06 14:51 ` Maxime Coquelin @ 2023-01-10 8:32 ` Maxime Coquelin 1 sibling, 0 replies; 4+ messages in thread From: Maxime Coquelin @ 2023-01-10 8:32 UTC (permalink / raw) To: Nicolas Chautru, dev, Thomas Monjalon, David Marchand Cc: hernan.vargas, stable Hi Thomas & David, Below patch is a fix for a patch you didn't pulled yet. I will squash it to the faulty commit. Regards, Maxime On 12/15/22 00:33, Nicolas Chautru wrote: > Adding check for error on return of the > rte_bbdev_*_op_alloc_bulk calls in bbdev-test. > > Fixes: f714a18885a6 ("app/testbbdev: add test application for > bbdev") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index a922d69ada..b2096525ea 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_fft_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-10 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221214233346.391973-1-nicolas.chautru@intel.com>
2022-12-14 23:33 ` [PATCH v1 1/3] test/bbdev: explicit check for allocation failure Nicolas Chautru
2023-01-06 14:51 ` Maxime Coquelin
2023-01-06 15:37 ` Chautru, Nicolas
2023-01-10 8:32 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).