From: fengchengwen <fengchengwen@huawei.com>
To: Wenwu Ma <wenwux.ma@intel.com>, <dev@dpdk.org>
Cc: <songx.jiale@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] dmadev: fix structure alignment
Date: Fri, 8 Mar 2024 15:01:53 +0800 [thread overview]
Message-ID: <0c592c31-6a4d-1307-074c-5050de6c86b9@huawei.com> (raw)
In-Reply-To: <20240308053711.1260154-1-wenwux.ma@intel.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/8 13:37, Wenwu Ma wrote:
> The structure rte_dma_dev needs cacheline alignment, but the return
> value of malloc may not be aligned to the cacheline. Therefore,
> extra memory is applied for realignment.
>
> Fixes: b36970f2e13e ("dmadev: introduce DMA device library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
> lib/dmadev/rte_dmadev.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> index 5953a77bd6..61e106d574 100644
> --- a/lib/dmadev/rte_dmadev.c
> +++ b/lib/dmadev/rte_dmadev.c
> @@ -160,15 +160,25 @@ static int
> dma_dev_data_prepare(void)
> {
> size_t size;
> + void *ptr;
>
> if (rte_dma_devices != NULL)
> return 0;
>
> - size = dma_devices_max * sizeof(struct rte_dma_dev);
> - rte_dma_devices = malloc(size);
> - if (rte_dma_devices == NULL)
> + /* The dma device object is expected to align cacheline, but
> + * the return value of malloc may not be aligned to the cache line.
> + * Therefore, extra memory is applied for realignment.
> + * note: We do not call posix_memalign/aligned_alloc because it is
> + * version dependent on libc.
> + */
> + size = dma_devices_max * sizeof(struct rte_dma_dev) +
> + RTE_CACHE_LINE_SIZE;
> + ptr = malloc(size);
> + if (ptr == NULL)
> return -ENOMEM;
> - memset(rte_dma_devices, 0, size);
> + memset(ptr, 0, size);
> +
> + rte_dma_devices = RTE_PTR_ALIGN(ptr, RTE_CACHE_LINE_SIZE);
>
> return 0;
> }
>
next prev parent reply other threads:[~2024-03-08 7:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 5:37 Wenwu Ma
2024-03-08 7:01 ` fengchengwen [this message]
2024-03-15 1:43 ` [PATCH v2] " Wenwu Ma
2024-03-15 6:02 ` Tyler Retzlaff
2024-03-15 6:06 ` fengchengwen
2024-03-15 6:25 ` Ma, WenwuX
2024-03-15 7:44 ` Ma, WenwuX
2024-03-15 8:31 ` fengchengwen
2024-03-15 9:27 ` Ma, WenwuX
2024-03-20 4:11 ` fengchengwen
2024-03-20 7:34 ` Ma, WenwuX
2024-03-19 9:48 ` Jiale, SongX
2024-03-20 7:23 ` [PATCH v3] " Wenwu Ma
2024-03-20 9:31 ` fengchengwen
2024-06-27 12:46 ` Thomas Monjalon
2024-03-20 11:37 ` Thomas Monjalon
2024-03-21 1:25 ` Ma, WenwuX
2024-03-21 8:30 ` Thomas Monjalon
2024-03-21 8:57 ` Ma, WenwuX
2024-03-21 9:18 ` Ma, WenwuX
2024-03-21 10:06 ` Thomas Monjalon
2024-03-21 16:05 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c592c31-6a4d-1307-074c-5050de6c86b9@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=songx.jiale@intel.com \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).