* [dpdk-stable] [PATCH v2] net/bonding: don't clear active slave count
[not found] <20180606122627.18418-1-3chas3@gmail.com>
@ 2018-07-04 2:28 ` Chas Williams
2018-07-05 12:42 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chas Williams @ 2018-07-04 2:28 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Charles (Chas) Williams, stable
From: "Charles (Chas) Williams" <chas3@att.com>
When the bond PMD is stopped, the active slave count is reset.
For 802.3ad mode this potentially leaks memory and clears state since
a second sequential activate_slave() will occur when the bond PMD is
restarted and the LSC callback is triggered while the active slave
count is 0. To fix this, don't clear the active slave count when
stopping. Only deactivate_slave() should be used to clear the slaves.
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <chas3@att.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index e32fa3976..3f3cddf26 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2229,7 +2229,6 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
tlb_last_obytets[internals->active_slaves[i]] = 0;
}
- internals->active_slave_count = 0;
internals->link_status_polling_enabled = 0;
for (i = 0; i < internals->slave_count; i++)
internals->slaves[i].last_link_status = 0;
--
2.14.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [PATCH v2] net/bonding: don't clear active slave count
2018-07-04 2:28 ` [dpdk-stable] [PATCH v2] net/bonding: don't clear active slave count Chas Williams
@ 2018-07-05 12:42 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-07-05 12:42 UTC (permalink / raw)
To: Chas Williams, dev; +Cc: declan.doherty, Charles (Chas) Williams, stable
On 7/4/2018 3:28 AM, Chas Williams wrote:
> From: "Charles (Chas) Williams" <chas3@att.com>
>
> When the bond PMD is stopped, the active slave count is reset.
> For 802.3ad mode this potentially leaks memory and clears state since
> a second sequential activate_slave() will occur when the bond PMD is
> restarted and the LSC callback is triggered while the active slave
> count is 0. To fix this, don't clear the active slave count when
> stopping. Only deactivate_slave() should be used to clear the slaves.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chas Williams <chas3@att.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-05 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180606122627.18418-1-3chas3@gmail.com>
2018-07-04 2:28 ` [dpdk-stable] [PATCH v2] net/bonding: don't clear active slave count Chas Williams
2018-07-05 12:42 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).